New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780917 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Feature



Sign in to add a comment

Add User Actions for site muting

Project Member Reported by steimel@chromium.org, Nov 2 2017

Issue description

We want User Actions for each method of toggling site muting state (page info, site info, tab strip, manually adding a site exception) with both a mute and unmute action for each.

We also want a User Action for toggling the global sound setting switch.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dea90f7a61dadd79979f4c00b10fece9e0c1f634

commit dea90f7a61dadd79979f4c00b10fece9e0c1f634
Author: Tommy Steimel <steimel@chromium.org>
Date: Tue Nov 07 20:58:03 2017

Add User Actions for site muting

This CL adds mute and unmute User Actions for each of the different
ways the user can change the sound setting.

Bug:  780917 
Change-Id: Ica33368ef7c5a1cefe2cf0acd83cba99b77bae1b
Reviewed-on: https://chromium-review.googlesource.com/752690
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514572}
[modify] https://crrev.com/dea90f7a61dadd79979f4c00b10fece9e0c1f634/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java
[modify] https://crrev.com/dea90f7a61dadd79979f4c00b10fece9e0c1f634/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/Website.java
[modify] https://crrev.com/dea90f7a61dadd79979f4c00b10fece9e0c1f634/chrome/browser/android/preferences/pref_service_bridge.cc
[modify] https://crrev.com/dea90f7a61dadd79979f4c00b10fece9e0c1f634/chrome/browser/ui/page_info/page_info.cc
[modify] https://crrev.com/dea90f7a61dadd79979f4c00b10fece9e0c1f634/chrome/browser/ui/tabs/tab_strip_model_impl.cc
[modify] https://crrev.com/dea90f7a61dadd79979f4c00b10fece9e0c1f634/chrome/browser/ui/webui/settings/site_settings_handler.cc
[modify] https://crrev.com/dea90f7a61dadd79979f4c00b10fece9e0c1f634/tools/metrics/actions/actions.xml

Status: Fixed (was: Started)
Cc: hdodda@chromium.org
Labels: Needs-Feedback
@steimel-- Could you please provide us the steps to verify the fix , if it has to be verified from the TE-End .

Thanks!
Labels: -Type-Bug -Needs-Feedback Type-Feature
This isn't a bug but addition of metrics so no need to manual verification.

Sign in to add a comment