Add support for viewport-fit=cover
Reported by
tyler.fr...@willowtreeapps.com,
Nov 2 2017
|
||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36 Steps to reproduce the problem: 1. Add a metatag to page that uses viewport-fit 2. Inspect developer console What is the expected behavior? No warning is shown. What went wrong? The warning "The key "viewport-fit" is not recognized and ignored." is shown. Did this work before? N/A Chrome version: 61.0.3163.100 Channel: n/a OS Version: OS X 10.12.6 Flash Version: Shockwave Flash 27.0 r0 viewport-fit is metatag used by the iPhone X to enable edge to edge display. According to webkit documentation, this tag should be used to determine how insets are set. https://webkit.org/blog/7929/designing-websites-for-iphone-x/
,
Nov 13 2017
Thanks for the report. Sending over to CSS team, is there intent?
,
Nov 14 2017
Thank you for reporting this. Do you have a test case?
,
Nov 18 2017
At a minimum, please squash the warning asap, similar to Issue 569649 [1], since we are all stuck with this one now as well, thanks to the iPhone X. Regarding a test case, example meta tag is: <meta name='viewport' content='initial-scale=1, viewport-fit=cover’>, Chrome complains about 'viewport-fit' as described by the original reporter. Thanks, - John [1] https://bugs.chromium.org/p/chromium/issues/detail?id=569649 Reproduces in: Google Chrome 62.0.3202.94 (Official Build) (64-bit) Revision 4fd852a98d66564c88736c017b0a0b0478e885ad-refs/branch-heads/3202@{#789} OS Mac OS X JavaScript V8 6.2.414.42 User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.94 Safari/537.36
,
Nov 20 2017
I've attached a file that has the meta tag mentioned above. If viewing the file on an iPhone X simulator, the page should not have in-sets. If "viewport-fit=cover" is removed, the iPhone X simulator will display the page with in-sets.
,
Nov 20 2017
Thank you for providing more feedback. Adding requester "rjwright@chromium.org" to the cc list and removing "Needs-Feedback" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 20 2017
,
Nov 20 2017
I want to second comment 4, please remove the console warning: > The key "viewport-fit" is not recognized and ignored.
,
Nov 21 2017
Change in review: https://chromium-review.googlesource.com/#/c/chromium/src/+/781302
,
Nov 21 2017
,
Nov 21 2017
,
Nov 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/609e1af2dfff95caf54a6231e80dbb38a6fd5a6d commit 609e1af2dfff95caf54a6231e80dbb38a6fd5a6d Author: Victoria Su <victoriaytsu@google.com> Date: Thu Nov 23 22:48:14 2017 DevTools: No warning for meta viewport viewport-fit Suppressed warning "The key 'viewport-fit' is not recognized and ignored." BUG=780904 Change-Id: Ieb4ea9d6ec88fcb56304625212032e0655e3829c Reviewed-on: https://chromium-review.googlesource.com/781302 Reviewed-by: nainar <nainar@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Victoria Su <victoriaytsu@google.com> Cr-Commit-Position: refs/heads/master@{#519024} [modify] https://crrev.com/609e1af2dfff95caf54a6231e80dbb38a6fd5a6d/third_party/WebKit/Source/core/html/HTMLMetaElement.cpp [modify] https://crrev.com/609e1af2dfff95caf54a6231e80dbb38a6fd5a6d/third_party/WebKit/Source/core/page/ViewportTest.cpp [add] https://crrev.com/609e1af2dfff95caf54a6231e80dbb38a6fd5a6d/third_party/WebKit/Source/core/testing/data/viewport/viewport-warnings-8.html
,
Nov 24 2017
,
Nov 28 2017
,
Dec 5 2017
This bug remains open as "viewport-fit=cover" is not currently supported by Blink. We have simply suppressed the warning.
,
Dec 6 2017
,
Dec 6
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 10
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by ligim...@chromium.org
, Nov 3 2017