ASSERT: false |
|||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=4735415939760128 Fuzzer: libFuzzer_zlib_inflate_fuzzer Job Type: libfuzzer_chrome_asan_debug Platform Id: linux Crash Type: ASSERT Crash Address: Crash State: false _start Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=513357:513386 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4735415939760128 Issue filed automatically. See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
,
Nov 3 2017
Chris, are you sure that it's a proper use of assert? https://chromium.googlesource.com/chromium/src/+/315ab39662be6086b31d56c5a26190360c57e3ee/third_party/zlib/contrib/tests/fuzzers/inflate_fuzzer.cc#40 I guess we'll see tons of assertions there, e.g. even 2 bytes input is enough to trigger that.
,
Nov 3 2017
Right. I'm going to fix this soon. I shouldn't have the second assert on the inflate() success. Invalid, non-compressed input will result in no inflation and an error code. I shouldn't assert on that since we want to provide invalid input. Was just wrapping up an interview.
,
Nov 3 2017
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47f7d7eb2c2c3e313b3423786802f6372e4891a5 commit 47f7d7eb2c2c3e313b3423786802f6372e4891a5 Author: Chris Blume <cblume@google.com> Date: Fri Nov 10 00:51:10 2017 Fix zlib_inflate_fuzzer asserting zlib_inflate_fuzzer currently asserts when the call to inflate() fails. However, invalid inputs are expected in fuzz testing. So inflate() failing is an expected case here. Remove the assert on inflate() succeeding. BUG= 780898 Change-Id: If62bff55f31a67d2fefa4e780f283f97f88f7707 Reviewed-on: https://chromium-review.googlesource.com/753133 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#515383} [modify] https://crrev.com/47f7d7eb2c2c3e313b3423786802f6372e4891a5/third_party/zlib/contrib/tests/fuzzers/inflate_fuzzer.cc
,
Nov 10 2017
,
Nov 10 2017
ClusterFuzz has detected this issue as fixed in range 515346:515403. Detailed report: https://clusterfuzz.com/testcase?key=4735415939760128 Fuzzer: libFuzzer_zlib_inflate_fuzzer Job Type: libfuzzer_chrome_asan_debug Platform Id: linux Crash Type: ASSERT Crash Address: Crash State: false _start Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=513357:513386 Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=515346:515403 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4735415939760128 See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Nov 10 2017
ClusterFuzz testcase 4735415939760128 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
,
Nov 13 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kkaluri@chromium.org
, Nov 3 2017Components: Internals>GPU>SwiftShader
Labels: M-64 Test-Predator-Wrong
Owner: cblume@chromium.org
Status: Assigned (was: Untriaged)