New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780895 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 774264



Sign in to add a comment

Add a "Discard history" section in chrome://discards

Project Member Reported by cylee@chromium.org, Nov 2 2017

Issue description

Although we have records for which tabs/apps are discarded in log files, it lacks an intuitive and easy way to know when/why a tab is discarded. We do have discard counts and discard status in chrome://discards, but it didn't show the full history so we can't observe if tabs are discarded in the desired order.

My proposal is to add a "history" section in this page, so one can easily observe if the kill order is reasonable. In additional to it, we can also list the discard times (if any) of each tab in the tab list.
 

Comment 1 by cylee@chromium.org, Nov 2 2017

Blocking: 774264
It's a nice idea but I am not sure it's worth the extra work, since one can always look at the logs.
Cc: puneetster@chromium.org
The discard history is not in the logs either unless vmodule is enabled via passing "--enable-logging=stderr vmodule=tab_manager_delegate_chromeos=3". The feature was requested by Puneet as many dogfooders are using enterprise enrolled devices and they cannot pass additional flags to Chrome.

When the discard history is collected we want to attach that to the feedback report too.
Components: Privacy
hey,

where can I read about what information is stored in those logs, and where they are stored?

thanks
Cc: sonnyrao@chromium.org
#3 I don't agree with the statement that "the discard history is not in the logs".  The chrome user log in feedback reports contains a lot of details (even too many) about discarded tabs, starting with this line:

[1508:1508:0604/143119.222688:WARNING:oom_memory_details.cc(46)] Tab Discards Memory details (109 ms):

etc. etc.  This is followed by a complete list of tabs and apps with their OOM scores, which indicate the (current) order of discard.  The chrome user logs in the feedback reports are generously sized and I cannot remember a single instance in which I felt it would have been useful to have additional history.

Having said this, if you feel it is important for users to see their own discard history immediately, that's a different story.  I think it would be useful to present an example. 
#4 the additional "discard history" logs, as I understand it, would not contain any information that's not already present in the chrome user log currently included in feedback reports.  However, it could potentially contain a longer history than is available in the chrome user log.  Note that we do not specify anywhere, implicitly or explicitly, the time span of events included in logs in the feedback reports.

Comment 7 by cylee@chromium.org, Nov 3 2017

Currently the detailed log (the full list of tabs considered on low memory condition, tab killed by tab manager, OOM-ed tabs, etc) are recorded by MEMORY_LOG (https://cs.chromium.org/chromium/src/components/device_event_log/device_event_log.h?type=cs&q=memory_log&sq=package:chromium&l=60). So they're available in feedback report and chrome://device-log . I believe it's true for non-developer mode machines as well.

That said, it's mainly used for debug purpose and not displayed in a very neat way. If a normal user would like to have a quick glance of how/what tabs are discarded, I think chrome://discards would be a better place.
Status: Assigned (was: Untriaged)

Sign in to add a comment