New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780893 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 780891

Blocking:
issue 776892
issue 780899



Sign in to add a comment

Migrate the 'platform' bit from label:board to label:model

Project Member Reported by pprabhu@chromium.org, Nov 2 2017

Issue description

model is the new board.

After issue 780891 is fixed, all DUTs have a valid model, and model correctly reflects the platform.

So migrate the platform bit for all labels.
 
Blockedon: 780891
See also: https://bugs.chromium.org/p/chromium/issues/detail?id=780516

Some variant:XXXX labels also seem to have the platform bit set.
Blocking: 780899
Blocking: 776892
Cc: akes...@chromium.org pprabhu@chromium.org keta...@chromium.org ppichai@google.com nsanders@chromium.org
 Issue 782507  has been merged into this issue.
The CL to fix model labels for old DUTs was pushed today. I'll check tomorrow if they were updated correctly. This is blocked on all (most) DUTs getting the correct model information.
Cc: dshi@chromium.org
Rinse and repeat: crbug.com/555675

Owner: dshi@chromium.org
I think my understanding here was wrong. wmatrix's (and possibly goldeneye's?) 'platform' is actually determined by tko entires only. And we seem to be dumping the platform label based on some logic in tko/parse: 

https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/312566

So... that's what I update to dump model if a model is available? (falling back to board if model is not available, for non-cros boards)

-->dshi@ to confirm.

Comment 9 by dshi@chromium.org, Nov 9 2017

TKO records are generated based on test keyvals. The board information is retrieved from board label which is included in job keyvals:
https://cs.corp.google.com/android/external/autotest/tko/parse.py?rcl=e6064014132c17d4893ee165c0836357f7258231&l=397

is there a path decided on here .... coral testing is blocked by this
Owner: pprabhu@chromium.org
pprabhu is working on this
Owner: dshi@chromium.org
Dan has agreed to do this early next week. It will be faster that way, seriously.

I realize that I don't know quite enough about TKO to do this in a hurry. I'll follow along for future requests of this sort.

Comment 13 by dshi@chromium.org, Nov 15 2017

Status: Fixed (was: Assigned)
Following CL is landed and pushed to lab, tko should be using model: label for machine_group now.
https://chromium-review.googlesource.com/#/c/chromiumos/third_party/autotest/+/767109/

Sign in to add a comment