Drop --board from balance_pool, dut-status in favor of --model |
||||||||
Issue descriptionmodel is the new board Once issue 780891 is fixed, we can be sure that the model label is correct for all labels. Then, just drop the obsolete --board flag from our administrative tools: (1) balance_pool (2) dut_status
,
Nov 2 2017
,
Nov 3 2017
,
Nov 3 2017
Issue 780876 has been merged into this issue.
,
Nov 8 2017
https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/751688 https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/752026 Add the new --model flag to balance_pool We need another CL to have --all-boards imply --all-boards-and-models. Eventually, we can complete drop --board completely, but let's not be hasty.
,
Nov 9 2017
I have a stack of CLs for this in-flight. Expect to have everything ready today, pending review.
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0ecbf322278bb5448f2bbe324884ed6e01528b9a commit 0ecbf322278bb5448f2bbe324884ed6e01528b9a Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Nov 10 03:16:22 2017 inventory: Rename classes to be more generic. BUG= chromium:780892 TEST=unittests. Change-Id: I6a49840b22791bb9c3e657d185720c8e7a8b8b25 Reviewed-on: https://chromium-review.googlesource.com/759716 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/0ecbf322278bb5448f2bbe324884ed6e01528b9a/site_utils/lab_inventory.py [modify] https://crrev.com/0ecbf322278bb5448f2bbe324884ed6e01528b9a/site_utils/lab_inventory_unittest.py
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4971c1fa3fb6df183bac6d5a8fc4377bf23792e0 commit 4971c1fa3fb6df183bac6d5a8fc4377bf23792e0 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Nov 10 03:16:22 2017 autotest: Drop spurious imports of lab_inventory BUG= chromium:780892 TEST=None Change-Id: I775d8c2f4133fc934b31a4bb6260b074eaf55947 Reviewed-on: https://chromium-review.googlesource.com/759717 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/4971c1fa3fb6df183bac6d5a8fc4377bf23792e0/site_utils/dut_status.py [modify] https://crrev.com/4971c1fa3fb6df183bac6d5a8fc4377bf23792e0/scheduler/rdb_hosts.py
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/154cb2b41714873728ca98aec921087f29ab1d86 commit 154cb2b41714873728ca98aec921087f29ab1d86 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Nov 10 03:16:23 2017 inventory: Make inventory-classified-by-board an attribute. So far, inventory is always classified by board. We now want to also classify inventory by model. In preparation for that, add an attribute that stores the by_board classification. BUG= chromium:780892 TEST=unittests Change-Id: I37658df2d0533ee20c72ed3269d187e6eb6cc171 Reviewed-on: https://chromium-review.googlesource.com/759718 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/154cb2b41714873728ca98aec921087f29ab1d86/site_utils/balance_pools.py [modify] https://crrev.com/154cb2b41714873728ca98aec921087f29ab1d86/site_utils/lab_inventory_unittest.py [modify] https://crrev.com/154cb2b41714873728ca98aec921087f29ab1d86/site_utils/lab_inventory.py [modify] https://crrev.com/154cb2b41714873728ca98aec921087f29ab1d86/site_utils/suite_scheduler/constants.py
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/021e7842e83a9726b572c7766e2c5516b8ef3678 commit 021e7842e83a9726b572c7766e2c5516b8ef3678 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Nov 10 03:16:23 2017 inventory: Use labellib for label manipulation BUG= chromium:780892 TEST=unittest Change-Id: I6d0d68f47860a0f3d19fb26da8889369350b1d20 Reviewed-on: https://chromium-review.googlesource.com/759719 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/021e7842e83a9726b572c7766e2c5516b8ef3678/site_utils/lab_inventory.py [modify] https://crrev.com/021e7842e83a9726b572c7766e2c5516b8ef3678/site_utils/lab_inventory_unittest.py
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/c8cf0f6e6863c923a3d9fae5343d6eae265e5b76 commit c8cf0f6e6863c923a3d9fae5343d6eae265e5b76 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Nov 10 05:46:04 2017 inventory: Add option to chose AFE to hit. ... like all our other scripts. BUG= chromium:780892 TEST=./site_utils/balance_pools.py -n bvt link -w cautotest Change-Id: Iddeb2556a17db950d72c0e3bc86f349ca8f0ba01 Reviewed-on: https://chromium-review.googlesource.com/760718 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/c8cf0f6e6863c923a3d9fae5343d6eae265e5b76/site_utils/balance_pools.py
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7a050da47e6190c444a2171ab51288368f0ae678 commit 7a050da47e6190c444a2171ab51288368f0ae678 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Nov 10 23:30:49 2017 inventory: Make metrics collection more robust We should Flush metrics even in case of errors. BUG= chromium:780892 TEST=local dry-run. Change-Id: I41a8f56a9889d773613d1ba73e7ec5b32ceecf33 Reviewed-on: https://chromium-review.googlesource.com/760668 Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/7a050da47e6190c444a2171ab51288368f0ae678/site_utils/balance_pools.py
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/58aede832b99dc6e5ca302d0656fe9190dd23a59 commit 58aede832b99dc6e5ca302d0656fe9190dd23a59 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Nov 10 23:31:08 2017 inventory: Simplify LabInventory tests. - Make test data more explicit. - Make test data agnostic enough to 'board' so that we can add tests that key data by model. BUG= chromium:780892 TEST=unittests. Change-Id: I0c0cf0e53bce931cf9e02eccfd7c28bf018d0070 Reviewed-on: https://chromium-review.googlesource.com/761679 Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/58aede832b99dc6e5ca302d0656fe9190dd23a59/site_utils/lab_inventory_unittest.py
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a5a0e3d64c7824faa44213afa8dcff88a87dede1 commit a5a0e3d64c7824faa44213afa8dcff88a87dede1 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Fri Nov 10 23:31:19 2017 Support lab inventory summary by model LabInventory can now summarize DUT histories by board as well as model. This will allow all scripts that use LabInventory to slowly migrate to respecting models instead of boards. BUG= chromium:780892 TEST=unittests. Change-Id: I422b4bd151b3bad97591eed3da23b6c12c968414 Reviewed-on: https://chromium-review.googlesource.com/760498 Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/a5a0e3d64c7824faa44213afa8dcff88a87dede1/site_utils/lab_inventory.py [modify] https://crrev.com/a5a0e3d64c7824faa44213afa8dcff88a87dede1/site_utils/lab_inventory_unittest.py
,
Nov 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/68acc40f80557b39a93f47ca49754db281350cee commit 68acc40f80557b39a93f47ca49754db281350cee Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Sat Nov 11 09:26:15 2017 autotest: Uniformly support DUT labels in status_history So far, get_multiple_histories supported the 'board' and 'pool' arguments. We now need 'model'. Just support generic 'labels' instead. BUG= chromium:780892 TEST=(1) unittests (didn't catch bugs I had in earlier iterations) (2) ./site_utils/balance_pools.py -n -t 3 cq link (3) ./site_utils/dut_status.py -b link -p cq (4) grep for and update all callers of get_multiple_histories. Change-Id: I57cc2e0e59e9532d4fd76aa1718d97787eda0a6e Reviewed-on: https://chromium-review.googlesource.com/762098 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/68acc40f80557b39a93f47ca49754db281350cee/site_utils/dut_status.py [modify] https://crrev.com/68acc40f80557b39a93f47ca49754db281350cee/site_utils/balance_pools.py [modify] https://crrev.com/68acc40f80557b39a93f47ca49754db281350cee/utils/labellib.py [modify] https://crrev.com/68acc40f80557b39a93f47ca49754db281350cee/server/lib/status_history.py [modify] https://crrev.com/68acc40f80557b39a93f47ca49754db281350cee/site_utils/diagnosis_utils.py
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/bb5cb294da9aa7ffe42e3a75ec788b136192ce4a commit bb5cb294da9aa7ffe42e3a75ec788b136192ce4a Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed Nov 15 18:38:28 2017 inventory: Support models in balance_pool. BUG= chromium:780892 TEST=Run balance_pool in all sorts of configurations with --dry-run Change-Id: I47bc57391200bea145e936aecf4b9d7ad99b6b4d Reviewed-on: https://chromium-review.googlesource.com/762597 Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Trybot-Ready: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/bb5cb294da9aa7ffe42e3a75ec788b136192ce4a/site_utils/balance_pools.py
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/eedbf8a26b73174c1d5e06480ded5aeaf67fed49 commit eedbf8a26b73174c1d5e06480ded5aeaf67fed49 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Wed Nov 15 20:10:20 2017 inventory: Start balancing by models in automated job. BUG= chromium:780892 TEST=None Change-Id: I671902ac9eb160f31e66a2382afc079def023468 Reviewed-on: https://chromium-review.googlesource.com/772331 Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/eedbf8a26b73174c1d5e06480ded5aeaf67fed49/contrib/run-pool-inventory
,
Nov 15 2017
,
Nov 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/44befad1064eac84ed3c9ce6b5da25875f368ecb commit 44befad1064eac84ed3c9ce6b5da25875f368ecb Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Sat Nov 18 04:18:52 2017 inventory: Support models in dut_status BUG= chromium:780892 TEST=Run dut_status for robo360 Change-Id: I63d2aff5fb1083fb4ad6c10718c4fa38442bcac5 Reviewed-on: https://chromium-review.googlesource.com/772310 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/44befad1064eac84ed3c9ce6b5da25875f368ecb/site_utils/dut_status.py
,
Jan 3 2018
,
Jan 3 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by pprabhu@chromium.org
, Nov 2 2017