New issue
Advanced search Search tips

Issue 780886 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

webkit_layout_tests failing on chromium.win/Win7 Tests (dbg)(1)

Project Member Reported by s...@chromium.org, Nov 2 2017

Issue description

webkit_layout_tests failing on chromium.win/Win7 Tests (dbg)(1)

Builders failed on: 
- Win7 Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29



 

Comment 1 by s...@chromium.org, Nov 2 2017

Cc: dpranke@chromium.org
Range of commits are https://chromium.googlesource.com/chromium/src/+log/32af0b0b4de23ef5bfcd7a6f067877cbff04d94c%5E..e97e53dd9ec5d78c000a2acb32138350bd7ce40d?pretty=fuller&n=

Most notably it contains https://chromium.googlesource.com/chromium/src/+/32af0b0b4de23ef5bfcd7a6f067877cbff04d94c which adds the webkit_layout_tests to Win7 dbg, which seems like a likely culprit.

It is unclear to me if the other WebKit changes in the regression range simultaneously broke Win7 dbg, or if it never worked on this platform.

Comment 2 by s...@chromium.org, Nov 2 2017

Looks like dpranke was already aware of this, and has removed the timeout, see
https://chromium.googlesource.com/chromium/src/+/3fde8b3bb82cff7cd439c600ffd23a6e99141cd7


Comment 3 by s...@chromium.org, Nov 2 2017

Cc: -dpranke@chromium.org s...@chromium.org
Owner: dpranke@chromium.org
Status: Assigned (was: Available)
Assigning to dpranke, https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64426 is currently building with timeout removed, we'll see if it succeeds or not shortly.
Status: Started (was: Assigned)
Yup, this is on me, let's see if my CL fixes it, and, if not, I'll deal with it.
(thanks!)

Comment 6 by meade@chromium.org, Nov 6 2017

Status: Fixed (was: Started)
The bot went green again briefly in https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64427, and now are failing for a different reason. Will close this bug.

Sign in to add a comment