Changing policy_templates.json can cause retranslation of policy descriptions.

Retranslations are triggered when the message IDs in .xmb files generated by the grit tool change due to the CL.

This can be tried manually using:
python tools/grit/grit.py -i ${PWD}/components/policy/resources/policy_templates.grd xmb <directory>/without_cl.xmb
git cl patch <cl>
${PWD}/components/policy/resources/policy_templates.grd xmb <directory>/with_cl.xmb

and diffing <directory>/without_cl.xmb <directory>/with_cl.xmb.

If we could run grit referencing the base files (without the CL), we could warn if more than e.g. 10 IDs are changing.

We could probably use the OldContents function from presubmit_support for this.

 

Changing policy_templates.json can cause retranslation of policy descriptions.

Retranslations are triggered when the message IDs in .xmb files generated by the grit tool change due to the CL.

This can be tried manually using:
python tools/grit/grit.py -i ${PWD}/components/policy/resources/policy_templates.grd xmb <directory>/without_cl.xmb
git cl patch <cl>
python tools/grit/grit.py -i ${PWD}/components/policy/resources/policy_templates.grd xmb <directory>/with_cl.xmb

and diffing <directory>/without_cl.xmb <directory>/with_cl.xmb.

If we could run grit referencing the base files (without the CL), we could warn if more than e.g. 10 IDs are changing.

We could probably use the OldContents function from presubmit_support for this.