New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780875 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

CommitQueueHandleChangesStage not run after CommitQueueCompletionStage failure

Project Member Reported by nxia@chromium.org, Nov 2 2017

Issue description

CommitQueueHandleChangesStage didn't get run if CommitQueueCompletionStage failed, so CLs didn't get submitted when important slaves failed. 
 
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/d41fbd6014b7950e05aaf0fa87536a2128c6d5eb

commit d41fbd6014b7950e05aaf0fa87536a2128c6d5eb
Author: Ningning Xia <nxia@chromium.org>
Date: Thu Nov 02 20:04:06 2017

simple_builders: _HandleChanges when important slaves failed.

When the completion stage only raises ImportantBuilderFailedException,
still run _HandleChanges to submit partial CLs.

BUG= chromium:780875 
TEST=unit_tests

Change-Id: I0cc5895eeeaf7796b3bf1e6ff8a4f3b2eebc69e7
Reviewed-on: https://chromium-review.googlesource.com/751797
Reviewed-by: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/d41fbd6014b7950e05aaf0fa87536a2128c6d5eb/cbuildbot/stages/completion_stages_unittest.py
[modify] https://crrev.com/d41fbd6014b7950e05aaf0fa87536a2128c6d5eb/cbuildbot/stages/generic_stages.py
[modify] https://crrev.com/d41fbd6014b7950e05aaf0fa87536a2128c6d5eb/cbuildbot/builders/simple_builders_unittest.py
[modify] https://crrev.com/d41fbd6014b7950e05aaf0fa87536a2128c6d5eb/cbuildbot/builders/simple_builders.py

Comment 4 by nxia@chromium.org, Nov 2 2017

Status: Fixed (was: Untriaged)

Sign in to add a comment