New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780870 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

balance_pool -n (dry run) doesn't make it clear it is dry run

Project Member Reported by akes...@chromium.org, Nov 2 2017

Issue description

$ balance_pool -n -t 8 cq coral

# Balancing coral cq pool:
# Total 0 DUTs, 0 working, 0 broken, 0 reserved.
# Target is 8 working DUTs; grow pool by 8 DUTs.
# coral cq pool has 37 spares available.
# coral cq pool will return 0 broken DUTs, leaving 0 still in the pool.
# Transferring 8 DUTs from suites to cq.
atest label remove -m chromeos2-row4-rack10-host1 pool:suites
atest label add -m chromeos2-row4-rack10-host1 pool:cq
atest label remove -m chromeos2-row4-rack10-host8 pool:suites
atest label add -m chromeos2-row4-rack10-host8 pool:cq
atest label remove -m chromeos2-row4-rack10-host9 pool:suites
atest label add -m chromeos2-row4-rack10-host9 pool:cq
atest label remove -m chromeos2-row4-rack10-host12 pool:suites
atest label add -m chromeos2-row4-rack10-host12 pool:cq
atest label remove -m chromeos2-row6-rack6-host1 pool:suites
atest label add -m chromeos2-row6-rack6-host1 pool:cq
atest label remove -m chromeos2-row6-rack6-host2 pool:suites
atest label add -m chromeos2-row6-rack6-host2 pool:cq
atest label remove -m chromeos2-row6-rack6-host3 pool:suites
atest label add -m chromeos2-row6-rack6-host3 pool:cq
atest label remove -m chromeos2-row6-rack6-host4 pool:suites
atest label add -m chromeos2-row6-rack6-host4 pool:cq


Nowhere in that logging does it actually verify that it is dryrun, which scared me and caused me to chase after the hosts to see that they weren't modified.
 
Components: -Infra>Client>ChromeOS Infra>Client>ChromeOS>Test
Labels: Hotlist-Fixit
Status: Available (was: Untriaged)

Sign in to add a comment