New issue
Advanced search Search tips

Issue 780869 link

Starred by 1 user
Status: Fixed
Owner:
dougarnett@chromium.org
Closed: Nov 2017
Cc:
sophiechang@chromium.org
ryansturm@chromium.org
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task

Blocking:
issue 801275



Sign in to add a comment

Relocate PreviewsIOData from previews/core to previews/content

Project Member Reported by dougarnett@chromium.org, Nov 2 2017 
Related to wanting to make the previews component no longer be layered for ios ( bug 778292 ), a baby step would be to move PreviewsIOData and PreviewsUIService from core/ to content/. 

I believe this minimal step would be sufficient to enable the cacao project to have previews be able to depend on the new optimization_guide component to get notified of updates.

Comment 1 by bengr@chromium.org, Nov 3 2017

Labels: -Pri-3 M-65 Pri-2
Please mark this as blocking the relevant cacao-related issue.

Comment 2 by dougarnett@chromium.org, Nov 6 2017

Blocking: 776847
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a

commit 46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a
Author: Doug Arnett <dougarnett@chromium.org>
Date: Tue Nov 07 00:31:47 2017

Moves PreviewsIOData and PreviewsUIService from core to content

This is a simple move refactor to allow future change to PreviewsIOData
to take a content dependency.

Bug:  780869 
Change-Id: I5327c4991f2ce731b30fdbbf612a053d0f18f71a
Reviewed-on: https://chromium-review.googlesource.com/752424
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514319}
[modify] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
[modify] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/chrome/browser/previews/previews_infobar_delegate.cc
[modify] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/chrome/browser/previews/previews_infobar_tab_helper.cc
[modify] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/chrome/browser/previews/previews_service.cc
[modify] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/chrome/browser/previews/previews_service_unittest.cc
[modify] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/chrome/browser/profiles/profile_impl_io_data.cc
[modify] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler.h
[modify] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/chrome/browser/ui/webui/interventions_internals/interventions_internals_page_handler_unittest.cc
[modify] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/chrome/browser/ui/webui/interventions_internals/interventions_internals_ui.cc
[modify] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/components/previews/content/BUILD.gn
[modify] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/components/previews/content/DEPS
[rename] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/components/previews/content/previews_io_data.cc
[rename] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/components/previews/content/previews_io_data.h
[rename] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/components/previews/content/previews_io_data_unittest.cc
[rename] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/components/previews/content/previews_optimization_guide.h
[rename] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/components/previews/content/previews_ui_service.cc
[rename] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/components/previews/content/previews_ui_service.h
[rename] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/components/previews/content/previews_ui_service_unittest.cc
[modify] https://crrev.com/46eeac4f3137cdb5d8d0e6fb5c74d74ad114be7a/components/previews/core/BUILD.gn

Comment 4 by dougarnett@chromium.org, Nov 20 2017

Status: Fixed (was: Assigned)

Comment 5 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 6 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews

Comment 7 by dougarnett@chromium.org, Jan 11 2018

Blocking: -776847 801275
Labels: -Restrict-View-Google
►

Sign in to add a comment