Add PreviewsEligibilityReason value for not being on cacao whitelist |
||||||||
Issue descriptionIf we choose not to use NoScriptPreview only because it is not whitelisted, we should log that case.
,
Nov 6 2017
,
Nov 6 2017
,
Nov 6 2017
,
Nov 10 2017
Also ensure it gets logged to intervention-internals page
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/58c0f05df06cfe592fea28304cdb68343c120339 commit 58c0f05df06cfe592fea28304cdb68343c120339 Author: Doug Arnett <dougarnett@chromium.org> Date: Thu Nov 16 03:45:55 2017 Adds eligibility reasons for NoScript preview Adds reason for not being whitelisted and also a new Allowed reason for when server optimization hints we not enabled and so not checked. Bug: 780859 , 782860 Change-Id: Idedd812f0331b3e32f271fbac7268b535100227a Reviewed-on: https://chromium-review.googlesource.com/764589 Reviewed-by: Ryan Sturm (OOO until 11/27) <ryansturm@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#516973} [modify] https://crrev.com/58c0f05df06cfe592fea28304cdb68343c120339/components/previews/content/previews_io_data.cc [modify] https://crrev.com/58c0f05df06cfe592fea28304cdb68343c120339/components/previews/content/previews_io_data_unittest.cc [modify] https://crrev.com/58c0f05df06cfe592fea28304cdb68343c120339/components/previews/core/previews_black_list.h [modify] https://crrev.com/58c0f05df06cfe592fea28304cdb68343c120339/components/previews/core/previews_logger.cc [modify] https://crrev.com/58c0f05df06cfe592fea28304cdb68343c120339/components/previews/core/previews_logger_unittest.cc [modify] https://crrev.com/58c0f05df06cfe592fea28304cdb68343c120339/tools/metrics/histograms/enums.xml [modify] https://crrev.com/58c0f05df06cfe592fea28304cdb68343c120339/tools/metrics/histograms/histograms.xml
,
Nov 20 2017
,
Dec 5 2017
,
Dec 5 2017
,
Jan 11 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bengr@chromium.org
, Nov 3 2017