New issue
Advanced search Search tips

Issue 780859 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 781892



Sign in to add a comment

Add PreviewsEligibilityReason value for not being on cacao whitelist

Project Member Reported by dougarnett@chromium.org, Nov 2 2017

Issue description

If we choose not to use NoScriptPreview only because it is not whitelisted, we should log that case.
 

Comment 1 by bengr@chromium.org, Nov 3 2017

Log where?
Blocking: 780298
Blocking: 781892
Blocking: -780298
Also ensure it gets logged to intervention-internals page
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58c0f05df06cfe592fea28304cdb68343c120339

commit 58c0f05df06cfe592fea28304cdb68343c120339
Author: Doug Arnett <dougarnett@chromium.org>
Date: Thu Nov 16 03:45:55 2017

Adds eligibility reasons for NoScript preview

Adds reason for not being whitelisted and also a new Allowed
reason for when server optimization hints we not enabled and
so not checked.

Bug:  780859 ,  782860 
Change-Id: Idedd812f0331b3e32f271fbac7268b535100227a
Reviewed-on: https://chromium-review.googlesource.com/764589
Reviewed-by: Ryan Sturm (OOO until 11/27) <ryansturm@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516973}
[modify] https://crrev.com/58c0f05df06cfe592fea28304cdb68343c120339/components/previews/content/previews_io_data.cc
[modify] https://crrev.com/58c0f05df06cfe592fea28304cdb68343c120339/components/previews/content/previews_io_data_unittest.cc
[modify] https://crrev.com/58c0f05df06cfe592fea28304cdb68343c120339/components/previews/core/previews_black_list.h
[modify] https://crrev.com/58c0f05df06cfe592fea28304cdb68343c120339/components/previews/core/previews_logger.cc
[modify] https://crrev.com/58c0f05df06cfe592fea28304cdb68343c120339/components/previews/core/previews_logger_unittest.cc
[modify] https://crrev.com/58c0f05df06cfe592fea28304cdb68343c120339/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/58c0f05df06cfe592fea28304cdb68343c120339/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)

Comment 8 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 9 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews
Labels: -Restrict-View-Google

Sign in to add a comment