New issue
Advanced search Search tips

Issue 780858 link

Starred by 1 user
Status: Assigned
Owner:
mlamouri@chromium.org
Cc:
liber...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

MSE video should disable the "Copy video address" menu item

Project Member Reported by markdavidscott@google.com, Nov 2 2017 
The right click context menu for a video has an item "Copy video address" that copies the current value of the src attribute to the clipboard.

When using MSE but also using default controls, such as in the example linked from MDN (http://nickdesaulniers.github.io/netfix/demo/bufferAll.html), the copied URL is not useful since it's manufactured with URL.createObjectURL() and thus isn't going to be useful to the user - though it's entirely possible they won't know this and may share the URL anyways.

Comment 1 by dalecur...@chromium.org, Nov 2 2017

Cc: mlamouri@chromium.org
Labels: -Type-Bug Type-Bug-Regression
Hmm, this is supposed to be disabled, if it's not anymore that's a regression.

Comment 2 by dalecur...@chromium.org, Nov 2 2017

Labels: -Type-Bug-Regression Type-Bug
Actually I'm thinking of "Save As": https://cs.chromium.org/chromium/src/third_party/WebKit/public/platform/WebMediaPlayer.h&l=126 which seems to still work as expected, so not a regression.

Comment 4 by yini...@chromium.org, Nov 14 2017

Owner: liber...@chromium.org
Status: Assigned (was: Untriaged)
give to Frank. seems a feature request.

Comment 5 by liber...@chromium.org, Nov 15 2017

Cc: -mlamouri@chromium.org liber...@chromium.org
Owner: mlamouri@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1b6e3731e1c99f38ebbe3a0137e065cd81fa2ab

commit e1b6e3731e1c99f38ebbe3a0137e065cd81fa2ab
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Tue Dec 12 16:15:20 2017

Media: refactor "SupportsSave()" to be implemented by Blink instead of relying on the WebMediaPlayer instance.

The media controls already have a definition for this which is more
detailed than the one that WebMediaPlayer instances use. This will also
allow consistency between the presence of the download button and the
context menu entry for "save video as".

Bug: 780858
Change-Id: I6e439be9cedef9c8862cd1d0d497eac6cb3c800b
Reviewed-on: https://chromium-review.googlesource.com/806654
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523442}
[modify] https://crrev.com/e1b6e3731e1c99f38ebbe3a0137e065cd81fa2ab/content/renderer/media/webmediaplayer_ms.cc
[modify] https://crrev.com/e1b6e3731e1c99f38ebbe3a0137e065cd81fa2ab/content/renderer/media/webmediaplayer_ms.h
[modify] https://crrev.com/e1b6e3731e1c99f38ebbe3a0137e065cd81fa2ab/content/renderer/media_capture_from_element/html_video_element_capturer_source_unittest.cc
[modify] https://crrev.com/e1b6e3731e1c99f38ebbe3a0137e065cd81fa2ab/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/e1b6e3731e1c99f38ebbe3a0137e065cd81fa2ab/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/e1b6e3731e1c99f38ebbe3a0137e065cd81fa2ab/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/e1b6e3731e1c99f38ebbe3a0137e065cd81fa2ab/third_party/WebKit/Source/core/html/media/HTMLMediaElement.cpp
[modify] https://crrev.com/e1b6e3731e1c99f38ebbe3a0137e065cd81fa2ab/third_party/WebKit/Source/core/page/ContextMenuController.h
[add] https://crrev.com/e1b6e3731e1c99f38ebbe3a0137e065cd81fa2ab/third_party/WebKit/Source/core/page/ContextMenuControllerTest.cpp
[modify] https://crrev.com/e1b6e3731e1c99f38ebbe3a0137e065cd81fa2ab/third_party/WebKit/Source/modules/media_controls/elements/MediaControlDownloadButtonElement.cpp
[modify] https://crrev.com/e1b6e3731e1c99f38ebbe3a0137e065cd81fa2ab/third_party/WebKit/Source/platform/testing/EmptyWebMediaPlayer.h
[modify] https://crrev.com/e1b6e3731e1c99f38ebbe3a0137e065cd81fa2ab/third_party/WebKit/public/platform/WebMediaPlayer.h
►

Sign in to add a comment