New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780856 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[Stable Feedback] Loading progress bar freeze even if webpage is finished loading

Project Member Reported by hongchic...@chromium.org, Nov 2 2017

Issue description

Chrome Version: 62.0.3202.66, 62.0.3202.73
OS: Android

What steps will reproduce the problem?

We saw 3 users report this issue in these devices:

SM-J700F
Lenovo A2010-a
Samsung Grand Prime Plus

In-app Feedback
https://listnr.corp.google.com/report/77121974041
https://listnr.corp.google.com/report/79849794751

Play review
https://listnr.corp.google.com/report/80492006050

 
Cc: msrchandra@chromium.org nyerramilli@chromium.org ligim...@chromium.org pnangunoori@chromium.org
Labels: -Type-Bug -Pri-3 -Needs-Bisect hasbisect-per-revision M-64 Needs-triage-Mobile Triaged-Mobile Pri-1 Type-Bug-Regression
Owner: mdjones@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce the issue in Android. Observed the image is not loading.

Steps Followed:
1. Launched Browser
2. Navigated to a website.
3. Observed the progress bar gets struck.

Chrome versions tested:
62.0.3202.84, 64.0.3241.0

OS
Android 6.0.1

Android Devices
Samsung Galaxy S7; SM-G930F Build/MMB29K

Below is the bisect info
=======================

Chrome Good Build -- 62.0.3192.0
Chrome Bad Build  -- 62.0.3193.0

https://chromium.googlesource.com/chromium/src/+log/62.0.3192.0..62.0.3193.0?pretty=fuller&n=10000

Results from pre revision bisect --
You are looking for a change made after 496094(GOOD), but before 496095(BAD).
 
From the above revision range suspecting the following --
https://chromium.googlesource.com/chromium/src/+/b2f9da1122b900f97b281d17a42084ffe15765c2

@mdjones -- Could you please look into the issue, kindly re-assign if this is not related to your changes.

Please navigate to below link for video--
go/chrome-androidlogs/780856

Note: 
1. This issue is not observed in Desktop.
2. Issue is not reproduced on Android OS 7 and later.

Thanks!!
Components: UI
Cc: cma...@chromium.org
Labels: -M-64 ReleaseBlock-Beta M-63
Tagging as RBS for M62 stable. In case of no upcoming stable refresh, we may need to have a fix for M63 (RBB).
pnangunoori@ - the video at http://go/chrome-androidlogs/780856 doesn't seem to be showing the issue. Can you please attach the right video?

I was able to repro this issue on Samsung Galaxy Grand Prime/5.0.2 on few sites like cnet.com and xda-developers.com. Didn't repro on sites like, Google search page, yahoo.com, amazon.com, nytimes.com.


Cc: japhet@chromium.org
Labels: -Pri-1 -ReleaseBlock-Beta -ReleaseBlock-Stable Pri-2
Status: Available (was: Assigned)
+cc japhet for insight about progress bar completion signals from the blink side.

I have seen this occur on sites that appear to be done loading but have not (usually due to ads on the page).

@askatte does this happen 100% of the time and are you able to repro on earlier versions of Chrome? I'm unable to repro on any of my devices.

If we if progress from the web page does not reach 100% or we don't get a 'stop' event from the web page, the progress bar will continue showing. The patch in question only launches a feature that we had been experimenting with large groups for several mile stones.

It is unclear to me why this is considered such high priority given the few cases and the fact that 62 is already stable.

Labels: ReleaseBlock-Stable
I was not able to repro it on other devices that i tried, Samsung J7 (SM-J710MN) / 6.0, Lenovo A6000/ 5.0 and Samsung S7 / 7.0.1.

I have been able to repro the issue consistently only for xda-developers.com. Didn't see the issue for cnet.com the next time. It also reproed with engadget.com a couple times but not 100% of times.

I was not able to repro the issue in M61 - 61.0.3163.98.

Also, note that the progress bar then stuck progress bar disappears once we try to drag the omnibox to either side.

Since its a regression and not too old, adding back M63 RBS.
Cc: danielpark@chromium.org tedc...@chromium.org kgna...@chromium.org
Issue can be reproducible on the mentioned device with below steps:  

Application Version :62.0.3202.73
Android Build Number : LMY48B
Device: Samsung Galaxy Grand Prime 4G(SM-G531F) 


Steps to reproduce:.
1.launch chrome
2.Open new tab 
3.launch https://www.xda-developers.com/ and wait for the page to load fully 

Observed results:
Progress bar freeze after loading

Expected results:
Progress bar should disappear after loading  

Number of times you were able to reproduce: 5/5

Note: 
Good build: 62.0.3202.44
Bad build : 62.0.3202.45

Bisect Range: https://chromium.googlesource.com/chromium/src/+log/62.0.3202.44..62.0.3202.45?pretty=fuller&n=10000

Not able to bisect since it shows all commit positions are same.

Also there are no enough CL's went for change here.
Suspecting this CL: https://chromium.googlesource.com/chromium/src/+/62acd607eeb44ca7b4ff49e89bb3123947c6c45d


Please find logs and Video @ http://go/chrome-androidlogs1/7/780856

The suspected CL only adds an option back to the context menu and has no relation to status bars.
Status: Assigned (was: Available)
Since it seems we now have a repro, I'll grab a device and take a look.
Any update here mdjones@?
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0234f4bde0871f66ca3c0964eb996daf8e5aea00

commit 0234f4bde0871f66ca3c0964eb996daf8e5aea00
Author: Matthew Jones <mdjones@chromium.org>
Date: Mon Nov 13 21:20:36 2017

Prevent progress bar from freezing

In cases where the indeterminate animation was running and stopped,
if progress jumped to 100%, the progress bar would remain on-screen.
In most cases, if the progress bar reaches 100%, the progress bar is
hidden immediately. If the animation is running, the user should be
able to see progress reach 100% before it disappears. The discrepancy
was in this logic. This change ensures that the progress bar restarts
animation on update and blocks finish until the animation is complete.

BUG= 780856 

Change-Id: Ife33e5d69824cb48b03a38312f817a31963b848a
Reviewed-on: https://chromium-review.googlesource.com/766848
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516052}
[modify] https://crrev.com/0234f4bde0871f66ca3c0964eb996daf8e5aea00/chrome/android/java/src/org/chromium/chrome/browser/widget/ToolbarProgressBar.java

Comment 13 Deleted

Test: 

1.launch chrome
2.Open new tab 
3.launch https://www.xda-developers.com/ and wait for the page to load fully 

Expected Behavior: Progress bar disappears after loading  

Works as per expected behavior, verified on 64.0.3269.0
Labels: -ReleaseBlock-Stable
Status: Fixed (was: Assigned)
I honestly don't think this is critical enough to merge back to M-63 this late in the game (especially if it is already seen in M-62). If anyone feels differently, re-add the label; otherwise I'm marking this as fixed.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-62; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-62 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD

Sign in to add a comment