vboot: Add GBB flag(s) to ignore EC SW sync, yet still sysjump |
||
Issue descriptionGBB_FLAG_DISABLE_EC_SOFTWARE_SYNC / GBB_FLAG_DISABLE_PD_SOFTWARE_SYNC disables SW sync and skips sysjump (so EC will remain in RO). EC devs often want to skip SW sync (so their newly-flashed RW remains intact) yet not skip sysjump (so shipping boot flow remains in effect, to debug a certain class of issues). I have often hacked up local vboot source to achieve this, others are hacking up EC FW to achieve this (eg. https://chromium-review.googlesource.com/#/c/chromiumos/platform/ec/+/750536/), it would be nice to just add a GBB flag (or modify existing GBB flags) to make it happen. How about we modify GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC / GBB_FLAG_DISABLE_PD_SOFTWARE_SYNC to only disable SW sync, then add a new flag like GBB_FLAG_DISABLE_EC_SYSJUMP (covers both EC + PD, probably not worth adding a second flag just for PD)? - If none of these flags are defined then bootflow is normal. - If GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC is defined but not GBB_FLAG_DISABLE_EC_SYSJUMP then we will blindly request EC sysjump to RW without SW sync. - If GBB_FLAG_DISABLE_EC_SYSJUMP is defined but not GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC then SW sync will still happen but we won't request sysjump. - If both are defined then both SW sync and sysjump will be skipped (equivalent to the current implementation of GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC).
,
Nov 2 2017
We could add a new flag to force enable sysjump, that way the original flags don't have to change behavior. But it is a bit convoluted...
,
Aug 1
|
||
►
Sign in to add a comment |
||
Comment 1 by rspangler@chromium.org
, Nov 2 2017