CfM USB devices have unique product ids (pids) and vendor ids (vids). We use those in various tests. To reduce code duplication, we should create constants for the various USB devices that can be re-used in all tests.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/428fc1d88d398a5e3e4483bce1e1bc876607a4b5 commit 428fc1d88d398a5e3e4483bce1e1bc876607a4b5 Author: Claes Malmnas <malmnas@google.com> Date: Mon Nov 06 08:53:12 2017 Add constants for CfM USB devices. These constants can be used by all CfM client tests. They are introduced to reduce code duplication and to make sure that we have good representation for USB devices in our tests. BUG= chromium:780840 TEST=locally Change-Id: I6c61c1736c09d25f368da194a36a427cff90012d Reviewed-on: https://chromium-review.googlesource.com/751264 Reviewed-by: Denis Tosic <dtosic@chromium.org> Commit-Queue: Claes Malmnäs <malmnas@google.com> Tested-by: Claes Malmnäs <malmnas@google.com> Trybot-Ready: Claes Malmnäs <malmnas@google.com> [add] https://crrev.com/428fc1d88d398a5e3e4483bce1e1bc876607a4b5/client/common_lib/cros/cfm/__init__.py [add] https://crrev.com/428fc1d88d398a5e3e4483bce1e1bc876607a4b5/client/common_lib/cros/cfm/cfm_usb_devices.py [add] https://crrev.com/428fc1d88d398a5e3e4483bce1e1bc876607a4b5/client/common_lib/cros/cfm/usb_device_unittest.py [add] https://crrev.com/428fc1d88d398a5e3e4483bce1e1bc876607a4b5/client/common_lib/cros/cfm/usb_device.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/60d175b792cdc11dc9393699d11ebafd53512e76 commit 60d175b792cdc11dc9393699d11ebafd53512e76 Author: Claes Malmnas <malmnas@google.com> Date: Mon Nov 06 10:25:58 2017 Address comments from kerl@. Context: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/751264/3 BUG= chromium:780840 TEST=locally Change-Id: I9444eb69ea2e204244e87b9ae945d45a4418febb Reviewed-on: https://chromium-review.googlesource.com/754813 Reviewed-by: Kristoffer Erlandsson <kerl@google.com> Commit-Queue: Claes Malmnäs <malmnas@google.com> Tested-by: Claes Malmnäs <malmnas@google.com> [modify] https://crrev.com/60d175b792cdc11dc9393699d11ebafd53512e76/client/common_lib/cros/cfm/usb_device.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/aaebbd1dcc72ceb2c5d0af5cdc2ed4f8efadd0ed commit aaebbd1dcc72ceb2c5d0af5cdc2ed4f8efadd0ed Author: Claes Malmnas <malmnas@google.com> Date: Tue Nov 07 17:25:58 2017 Update get_usb_devices to use CfM USB device constants. Fixed some indentation inconsistencies at the same time. BUG= chromium:780840 TEST=locally Change-Id: I2cc7becb4b036aa3d6164e45c3e2cf6997746679 Reviewed-on: https://chromium-review.googlesource.com/753372 Commit-Ready: Claes Malmnäs <malmnas@google.com> Tested-by: Denis Tosic <dtosic@chromium.org> Reviewed-by: Denis Tosic <dtosic@chromium.org> [modify] https://crrev.com/aaebbd1dcc72ceb2c5d0af5cdc2ed4f8efadd0ed/client/common_lib/cros/get_usb_devices.py [modify] https://crrev.com/aaebbd1dcc72ceb2c5d0af5cdc2ed4f8efadd0ed/client/common_lib/cros/get_usb_devices_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/fa4a021ecd5a10f8dadb0fc5685b2325bfb13d53 commit fa4a021ecd5a10f8dadb0fc5685b2325bfb13d53 Author: Claes Malmnas <malmnas@google.com> Date: Thu Nov 09 12:58:40 2017 Add utility methods for receiving CfM cameras and speakers. BUG= chromium:780840 TEST=locally Change-Id: Ib331e990186bf5cc702d70f52ca33d337958d47c Reviewed-on: https://chromium-review.googlesource.com/756836 Reviewed-by: Denis Tosic <dtosic@chromium.org> Reviewed-by: Claes Malmnäs <malmnas@google.com> Commit-Queue: Claes Malmnäs <malmnas@google.com> Tested-by: Claes Malmnäs <malmnas@google.com> Trybot-Ready: Claes Malmnäs <malmnas@google.com> [modify] https://crrev.com/fa4a021ecd5a10f8dadb0fc5685b2325bfb13d53/client/common_lib/cros/cfm/cfm_usb_devices.py [add] https://crrev.com/fa4a021ecd5a10f8dadb0fc5685b2325bfb13d53/client/common_lib/cros/cfm/cfm_usb_devices_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/fdc9ee7d1248f3eba20a370e8be926c8a00da9d8 commit fdc9ee7d1248f3eba20a370e8be926c8a00da9d8 Author: Claes Malmnas <malmnas@google.com> Date: Fri Nov 10 09:01:21 2017 Re-use methods and constants from cfm_usb_devices to avoid code duplication. BUG= chromium:780840 TEST=locally Change-Id: I2f0099696e54843d6727e8d8650c506cacc50f71 Reviewed-on: https://chromium-review.googlesource.com/758847 Reviewed-by: Denis Tosic <dtosic@chromium.org> Reviewed-by: Kristoffer Erlandsson <kerl@google.com> Reviewed-by: Claes Malmnäs <malmnas@google.com> Commit-Queue: Claes Malmnäs <malmnas@google.com> Tested-by: Claes Malmnäs <malmnas@google.com> [modify] https://crrev.com/fdc9ee7d1248f3eba20a370e8be926c8a00da9d8/client/common_lib/cros/get_usb_devices.py [modify] https://crrev.com/fdc9ee7d1248f3eba20a370e8be926c8a00da9d8/client/common_lib/cros/get_usb_devices_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/74e108cd4bbbb53ceb97aaf5388934b9b6af0f07 commit 74e108cd4bbbb53ceb97aaf5388934b9b6af0f07 Author: Claes Malmnas <malmnas@google.com> Date: Mon Nov 13 10:48:42 2017 Update get_usb_device to only use constants defined in cfm_usb_devices. BUG= chromium:780840 TEST=unit tests Change-Id: I6fdc07786d3da544d27c633977962664ef250b36 Reviewed-on: https://chromium-review.googlesource.com/763452 Reviewed-by: Denis Tosic <dtosic@chromium.org> Reviewed-by: Claes Malmnäs <malmnas@google.com> Commit-Queue: Claes Malmnäs <malmnas@google.com> Tested-by: Claes Malmnäs <malmnas@google.com> Trybot-Ready: Claes Malmnäs <malmnas@google.com> [modify] https://crrev.com/74e108cd4bbbb53ceb97aaf5388934b9b6af0f07/client/common_lib/cros/get_usb_devices.py [modify] https://crrev.com/74e108cd4bbbb53ceb97aaf5388934b9b6af0f07/client/common_lib/cros/cfm/cfm_usb_devices.py [modify] https://crrev.com/74e108cd4bbbb53ceb97aaf5388934b9b6af0f07/client/common_lib/cros/cfm/usb_device_unittest.py [modify] https://crrev.com/74e108cd4bbbb53ceb97aaf5388934b9b6af0f07/client/common_lib/cros/cfm/cfm_usb_devices_unittest.py [modify] https://crrev.com/74e108cd4bbbb53ceb97aaf5388934b9b6af0f07/client/common_lib/cros/cfm/usb_device.py
Comment 1 by bugdroid1@chromium.org
, Nov 6 2017