New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780832 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

app_group::main_app::ProcessPendingLogs crash on iOS11

Project Member Reported by olivierrobin@chromium.org, Nov 2 2017

Issue description

	0x0000000185c4c1a0	(libobjc.A.dylib + 0x000241a0 )	objc_retain
0x0000000186763994	(CoreFoundation + 0x00189994 )	+[__NSArrayI __new::::]
0x00000001865e8950	(CoreFoundation + 0x0000e950 )	-[NSArray initWithArray:range:copyItems:]
0x00000001902ef690	(UIKit + 0x007d3690 )	+[_UICanvas canvases]
0x0000000190789eb0	(UIKit + 0x00c6deb0 )	+[_UIApplicationCanvas canvases]
0x0000000190789fc4	(UIKit + 0x00c6dfc4 )	+[_UIApplicationCanvas mostActiveCanvas]
0x000000018fb2f3c0	(UIKit + 0x000133c0 )	-[UIApplication isSuspended]
0x000000018fc349ac	(UIKit + 0x001189ac )	UpdateSystemSoundActiveStatus
0x000000018fc462fc	(UIKit + 0x0012a2fc )	-[UIDevice _updateSystemSoundActiveStatus:]
0x00000001866ae128	(CoreFoundation + 0x000d4128 )	__CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__
0x00000001866ad6c8	(CoreFoundation + 0x000d36c8 )	_CFXRegistrationPost
0x00000001866ad42c	(CoreFoundation + 0x000d342c )	___CFXNotificationPost_block_invoke
0x000000018672a9f0	(CoreFoundation + 0x001509f0 )	-[_CFXNotificationRegistrar find:object:observer:enumerator:]
0x00000001865e43dc	(CoreFoundation + 0x0000a3dc )	_CFXNotificationPost
0x0000000187004494	(Foundation + 0x00006494 )	-[NSNotificationCenter postNotificationName:object:userInfo:]
0x00000001046191dc	(Chrome -app_group_metrics_mainapp.mm:34 )	app_group::main_app::ProcessPendingLogs(void (NSData*) block_pointer)
0x0000000104c29cec	(Chrome -callback.h:64 )	base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*)
0x0000000104c6ae64	(Chrome -task_tracker.cc:335 )	base::internal::TaskTracker::PerformRunTask(std::__1::unique_ptr<base::internal::Task, std::__1::default_delete<base::internal::Task> >, base::internal::Sequence*)
0x0000000104c6b314	(Chrome -task_tracker_posix.cc:22 )	base::internal::TaskTrackerPosix::PerformRunTask(std::__1::unique_ptr<base::internal::Task, std::__1::default_delete<base::internal::Task> >, base::internal::Sequence*)
0x0000000104c6aaf0	(Chrome -task_tracker.cc:251 )	base::internal::TaskTracker::RunNextTask(base::internal::Sequence*)
0x0000000104c66ec0	(Chrome -scheduler_worker.cc:73 )	base::internal::SchedulerWorker::Thread::ThreadMain()
0x0000000104c73f1c	(Chrome -platform_thread_posix.cc:75 )	base::(anonymous namespace)::ThreadFunc(void*)
0x0000000186348328	(libsystem_pthread.dylib + 0x00002328 )	_pthread_body
0x00000001863481f4	(libsystem_pthread.dylib + 0x000021f4 )	_pthread_start



https://bugs.chromium.org/p/chromium/issues/detail?id=477700

 

Comment 1 by cmasso@google.com, Nov 7 2017

olivierrobin@, Are you looking into this crash ?
Yes. I will have a CL.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f705f8d0d16301158f3d782b382520969ce6048

commit 6f705f8d0d16301158f3d782b382520969ce6048
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Thu Nov 09 13:31:12 2017

Synchronously send widget metrics.

Posting task may cause crash if application has no longer access to
shared sandbox on execution (suspended).

Bug:  780832 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If5998414728ef4d8d3c61da3f9f6d5e705744b33
Reviewed-on: https://chromium-review.googlesource.com/758397
Reviewed-by: Elodie Banel <lod@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515157}
[modify] https://crrev.com/6f705f8d0d16301158f3d782b382520969ce6048/ios/chrome/app/application_delegate/metrics_mediator.mm
[modify] https://crrev.com/6f705f8d0d16301158f3d782b382520969ce6048/ios/chrome/common/app_group/app_group_metrics_client.h
[modify] https://crrev.com/6f705f8d0d16301158f3d782b382520969ce6048/ios/chrome/common/app_group/app_group_metrics_mainapp.h
[modify] https://crrev.com/6f705f8d0d16301158f3d782b382520969ce6048/ios/chrome/common/app_group/app_group_metrics_mainapp.mm

Labels: Merge-Request-63
Status: Fixed (was: Assigned)
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 9 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: Less than 22 days to go before AppStore submit on M63
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-63 Merge-Approved-63
Please verify the fix after merging it to M63 branch 3239. 
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 13 2017

Cc: cma...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by sheriffbot@chromium.org, Nov 17 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Issue 789271 has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 29 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1857ea9c765ba565b36a87726632b28ed73a9bf

commit b1857ea9c765ba565b36a87726632b28ed73a9bf
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Wed Nov 29 08:48:45 2017

Synchronously send widget metrics.

Posting task may cause crash if application has no longer access to
shared sandbox on execution (suspended).

TBR=olivierrobin@chromium.org

(cherry picked from commit 6f705f8d0d16301158f3d782b382520969ce6048)

Bug:  780832 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If5998414728ef4d8d3c61da3f9f6d5e705744b33
Reviewed-on: https://chromium-review.googlesource.com/758397
Reviewed-by: Elodie Banel <lod@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#515157}
Reviewed-on: https://chromium-review.googlesource.com/795723
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#600}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/b1857ea9c765ba565b36a87726632b28ed73a9bf/ios/chrome/app/application_delegate/metrics_mediator.mm
[modify] https://crrev.com/b1857ea9c765ba565b36a87726632b28ed73a9bf/ios/chrome/common/app_group/app_group_metrics_client.h
[modify] https://crrev.com/b1857ea9c765ba565b36a87726632b28ed73a9bf/ios/chrome/common/app_group/app_group_metrics_mainapp.h
[modify] https://crrev.com/b1857ea9c765ba565b36a87726632b28ed73a9bf/ios/chrome/common/app_group/app_group_metrics_mainapp.mm

Sign in to add a comment