Issue metadata
Sign in to add a comment
|
ios_chrome_integration_egtests (iPhone 6s iOS 11.0) failing on chromium.fyi/EarlGreyiOS |
||||||||||||||||||||||||
Issue descriptionios_chrome_integration_egtests (iPhone 6s iOS 11.0) failing on chromium.fyi/EarlGreyiOS Builders failed on: - EarlGreyiOS: https://build.chromium.org/p/chromium.fyi/builders/EarlGreyiOS The tests have been consistently failing with the following DCHECK on the bots: Thread 0 Crashed:: CrWebMain Dispatch queue: com.apple.main-thread 0 org.chromium.gtest.generic-unit-test 0x000000010f02b304 base::debug::BreakDebugger() + 20 1 org.chromium.gtest.generic-unit-test 0x000000010f08c720 logging::LogMessage::~LogMessage() + 4960 2 org.chromium.gtest.generic-unit-test 0x000000010f0890f5 logging::LogMessage::~LogMessage() + 21 3 org.chromium.gtest.generic-unit-test 0x000000010ec128ad -[BrowserViewController controllerForURL:webState:] + 317 4 org.chromium.gtest.generic-unit-test 0x000000010dfae945 __46-[CRWWebController loadCurrentURLInNativeView]_block_invoke + 277 5 org.chromium.gtest.generic-unit-test 0x000000010df811b5 -[CRWPlaceholderNavigationInfo runCompletionHandler] + 37 6 org.chromium.gtest.generic-unit-test 0x000000010dfd5faa -[CRWWebController webView:didFinishNavigation:] + 410 7 com.apple.WebKit 0x000000011e041609 WebKit::NavigationState::NavigationClient::didFinishNavigation(WebKit::WebPageProxy&, API::Navigation*, API::Object*) + 91 8 com.apple.WebKit 0x000000011e1a1add WebKit::WebPageProxy::didFinishLoadForFrame(unsigned long long, unsigned long long, WebKit::UserData const&) + 311 9 com.apple.WebKit 0x000000011e1be125 void IPC::handleMessage<Messages::WebPageProxy::DidFinishLoadForFrame, WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(unsigned long long, unsigned long long, WebKit::UserData const&)>(IPC::Decoder&, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(unsigned long long, unsigned long long, WebKit::UserData const&)) + 100 10 com.apple.WebKit 0x000000011e03dfcf IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) + 127 11 com.apple.WebKit 0x000000011e21012a WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 24 12 com.apple.WebKit 0x000000011e000c47 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) + 119 13 com.apple.WebKit 0x000000011e0034ba IPC::Connection::dispatchOneMessage() + 176 14 com.apple.JavaScriptCore 0x00000001278fa34d WTF::RunLoop::performWork() + 333 15 com.apple.JavaScriptCore 0x00000001278fa562 WTF::RunLoop::performWork(void*) + 34 16 com.apple.CoreFoundation 0x000000011b36d2b1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17 17 com.apple.CoreFoundation 0x000000011b40cd31 __CFRunLoopDoSource0 + 81 18 com.apple.CoreFoundation 0x000000011b351c19 __CFRunLoopDoSources0 + 185 19 com.apple.CoreFoundation 0x000000011b3511ff __CFRunLoopRun + 1279 20 com.apple.CoreFoundation 0x000000011b350a89 CFRunLoopRunSpecific + 409 21 org.chromium.test.EarlGrey 0x000000011d2408be -[GREYRunLoopSpinner grey_drainRunLoopInActiveModeAndCheckCondition:forTime:] + 590 22 org.chromium.test.EarlGrey 0x000000011d2402e5 -[GREYRunLoopSpinner spinWithStopConditionBlock:] + 565 23 org.chromium.test.EarlGrey 0x000000011d243a0d -[GREYUIThreadExecutor executeSyncWithTimeout:block:error:] + 973 24 org.chromium.gtest.generic-unit-test 0x000000010ef95a85 +[ChromeEarlGrey waitForPageToFinishLoading] + 645 25 org.chromium.gtest.generic-unit-test 0x000000010ef95613 +[ChromeEarlGrey loadURL:] + 51 26 org.chromium.gtest.generic-unit-test 0x000000010efda946 -[CookiesTestCase testSwitchToIncognito] + 5046 27 com.apple.CoreFoundation 0x000000011b34e56c __invoking___ + 140 28 com.apple.CoreFoundation 0x000000011b34e440 -[NSInvocation invoke] + 320 29 org.chromium.test.EarlGrey 0x000000011d20e818 -[GREYTestCaseInvocation invoke] + 104 30 com.apple.dt.XCTest 0x000000011c78b949 __24-[XCTestCase invokeTest]_block_invoke + 591 31 com.apple.dt.XCTest 0x000000011c7d3f45 -[XCUITestContext performInScope:] + 183 32 com.apple.dt.XCTest 0x000000011c78b6ef -[XCTestCase invokeTest] + 141 33 org.chromium.test.EarlGrey 0x000000011d1ffbf4 -[XCTestCase(GREYAdditions) grey_invokeTest] + 1012 34 com.apple.dt.XCTest 0x000000011c78c6b0 __26-[XCTestCase performTest:]_block_invoke.369 + 42 35 com.apple.dt.XCTest 0x000000011c7d8c4b +[XCTContext runInContextForTestCase:block:] + 163 36 com.apple.dt.XCTest 0x000000011c78c04c -[XCTestCase performTest:] + 608 37 com.apple.dt.XCTest 0x000000011c788052 __27-[XCTestSuite performTest:]_block_invoke + 363 38 com.apple.dt.XCTest 0x000000011c7879b9 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 26 39 com.apple.dt.XCTest 0x000000011c787bb6 -[XCTestSuite performTest:] + 239 40 com.apple.dt.XCTest 0x000000011c788052 __27-[XCTestSuite performTest:]_block_invoke + 363 41 com.apple.dt.XCTest 0x000000011c7879b9 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 26 42 com.apple.dt.XCTest 0x000000011c787bb6 -[XCTestSuite performTest:] + 239 43 com.apple.dt.XCTest 0x000000011c788052 __27-[XCTestSuite performTest:]_block_invoke + 363 44 com.apple.dt.XCTest 0x000000011c7879b9 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 26 45 com.apple.dt.XCTest 0x000000011c787bb6 -[XCTestSuite performTest:] + 239 46 com.apple.dt.XCTest 0x000000011c7e016d __44-[XCTTestRunSession runTestsAndReturnError:]_block_invoke + 40 47 com.apple.dt.XCTest 0x000000011c79b232 -[XCTestObservationCenter _observeTestExecutionForBlock:] + 475 48 com.apple.dt.XCTest 0x000000011c7e000c -[XCTTestRunSession runTestsAndReturnError:] + 281 49 com.apple.dt.XCTest 0x000000011c7776ab -[XCTestDriver runTestsAndReturnError:] + 314 50 com.apple.dt.XCTest 0x000000011c7d7eb6 _XCTestMain + 619 51 com.apple.CoreFoundation 0x000000011b36d20c __CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK__ + 12 52 com.apple.CoreFoundation 0x000000011b351a3b __CFRunLoopDoBlocks + 203 53 com.apple.CoreFoundation 0x000000011b351214 __CFRunLoopRun + 1300 54 com.apple.CoreFoundation 0x000000011b350a89 CFRunLoopRunSpecific + 409 55 com.apple.GraphicsServices 0x00000001208109c6 GSEventRunModal + 62 56 com.apple.UIKit 0x000000011918ed30 UIApplicationMain + 159 57 org.chromium.gtest.generic-unit-test 0x000000010dc50c83 (anonymous namespace)::RunUIApplicationMain(int, char**) + 371 58 org.chromium.gtest.generic-unit-test 0x000000010dc50763 main + 419 59 libdyld.dylib 0x00000001227b5d81 start + 1
,
Nov 2 2017
The only CL that affects ios/ in the affected range from Sheriff-O-Matic is https://chromium-review.googlesource.com/c/chromium/src/+/740676, going to revert it pre-emptively.
,
Nov 2 2017
Assigning to kkhorimoto (as creator of the reverted CL) for further investigation.
,
Nov 2 2017
+danyao (cc) as https://chromium-review.googlesource.com/c/chromium/src/+/742187 may also be causing those errors.
,
Nov 2 2017
The reverted CL was just a rename of a class, so I don't think it's very likely that it would affect a URL's scheme to cause the DCHECK. I'll investigate before relanding, though.
,
Nov 2 2017
Another CL was reverted that is more likely to have caused the issue: https://chromium-review.googlesource.com/c/chromium/src/+/751361. Assigning to danyao. Sorry for reverting your CL kkhorimoto.
,
Nov 2 2017
,
Nov 2 2017
Yes this is a known failure in the new navigation manager. The CL reverted in #6 enables the new navigation manager on the FYI bot. My intention for this test is to catch bugs in new navigation manager earlier. When chatting with Mike and Menglu last week, I get the impression that some failures on FYI bot is acceptable... Sorry for not communicating the change well and causing the churn. It seems that since Sherrifs monitor FYI job, and it's not easy to tell which test case failed, perhaps I should not enable them on FYI until all known issues are fixed.
,
Nov 2 2017
Sorry about the confusion Danyao! Previously we don't have EarlGrey tests on main waterfall upstream, and they are only running on fyi.EarlGreyiOS. That's the reason iOS sheriffs are monitoring FYI. Now EG tests are moving to main waterfall chromium.mac/ios-simulator-full-configs, but still in the transition period. We still have some valuable test coverage on FYI, so the sheriff process has not fully abandoned FYI yet. I'll remove the useful test coverage on FYI later today and make the bot a real FYI one. Then sheriffs can take eyes off it : ). I'll bring your change back online after that.
,
Nov 2 2017
,
Nov 2 2017
That sounds good. Thanks Menglu!
,
Nov 3 2017
As Sheriff, I'm using Sheriff-O-Matic. Anything that is red on Sheriff-O-Matic is investigated, even if it is FYI.
,
Nov 7 2017
FYI tests have been moved to main waterfall. Gatekeepers and sheriff-o-matic have been updated as well. I'll start to put the experiment tests on FYI bots.
,
Nov 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8cf249895a6631fd5203f4e2d3dc487e68ec6346 commit 8cf249895a6631fd5203f4e2d3dc487e68ec6346 Author: Menglu Huang <huangml@chromium.org> Date: Thu Nov 09 00:19:31 2017 Add FYI tests with new navigation manager enabled. Bug: 780828 ,734150 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4c4bf7965c6420e3c3213982361296fe7861d61e Reviewed-on: https://chromium-review.googlesource.com/756885 Reviewed-by: Mike Baxley <baxley@chromium.org> Commit-Queue: Menglu Huang <huangml@chromium.org> Cr-Commit-Position: refs/heads/master@{#515029} [modify] https://crrev.com/8cf249895a6631fd5203f4e2d3dc487e68ec6346/ios/build/bots/chromium.fyi/EarlGreyiOS.json [modify] https://crrev.com/8cf249895a6631fd5203f4e2d3dc487e68ec6346/ios/build/bots/chromium.fyi/ios-simulator.json
,
Nov 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0f62408fd250c7a99892104d431712eb9adab11 commit f0f62408fd250c7a99892104d431712eb9adab11 Author: Sergio Collazos <sczs@chromium.org> Date: Thu Nov 09 04:41:46 2017 Revert "Add FYI tests with new navigation manager enabled." This reverts commit 8cf249895a6631fd5203f4e2d3dc487e68ec6346. Reason for revert: Enabling these flags on bots causes this test to fail https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.fyi%2FEarlGreyiOS%2F33304%2F%2B%2Frecipes%2Fsteps%2Fios_chrome_integration_egtests__iPhone_6s_iOS_11.0___2_%2F0%2Fstdout Original change's description: > Add FYI tests with new navigation manager enabled. > > Bug: 780828 ,734150 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I4c4bf7965c6420e3c3213982361296fe7861d61e > Reviewed-on: https://chromium-review.googlesource.com/756885 > Reviewed-by: Mike Baxley <baxley@chromium.org> > Commit-Queue: Menglu Huang <huangml@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515029} TBR=baxley@chromium.org,huangml@chromium.org,danyao@chromium.org Change-Id: I70250679380f7eb6ddd2c04130b11264a50ca8ef No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 780828 , 734150 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/759837 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#515100} [modify] https://crrev.com/f0f62408fd250c7a99892104d431712eb9adab11/ios/build/bots/chromium.fyi/EarlGreyiOS.json [modify] https://crrev.com/f0f62408fd250c7a99892104d431712eb9adab11/ios/build/bots/chromium.fyi/ios-simulator.json
,
Nov 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3cd4b986ad6efe64fed8aa1dbf783db0de731909 commit 3cd4b986ad6efe64fed8aa1dbf783db0de731909 Author: Mike Baxley <baxley@chromium.org> Date: Thu Nov 09 15:26:43 2017 Reland "Add FYI tests with new navigation manager enabled."" This reverts commit f0f62408fd250c7a99892104d431712eb9adab11. Reason for revert: Failing tests were on FYI. Tests to monitor have been moved to main - PSA, updated docs, and updated Sheriff-o-matic instructions are coming (or have recently come). Thanks for being a diligent sheriff! Original change's description: > Revert "Add FYI tests with new navigation manager enabled." > > This reverts commit 8cf249895a6631fd5203f4e2d3dc487e68ec6346. > > Reason for revert: Enabling these flags on bots causes this test to fail > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.fyi%2FEarlGreyiOS%2F33304%2F%2B%2Frecipes%2Fsteps%2Fios_chrome_integration_egtests__iPhone_6s_iOS_11.0___2_%2F0%2Fstdout > > > Original change's description: > > Add FYI tests with new navigation manager enabled. > > > > Bug: 780828 ,734150 > > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet > > Change-Id: I4c4bf7965c6420e3c3213982361296fe7861d61e > > Reviewed-on: https://chromium-review.googlesource.com/756885 > > Reviewed-by: Mike Baxley <baxley@chromium.org> > > Commit-Queue: Menglu Huang <huangml@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#515029} > > TBR=baxley@chromium.org,huangml@chromium.org,danyao@chromium.org > > Change-Id: I70250679380f7eb6ddd2c04130b11264a50ca8ef > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 780828 , 734150 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet > Reviewed-on: https://chromium-review.googlesource.com/759837 > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Commit-Queue: Sergio Collazos <sczs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515100} TBR=baxley@chromium.org,sczs@chromium.org,huangml@chromium.org,danyao@chromium.org Change-Id: Ica3877ce1a91d878a5bd4acc875f2bcfbdb44aa2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 780828 , 734150 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/760616 Reviewed-by: Mike Baxley <baxley@chromium.org> Commit-Queue: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#515173} [modify] https://crrev.com/3cd4b986ad6efe64fed8aa1dbf783db0de731909/ios/build/bots/chromium.fyi/EarlGreyiOS.json [modify] https://crrev.com/3cd4b986ad6efe64fed8aa1dbf783db0de731909/ios/build/bots/chromium.fyi/ios-simulator.json
,
Nov 14 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by sdefresne@chromium.org
, Nov 2 2017