New issue
Advanced search Search tips

Issue 780825 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Blocking:
issue 753806



Sign in to add a comment

[Password Manager] Align username and password field in a save prompt (Mac)

Project Member Reported by kolos@chromium.org, Nov 2 2017

Issue description

Align username and password field in a save prompt. See attachment 
 
Screen Shot 2017-10-26 at 1.16.05 PM.png
165 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1df038df6e19e70fd11342f9d5a4d9efbea098fc

commit 1df038df6e19e70fd11342f9d5a4d9efbea098fc
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri Nov 03 09:03:14 2017

Align elements in the save password dialog.

The username field is now align with the pop-up button for the password.
The save button is right-aligned with the username field.

Bug:  774505 , 780825 
Change-Id: Iae200387cb25ddbc5a4b9b3d17dfb093b9bf5cfb
Reviewed-on: https://chromium-review.googlesource.com/751742
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513727}
[modify] https://crrev.com/1df038df6e19e70fd11342f9d5a4d9efbea098fc/chrome/browser/ui/cocoa/passwords/pending_password_view_controller.mm
[modify] https://crrev.com/1df038df6e19e70fd11342f9d5a4d9efbea098fc/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

Cc: kkaluri@chromium.org
Labels: Needs-Feedback
Tested this issue on Mac 10.12.6 with chrome #64.0.3260.0 and observed there is no square box displayed around password field because of this i was unable to verify the alignment of username and password field

Attaching the screen-cast for reference.

vasilii@ Could you please look into it and let us know your observations.
780825.png
101 KB View Download
Labels: -Needs-Feedback
There is no square box because there was just one password detected. Thus, it's not editable. If you'd like to see the pop-up button then you should load a form with multiple password fields (e.g. a password change form), type different values into them and open the bubble via the icon.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 6 2017

Labels: merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0aae0ed5a278741bbb0385893938114bff40ee8

commit d0aae0ed5a278741bbb0385893938114bff40ee8
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Mon Nov 06 17:15:04 2017

Align elements in the save password dialog.

The username field is now align with the pop-up button for the password.
The save button is right-aligned with the username field.

TBR=vasilii@chromium.org

(cherry picked from commit 1df038df6e19e70fd11342f9d5a4d9efbea098fc)

Bug:  774505 , 780825 
Change-Id: Iae200387cb25ddbc5a4b9b3d17dfb093b9bf5cfb
Reviewed-on: https://chromium-review.googlesource.com/751742
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#513727}
Reviewed-on: https://chromium-review.googlesource.com/754934
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#386}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/d0aae0ed5a278741bbb0385893938114bff40ee8/chrome/browser/ui/cocoa/passwords/pending_password_view_controller.mm
[modify] https://crrev.com/d0aae0ed5a278741bbb0385893938114bff40ee8/chrome/browser/ui/cocoa/passwords/save_pending_password_view_controller.mm

Status: Fixed (was: Assigned)
Labels: TE-Verified-M64 TE-Verified-M63 TE-Verified-64.0.3260.0 TE-Verified-63.0.3239.39
Verified this issue on mac 10.12.6 with chrome #63.0.3239.39, #64.0.3260.0 and observed that fix is working as expected. Hence adding TE-Verified labels.

Attaching the screencast for reference. 
780825.png
101 KB View Download

Sign in to add a comment