ManualTextFramerTest.OriginRTLTest is flaky |
|||||
Issue descriptionios_chrome_unittests (iPhone 5s iOS 9.3.2) on iOS-9.3.2 failing on internal.bling.main/iphone9-device-x64 Builders failed on: - iphone9-device-x64: http://master7.golo.chromium.org/i/internal.bling.main/builders/iphone9-device-x64 Failure are from ManualTextFramerTest.OriginRTLTest. Marking the test as FLAKY, assigning to kkhorimoto as OWNERS of ios/chrome/browser/ui/util for investigation.
,
Nov 2 2017
,
Nov 30 2017
Reenabling this test because it only fails on a deprecated bot configuration. crrev.com/c/802082
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd12859a9c856c6919cedf6c35d13b8b22af94e1 commit dd12859a9c856c6919cedf6c35d13b8b22af94e1 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Thu Nov 30 23:32:42 2017 [iOS] Reenable ManualTextFramerTest.OriginRTLTest. This was only flaky on iOS9 devices, but iOS9 is no longer supported. I ran this test several hundred times locally on an iOS11 device with no flake. Bug: 780824 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I61b33e8cb3c0e4dab760b75361649fda56b4e6a1 Reviewed-on: https://chromium-review.googlesource.com/802082 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#520743} [modify] https://crrev.com/dd12859a9c856c6919cedf6c35d13b8b22af94e1/ios/chrome/browser/ui/util/manual_text_framer_unittest.mm
,
Dec 1 2017
,
Dec 1 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-64; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-64 label, otherwise remove Merge-TBD label. Thanks.
,
Dec 19 2017
kkhorimoto@ should this be merged in M64?
,
Jan 5 2018
Why is this test blocking Stable? kkhorimoto@ are you planning to merge the fix in M64?
,
Jan 5 2018
I think this was filed as RBS just to follow our guidelines of marking test failure bugs as release-blocking for the next release. Merging this CL will add some additional test coverage, but it's probably not necessary given that this test has been running on the main waterfall since 11/30, and there haven't been any recent updates to ManualTextFramer that would make this fail on branch.
,
Jan 8 2018
I see! The guidelines says failed tests should be marked as RBDev and not RBStable for the next milestone. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Nov 2 2017