New issue
Advanced search Search tips

Issue 780816 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Make errors in DevTools expandable

Project Member Reported by surma@chromium.org, Nov 2 2017

Issue description

Chrome Version       : 61.0.3163.100
OS Version: OS X 10.12.6

What steps will reproduce the problem?
1. Open DevTools and enable “Pause on Exceptions”
2. Run code that throws with a long exception description

What is the expected result?

I can read the full error message in DevTools


What happens instead of that?

Error message gets truncated, only on hover can I read the full error message.


Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36



 
Screen Shot 2017-11-02 at 1.21.26 PM.png
282 KB View Download
Owner: kozy@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8d7bd37fb6fe30769688dbcb569f09d1644504a

commit e8d7bd37fb6fe30769688dbcb569f09d1644504a
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Tue Dec 05 01:56:29 2017

[DevTools] show multiline errors in DebuggerPausedMessage

Without this CL we show only first line, sometimes other lines are
important as well (see attached bug). With this CL we show message
until first call frame.

R=lushnikov@chromium.org

Bug:  chromium:780816 
Change-Id: I4737c7cb4e7033126eeb7a419bcb59478afea0d2
Reviewed-on: https://chromium-review.googlesource.com/802076
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521587}
[modify] https://crrev.com/e8d7bd37fb6fe30769688dbcb569f09d1644504a/third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js

Comment 3 by kozy@chromium.org, Dec 5 2017

Status: Fixed (was: Assigned)
Now we will show all lines except stack trace. Should be enough for all web platform exceptions.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fefda76f8e5f012cc3b9a7800616ed6525c0fb18

commit fefda76f8e5f012cc3b9a7800616ed6525c0fb18
Author: calamity <calamity@chromium.org>
Date: Tue Dec 05 03:50:55 2017

Revert "[DevTools] show multiline errors in DebuggerPausedMessage"

This reverts commit e8d7bd37fb6fe30769688dbcb569f09d1644504a.

Reason for revert: Seems to be causing these test failures:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Trusty__dbg_/7571/layout-test-results/results.html

Original change's description:
> [DevTools] show multiline errors in DebuggerPausedMessage
> 
> Without this CL we show only first line, sometimes other lines are
> important as well (see attached bug). With this CL we show message
> until first call frame.
> 
> R=​lushnikov@chromium.org
> 
> Bug:  chromium:780816 
> Change-Id: I4737c7cb4e7033126eeb7a419bcb59478afea0d2
> Reviewed-on: https://chromium-review.googlesource.com/802076
> Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521587}

TBR=lushnikov@chromium.org,kozyatinskiy@chromium.org

Change-Id: Ifbb44fa5029f8019317d8757e0289f8c0296607a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:780816 
Reviewed-on: https://chromium-review.googlesource.com/807597
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521606}
[modify] https://crrev.com/fefda76f8e5f012cc3b9a7800616ed6525c0fb18/third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js

Comment 5 by kozy@chromium.org, Dec 5 2017

Status: Assigned (was: Fixed)
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7abc5f0a6ec21eb63e891e2f79d27bcf40f4049c

commit 7abc5f0a6ec21eb63e891e2f79d27bcf40f4049c
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Tue Dec 12 17:02:18 2017

Reland [DevTools] show multiline errors in DebuggerPausedMessage

Without this CL we show only first line, sometimes other lines are
important as well (see attached bug). With this CL we show message
until first call frame.

TBR=lushnikov@chromium.org

Bug:  chromium:780816 
Change-Id: If5e9322e8bb5b2c263c1a95e4026347db14b1b6d
Reviewed-on: https://chromium-review.googlesource.com/802076
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#521587}
Reviewed-on: https://chromium-review.googlesource.com/822131
Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523457}
[modify] https://crrev.com/7abc5f0a6ec21eb63e891e2f79d27bcf40f4049c/third_party/WebKit/Source/devtools/front_end/sources/DebuggerPausedMessage.js

Comment 7 by kozy@chromium.org, Dec 12 2017

Status: Fixed (was: Assigned)

Sign in to add a comment