Now base::ThreadTaskRunnerHandle::Get() is used for the listener in ChannelProxy::Context, and we know this is the place where the most time-consuming tasks are queued. Let's use another task runner for more analyzation. Doc: https://docs.google.com/document/d/1yOhE6-1HLb3aeNWmoa9O2LlnegWjd4awYUn2OhUL4vk/edit?ts=59f84c7c#
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff15e975de135dd54b1572e5b9a53f47e8a0df7a commit ff15e975de135dd54b1572e5b9a53f47e8a0df7a Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Thu Nov 09 06:37:09 2017 Make IPC listener task runner changeable This CL adds an argument for listener task runner to IPC::ChannelProxy::Create and IPC::SyncChannel::Create so that we can have more flexible task scheduling. Now all arguments are base::ThreadTaskRunnerHandle::Get() and this CL doesn't change the behavior. This CL is just a preparation. We've already known that channel proxy's OnMessageReceivedNoFilter posts the most heaviest tasks to the listener task runner. Doc: https://docs.google.com/document/d/1yOhE6-1HLb3aeNWmoa9O2LlnegWjd4awYUn2OhUL4vk/edit# Bug: 780785 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia0d798c55aeb739d7150e9368350ecd28f4159c6 Reviewed-on: https://chromium-review.googlesource.com/750922 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#515115} [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/chrome/app_shim/chrome_main_app_mode_mac.mm [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/chrome/browser/apps/app_shim/app_shim_host_mac.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/components/nacl/browser/nacl_process_host.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/components/nacl/loader/nacl_listener.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/components/nacl/loader/nonsfi/nonsfi_listener.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/components/nacl/renderer/manifest_service_channel.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/components/nacl/renderer/ppb_nacl_private_impl.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/content/browser/browser_associated_interface_unittest.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/content/child/child_thread_impl.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/content/renderer/render_thread_impl_browsertest.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/gpu/ipc/client/gpu_channel_host.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/gpu/ipc/service/gpu_channel.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/ipc/ipc_channel_mojo_unittest.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/ipc/ipc_channel_proxy.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/ipc/ipc_channel_proxy.h [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/ipc/ipc_channel_proxy_unittest.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/ipc/ipc_cpu_perftest.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/ipc/ipc_mojo_perftest.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/ipc/ipc_perftest_util.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/ipc/ipc_sync_channel.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/ipc/ipc_sync_channel.h [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/ipc/ipc_sync_channel_unittest.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/ppapi/nacl_irt/manifest_service.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/ppapi/nacl_irt/ppapi_dispatcher.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/ppapi/proxy/proxy_channel.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/remoting/host/desktop_process.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/remoting/host/desktop_process_unittest.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/remoting/host/desktop_session_agent.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/remoting/host/desktop_session_agent_unittest.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/remoting/host/desktop_session_proxy.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/remoting/host/desktop_session_proxy.h [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/remoting/host/ipc_desktop_environment_unittest.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/remoting/host/remoting_me2me_host.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/remoting/host/win/unprivileged_process_delegate.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/remoting/host/win/worker_process_launcher_unittest.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/remoting/host/win/wts_session_process_delegate.cc [modify] https://crrev.com/ff15e975de135dd54b1572e5b9a53f47e8a0df7a/tools/ipc_fuzzer/message_replay/replay_process.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe11b13ec496a6083e49aa9ba3e118eb5a00fdd7 commit fe11b13ec496a6083e49aa9ba3e118eb5a00fdd7 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Mon Nov 13 10:16:07 2017 Enable ChildThreadImpl to refer ChildScheduler for IPC task runner Now ChildThreadImpl needs to pass an IPC listener task runner to create IPC::SyncChannel, but ChildThreadImpl can't refer schedulers. This CL enables ChildThreadImpl to refer ChildScheduler by adding ChildScheduler ::IPCListenerTaskRunner function. Now the implementation (RendererScheduler::IPCListenerTaskRunner) just returns base:: ThreadTaskRunnerHandle::Get(). This CL is just a preparation for flexible scheduling, and doesn't change any behavior so far. Bug: 780785 Change-Id: I46965cab95ca6f98dee56299df9ebea1462886d8 Reviewed-on: https://chromium-review.googlesource.com/760336 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#515913} [modify] https://crrev.com/fe11b13ec496a6083e49aa9ba3e118eb5a00fdd7/content/child/child_thread_impl.cc [modify] https://crrev.com/fe11b13ec496a6083e49aa9ba3e118eb5a00fdd7/content/child/child_thread_impl.h [modify] https://crrev.com/fe11b13ec496a6083e49aa9ba3e118eb5a00fdd7/content/renderer/render_thread_impl.cc [modify] https://crrev.com/fe11b13ec496a6083e49aa9ba3e118eb5a00fdd7/third_party/WebKit/Source/platform/scheduler/child/compositor_worker_scheduler.cc [modify] https://crrev.com/fe11b13ec496a6083e49aa9ba3e118eb5a00fdd7/third_party/WebKit/Source/platform/scheduler/child/compositor_worker_scheduler.h [modify] https://crrev.com/fe11b13ec496a6083e49aa9ba3e118eb5a00fdd7/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.cc [modify] https://crrev.com/fe11b13ec496a6083e49aa9ba3e118eb5a00fdd7/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.h [modify] https://crrev.com/fe11b13ec496a6083e49aa9ba3e118eb5a00fdd7/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc [modify] https://crrev.com/fe11b13ec496a6083e49aa9ba3e118eb5a00fdd7/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h [modify] https://crrev.com/fe11b13ec496a6083e49aa9ba3e118eb5a00fdd7/third_party/WebKit/Source/platform/scheduler/test/fake_renderer_scheduler.cc [modify] https://crrev.com/fe11b13ec496a6083e49aa9ba3e118eb5a00fdd7/third_party/WebKit/public/platform/scheduler/child/child_scheduler.h [modify] https://crrev.com/fe11b13ec496a6083e49aa9ba3e118eb5a00fdd7/third_party/WebKit/public/platform/scheduler/test/fake_renderer_scheduler.h [modify] https://crrev.com/fe11b13ec496a6083e49aa9ba3e118eb5a00fdd7/third_party/WebKit/public/platform/scheduler/test/mock_renderer_scheduler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e68110c9ae3a9a7fe1d97f2ef42940b6a661547 commit 7e68110c9ae3a9a7fe1d97f2ef42940b6a661547 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Mon Nov 13 13:25:33 2017 Add MainThreadTaskQueue::QueueType::IPC and use at RendererSchedulerImpl::IPCTaskRunner This CL makes RendererSchedulerImpl::IPCTaskRunner return a new task queue with the new type IPC instead of base::ThreadTaskRunnerHandle:: Get(). Bug: 780785 Change-Id: I41ca614cb6f894127902062b838092c2ecc48a5e Reviewed-on: https://chromium-review.googlesource.com/765688 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#515939} [modify] https://crrev.com/7e68110c9ae3a9a7fe1d97f2ef42940b6a661547/third_party/WebKit/Source/platform/scheduler/renderer/main_thread_task_queue.cc [modify] https://crrev.com/7e68110c9ae3a9a7fe1d97f2ef42940b6a661547/third_party/WebKit/Source/platform/scheduler/renderer/main_thread_task_queue.h [modify] https://crrev.com/7e68110c9ae3a9a7fe1d97f2ef42940b6a661547/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc [modify] https://crrev.com/7e68110c9ae3a9a7fe1d97f2ef42940b6a661547/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46b37f68532a47b5c25bd7b8f466d564a6f96593 commit 46b37f68532a47b5c25bd7b8f466d564a6f96593 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Tue Nov 14 19:37:33 2017 Add IPC to RendererSchedulerTaskQueueType in enums.xml The value was added at https://chromium-review.googlesource.com/c/chromium/src/+/765688 but I forgot to fix enums.xml. Bug: 780785 Change-Id: Ifa0f1ebdf427ddaf33a84caadf3d0491f88a8fed Reviewed-on: https://chromium-review.googlesource.com/768634 Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#516389} [modify] https://crrev.com/46b37f68532a47b5c25bd7b8f466d564a6f96593/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b4909cfe8dcc762313baddfeda114c6152ac9a5 commit 9b4909cfe8dcc762313baddfeda114c6152ac9a5 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Fri Nov 17 10:57:12 2017 Add a new UMA RendererScheduler.TaskDurationPerTaskType This CL adds a new UMA RendererScheduler.TaskDurationPerTaskType to know what kind of task type of tasks consumes how much time. Bug: 780785 Change-Id: I2dc6f4d042945d79089eb1320e220f2b91de51ca Reviewed-on: https://chromium-review.googlesource.com/771374 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#517366} [modify] https://crrev.com/9b4909cfe8dcc762313baddfeda114c6152ac9a5/third_party/WebKit/Source/platform/scheduler/child/worker_global_scope_scheduler.cc [modify] https://crrev.com/9b4909cfe8dcc762313baddfeda114c6152ac9a5/third_party/WebKit/Source/platform/scheduler/renderer/renderer_metrics_helper.cc [modify] https://crrev.com/9b4909cfe8dcc762313baddfeda114c6152ac9a5/third_party/WebKit/Source/platform/scheduler/renderer/renderer_metrics_helper.h [modify] https://crrev.com/9b4909cfe8dcc762313baddfeda114c6152ac9a5/third_party/WebKit/Source/platform/scheduler/renderer/renderer_metrics_helper_unittest.cc [modify] https://crrev.com/9b4909cfe8dcc762313baddfeda114c6152ac9a5/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc [modify] https://crrev.com/9b4909cfe8dcc762313baddfeda114c6152ac9a5/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc [modify] https://crrev.com/9b4909cfe8dcc762313baddfeda114c6152ac9a5/third_party/WebKit/public/platform/TaskType.h [modify] https://crrev.com/9b4909cfe8dcc762313baddfeda114c6152ac9a5/tools/metrics/histograms/enums.xml [modify] https://crrev.com/9b4909cfe8dcc762313baddfeda114c6152ac9a5/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af5d285b3aedc188ea7d997a349fd0d16fbbf643 commit af5d285b3aedc188ea7d997a349fd0d16fbbf643 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Wed Nov 22 12:23:44 2017 Remove calling ToSingleThreadTaskRunner in blink::Timer Calling SingleThreadTaskRunner's PostTask instead of WebTaskRunner loses task type information (kJavaScript in this case), and the UMA for task types is confused. This CL fixes this to remove the indirection. Bug: 780785 Change-Id: I19cf843e336e9daf95bd0c697bf5a0cdf7e1ab87 Reviewed-on: https://chromium-review.googlesource.com/785114 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#518613} [modify] https://crrev.com/af5d285b3aedc188ea7d997a349fd0d16fbbf643/third_party/WebKit/Source/platform/Timer.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55e4f90f01493ef79f0c6559298fffcd6fdd4c9b commit 55e4f90f01493ef79f0c6559298fffcd6fdd4c9b Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Wed Nov 22 13:23:16 2017 Use IPC task runner for IPC::ChannelMojo::CreateClientFactory at ChildThreadImpl Bug: 780785 Change-Id: I19718d9ba39a3c883f2b7fab6470ae0b240caaeb Reviewed-on: https://chromium-review.googlesource.com/781541 Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#518622} [modify] https://crrev.com/55e4f90f01493ef79f0c6559298fffcd6fdd4c9b/content/child/child_thread_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/acd2caf6699cfc56d00fa0d706d5813bf16bb074 commit acd2caf6699cfc56d00fa0d706d5813bf16bb074 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Wed Nov 22 13:52:32 2017 Avoid using default argument for WebTaskRunnerImpl::Create This CL is just refactoring to avoid default arguments. We plan to replace base::nullopt with specific task types. Bug: 780785 Change-Id: I1369ac944fa49f6aed11a841d17011d1c3a1faf9 Reviewed-on: https://chromium-review.googlesource.com/781330 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#518625} [modify] https://crrev.com/acd2caf6699cfc56d00fa0d706d5813bf16bb074/third_party/WebKit/Source/platform/TimerTest.cpp [modify] https://crrev.com/acd2caf6699cfc56d00fa0d706d5813bf16bb074/third_party/WebKit/Source/platform/scheduler/child/web_scheduler_impl.cc [modify] https://crrev.com/acd2caf6699cfc56d00fa0d706d5813bf16bb074/third_party/WebKit/Source/platform/scheduler/child/web_task_runner_impl.h [modify] https://crrev.com/acd2caf6699cfc56d00fa0d706d5813bf16bb074/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc [modify] https://crrev.com/acd2caf6699cfc56d00fa0d706d5813bf16bb074/third_party/WebKit/Source/platform/scheduler/renderer/renderer_web_scheduler_impl.cc [modify] https://crrev.com/acd2caf6699cfc56d00fa0d706d5813bf16bb074/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc [modify] https://crrev.com/acd2caf6699cfc56d00fa0d706d5813bf16bb074/third_party/WebKit/Source/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe3ecdc3b1332d2c212b0cd8b273fc2fad7a88f6 commit fe3ecdc3b1332d2c212b0cd8b273fc2fad7a88f6 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Tue Nov 28 03:34:13 2017 Avoid default arguments at IPC::Channel::CreateClient/Server and IPC::ChannelMojo::Create The number of callers is not many. Let's pass task runners explicitly for code health. This CL is a preparation to replace base::ThreadTaskRunnerHandle::Get with more appropriate task runners. Bug: 780785 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I998fb338228069f6c164b13144319c0810b1de2c Reviewed-on: https://chromium-review.googlesource.com/784910 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#519547} [modify] https://crrev.com/fe3ecdc3b1332d2c212b0cd8b273fc2fad7a88f6/chrome/browser/pepper_flash_settings_manager.cc [modify] https://crrev.com/fe3ecdc3b1332d2c212b0cd8b273fc2fad7a88f6/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc [modify] https://crrev.com/fe3ecdc3b1332d2c212b0cd8b273fc2fad7a88f6/components/nacl/broker/nacl_broker_listener.cc [modify] https://crrev.com/fe3ecdc3b1332d2c212b0cd8b273fc2fad7a88f6/content/browser/plugin_data_remover_impl.cc [modify] https://crrev.com/fe3ecdc3b1332d2c212b0cd8b273fc2fad7a88f6/content/common/child_process_host_impl.cc [modify] https://crrev.com/fe3ecdc3b1332d2c212b0cd8b273fc2fad7a88f6/gpu/ipc/client/gpu_channel_host.cc [modify] https://crrev.com/fe3ecdc3b1332d2c212b0cd8b273fc2fad7a88f6/ipc/ipc_channel.h [modify] https://crrev.com/fe3ecdc3b1332d2c212b0cd8b273fc2fad7a88f6/ipc/ipc_channel_common.cc [modify] https://crrev.com/fe3ecdc3b1332d2c212b0cd8b273fc2fad7a88f6/ipc/ipc_channel_factory.cc [modify] https://crrev.com/fe3ecdc3b1332d2c212b0cd8b273fc2fad7a88f6/ipc/ipc_channel_mojo.h [modify] https://crrev.com/fe3ecdc3b1332d2c212b0cd8b273fc2fad7a88f6/ipc/ipc_test_base.cc [modify] https://crrev.com/fe3ecdc3b1332d2c212b0cd8b273fc2fad7a88f6/remoting/host/security_key/fake_security_key_ipc_client.cc [modify] https://crrev.com/fe3ecdc3b1332d2c212b0cd8b273fc2fad7a88f6/remoting/host/security_key/fake_security_key_ipc_server.cc [modify] https://crrev.com/fe3ecdc3b1332d2c212b0cd8b273fc2fad7a88f6/remoting/host/security_key/security_key_ipc_client.cc [modify] https://crrev.com/fe3ecdc3b1332d2c212b0cd8b273fc2fad7a88f6/remoting/host/security_key/security_key_ipc_server_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a16269332515e01beed01bf134dafaf192b73774 commit a16269332515e01beed01bf134dafaf192b73774 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Thu Nov 30 09:50:59 2017 Use IPC task runner at RenderThradImpl when possible This is a remaining task that should have been done at https://chromium-review.googlesource.com/c/chromium/src/+/760336 Bug: 780785 Change-Id: Icbaedd76f04ed03cc1110d76d16366f62c3e1d6d Reviewed-on: https://chromium-review.googlesource.com/799656 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#520495} [modify] https://crrev.com/a16269332515e01beed01bf134dafaf192b73774/content/renderer/render_thread_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad6f4e88ca12720b561f3c5e7e2b3831a73e0812 commit ad6f4e88ca12720b561f3c5e7e2b3831a73e0812 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Tue Feb 20 03:20:43 2018 Use per-frame task runner at AssociateBiding::Bind usages at RenderFrameImpl This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 780785, 786332 Change-Id: I78cb3555cdf9e77c65db286fd37c887d6ac30d56 Reviewed-on: https://chromium-review.googlesource.com/923626 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#537703} [modify] https://crrev.com/ad6f4e88ca12720b561f3c5e7e2b3831a73e0812/content/renderer/render_frame_impl.cc [modify] https://crrev.com/ad6f4e88ca12720b561f3c5e7e2b3831a73e0812/third_party/WebKit/Source/platform/scheduler/child/worker_global_scope_scheduler.cc [modify] https://crrev.com/ad6f4e88ca12720b561f3c5e7e2b3831a73e0812/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc [modify] https://crrev.com/ad6f4e88ca12720b561f3c5e7e2b3831a73e0812/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc [modify] https://crrev.com/ad6f4e88ca12720b561f3c5e7e2b3831a73e0812/third_party/WebKit/public/platform/TaskType.h [modify] https://crrev.com/ad6f4e88ca12720b561f3c5e7e2b3831a73e0812/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/efa3bdc371761e9c1934816c3b3b1bb6ec2ee884 commit efa3bdc371761e9c1934816c3b3b1bb6ec2ee884 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Fri Feb 23 01:23:35 2018 Use per-frame task runner at ResourceFetcherImpl This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 780785, 786332 Change-Id: I044ee9e5d29f82d133faab3dd7097615e452683e Reviewed-on: https://chromium-review.googlesource.com/930982 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#538654} [modify] https://crrev.com/efa3bdc371761e9c1934816c3b3b1bb6ec2ee884/content/renderer/fetchers/resource_fetcher_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a05c4b140df29bcef7e2b7747f158b4227629db commit 9a05c4b140df29bcef7e2b7747f158b4227629db Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Mon Feb 26 05:10:17 2018 media: Use task runner for testing in MockPeerConnectionTrackerHost This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 780785, 786332 Change-Id: Ic9801a4896dd4d9a70f9b9fa4f5b26dc474db224 Reviewed-on: https://chromium-review.googlesource.com/930524 Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#539071} [modify] https://crrev.com/9a05c4b140df29bcef7e2b7747f158b4227629db/content/renderer/media/webrtc/peer_connection_tracker_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d45800c05cd94d58da5627510bfc397b75800dc3 commit d45800c05cd94d58da5627510bfc397b75800dc3 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Tue Feb 27 07:45:51 2018 Pass a task runner to mojo::SimpleWatcher at web_service_worker_installed_scripts_manager_impl.cc This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. This avoids the SequencedTaskRunnerHandle::Get() call when the constructor's default parameter is used. We are trying to ban SequencedTaskRunnerHandle::Get() in content/renderer because it usually is not the right task runner to use, as a per-frame runner should be used instead. In this case, it doesn't really matter since frames are not involved, but we still want to remove the calls for the bigger benefit of banning it in content/renderer. Bug: 780785, 786332 Change-Id: I307cd4923912809b0577074585ea9fd953a84ef3 Reviewed-on: https://chromium-review.googlesource.com/937104 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#539410} [modify] https://crrev.com/d45800c05cd94d58da5627510bfc397b75800dc3/content/renderer/service_worker/web_service_worker_installed_scripts_manager_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd69a4d508258c854a94c8c40ebb70abfbec614c commit bd69a4d508258c854a94c8c40ebb70abfbec614c Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Thu Mar 01 09:43:55 2018 Use per-frame task runners at WebDataConsumerHandleImpl::handle_watcher_ This CL also fixes WebDataConsumerHandle and its children classes. This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 780785, 786332 Change-Id: Ia0ab834c52614190a49d74b177f07b2f3b3193e0 Reviewed-on: https://chromium-review.googlesource.com/934381 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#540118} [modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/content/renderer/loader/shared_memory_data_consumer_handle.cc [modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/content/renderer/loader/shared_memory_data_consumer_handle.h [modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/content/renderer/loader/shared_memory_data_consumer_handle_unittest.cc [modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/content/renderer/loader/web_data_consumer_handle_impl.cc [modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/content/renderer/loader/web_data_consumer_handle_impl.h [modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/content/renderer/loader/web_data_consumer_handle_impl_unittest.cc [modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/third_party/WebKit/Source/core/fetch/BytesConsumerForDataConsumerHandle.cpp [modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/third_party/WebKit/Source/core/fetch/BytesConsumerForDataConsumerHandleTest.cpp [modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/third_party/WebKit/Source/core/fetch/DataConsumerHandleTestUtil.cpp [modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/third_party/WebKit/Source/core/fetch/DataConsumerHandleTestUtil.h [modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/third_party/WebKit/Source/core/fetch/FetchManager.cpp [modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp [modify] https://crrev.com/bd69a4d508258c854a94c8c40ebb70abfbec614c/third_party/WebKit/public/platform/WebDataConsumerHandle.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/605413f349ecd6bcb0e82f2e8f5c1006437e129f commit 605413f349ecd6bcb0e82f2e8f5c1006437e129f Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Fri Mar 02 11:49:54 2018 Use more appropriate task runners at WorkerThreadMessageFilter This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 780785, 786332 Change-Id: If4653c563a28d5afaa544fdf8d3450df2ad0bb2e Reviewed-on: https://chromium-review.googlesource.com/939144 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#540495} [modify] https://crrev.com/605413f349ecd6bcb0e82f2e8f5c1006437e129f/content/renderer/cache_storage/cache_storage_message_filter.cc [modify] https://crrev.com/605413f349ecd6bcb0e82f2e8f5c1006437e129f/content/renderer/cache_storage/cache_storage_message_filter.h [modify] https://crrev.com/605413f349ecd6bcb0e82f2e8f5c1006437e129f/content/renderer/notifications/notification_dispatcher.cc [modify] https://crrev.com/605413f349ecd6bcb0e82f2e8f5c1006437e129f/content/renderer/notifications/notification_dispatcher.h [modify] https://crrev.com/605413f349ecd6bcb0e82f2e8f5c1006437e129f/content/renderer/render_thread_impl.cc [modify] https://crrev.com/605413f349ecd6bcb0e82f2e8f5c1006437e129f/content/renderer/service_worker/service_worker_message_filter.cc [modify] https://crrev.com/605413f349ecd6bcb0e82f2e8f5c1006437e129f/content/renderer/service_worker/service_worker_message_filter.h [modify] https://crrev.com/605413f349ecd6bcb0e82f2e8f5c1006437e129f/content/renderer/worker_thread_message_filter.cc [modify] https://crrev.com/605413f349ecd6bcb0e82f2e8f5c1006437e129f/content/renderer/worker_thread_message_filter.h
Comment 1 by bugdroid1@chromium.org
, Nov 9 2017