New issue
Advanced search Search tips

Issue 780764 link

Starred by 1 user
Status: Assigned
Owner:
pmarko@chromium.org
Cc:
rsorokin@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add test for update_policies.py (generating histograms)

Project Member Reported by pmarko@chromium.org, Nov 2 2017 
We have no test for update_policies.py.
We should add one.

Trigger: Recently[1], update_policies.py was broken due to a change in policy_templates.json and no one noticed. It was fixed in [2].

[1] https://chromium-review.googlesource.com/#/c/657402/
[2] https://chromium-review.googlesource.com/c/chromium/src/+/747634

Comment 1 by pmarko@chromium.org, Nov 2 2017 

Maybe make the (to-be-added) test also access the real policy_templates.json and run them as PRESUBMIT when update_policies.py or policy_templates.json is modified?

The run-on-PRESUBMIT approach would be similar to what's done in https://cs.chromium.org/chromium/src/components/policy/tools/template_writers/PRESUBMIT.py

Comment 2 by pmarko@chromium.org, Feb 6 2018

Labels: pmarko-backlog
►

Sign in to add a comment