New issue
Advanced search Search tips

Issue 780761 link

Starred by 1 user
Status: Fixed
Owner:
se...@chromium.org
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

:placeholder-shown pseudo class is applied to autofill suggestion fields

Project Member Reported by keishi@chromium.org, Nov 2 2017 
Chrome Version: 64.0.3255.3
OS: Mac, all

What steps will reproduce the problem?
(1) Open attached file
(2) Add autofill address with city=Springfield to profile
(3) Click city input to show autofill popup
(4) Hover mouse over Springfield suggestion

What is the expected result?
None of the fields have purple box-shadow.

What happens instead?
All fields have purple box-shadow.

isPlaceholderVisible() is conflating "is placeholder element visible" and "is placement value visible".
Autofill Smoke Test.htm
1.1 KB View Download

Comment 1 by se...@chromium.org, Nov 3 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9614c32f565d8efd693bb0826fc3516be0c007d8

commit 9614c32f565d8efd693bb0826fc3516be0c007d8
Author: sebsg <sebsg@chromium.org>
Date: Fri Nov 24 14:38:02 2017

[Autofill] Update placeholder visibility when resetting suggested value.

Bug:  780761 
Change-Id: Ia0c19238ed3fb74d2f21bb43211c0e44aa5179de
Reviewed-on: https://chromium-review.googlesource.com/752429
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519109}
[add] https://crrev.com/9614c32f565d8efd693bb0826fc3516be0c007d8/third_party/WebKit/LayoutTests/fast/forms/text/input-appearance-autocomplete-empty-suggested-value-after-suggested-value-expected.html
[add] https://crrev.com/9614c32f565d8efd693bb0826fc3516be0c007d8/third_party/WebKit/LayoutTests/fast/forms/text/input-appearance-autocomplete-empty-suggested-value-after-suggested-value.html
[add] https://crrev.com/9614c32f565d8efd693bb0826fc3516be0c007d8/third_party/WebKit/LayoutTests/fast/forms/text/input-appearance-autocomplete-fill-value-after-suggested-value-expected.html
[add] https://crrev.com/9614c32f565d8efd693bb0826fc3516be0c007d8/third_party/WebKit/LayoutTests/fast/forms/text/input-appearance-autocomplete-fill-value-after-suggested-value.html
[add] https://crrev.com/9614c32f565d8efd693bb0826fc3516be0c007d8/third_party/WebKit/LayoutTests/fast/forms/text/input-appearance-autocomplete-suggested-value-over-placeholder-value-expected.html
[add] https://crrev.com/9614c32f565d8efd693bb0826fc3516be0c007d8/third_party/WebKit/LayoutTests/fast/forms/text/input-appearance-autocomplete-suggested-value-over-placeholder-value.html
[add] https://crrev.com/9614c32f565d8efd693bb0826fc3516be0c007d8/third_party/WebKit/LayoutTests/fast/forms/text/input-appearance-autocomplete-suggested-value-when-underlying-placeholder-is-removed-expected.html
[add] https://crrev.com/9614c32f565d8efd693bb0826fc3516be0c007d8/third_party/WebKit/LayoutTests/fast/forms/text/input-appearance-autocomplete-suggested-value-when-underlying-placeholder-is-removed.html
[modify] https://crrev.com/9614c32f565d8efd693bb0826fc3516be0c007d8/third_party/WebKit/Source/core/html/forms/TextControlElement.cpp
[modify] https://crrev.com/9614c32f565d8efd693bb0826fc3516be0c007d8/third_party/WebKit/Source/core/html/forms/TextControlElement.h

Comment 3 by se...@chromium.org, Nov 24 2017

Status: Fixed (was: Started)
►

Sign in to add a comment