New issue
Advanced search Search tips

Issue 780758 link

Starred by 1 user
Status: Assigned
Owner:
se...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression Typing while autofill preview ignores first keypress

Project Member Reported by keishi@chromium.org, Nov 2 2017 
1. Open https://sebsg.github.io/autofill/suggested-value-test.html
2. Add autofill address with city=Springfield to profile
3. Click city input to show autofill popup
4. Hover mouse over Springfield suggestion
5. Type "a"

Expected: old Chrome will show "Springfielda"
Actual: new Chrome will show "Springfield" with cursor after "S"

Tried on Mac

Attaching test case html
suggestion-keypress.html
697 bytes View Download

Comment 1 by keishi@chromium.org, Nov 9 2017

Labels: -Pri-3 Pri-1
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edfdc47e9111d6413bdf67fe571275ff2266bce9

commit edfdc47e9111d6413bdf67fe571275ff2266bce9
Author: sebsg <sebsg@chromium.org>
Date: Tue Dec 19 17:33:39 2017

[Autofill] Fix user editing autofill preview bug.

Bug: 780758
Change-Id: Ifac58b422731e07dc4eb18c01cb1957c28aaf327
Reviewed-on: https://chromium-review.googlesource.com/789531
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525069}
[modify] https://crrev.com/edfdc47e9111d6413bdf67fe571275ff2266bce9/chrome/renderer/autofill/form_autofill_browsertest.cc
[modify] https://crrev.com/edfdc47e9111d6413bdf67fe571275ff2266bce9/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/edfdc47e9111d6413bdf67fe571275ff2266bce9/third_party/WebKit/LayoutTests/fast/forms/javascript-cannot-access-suggested-value.html
[modify] https://crrev.com/edfdc47e9111d6413bdf67fe571275ff2266bce9/third_party/WebKit/LayoutTests/fast/forms/suggested-value-after-empty-suggested-value-expected.txt
[modify] https://crrev.com/edfdc47e9111d6413bdf67fe571275ff2266bce9/third_party/WebKit/LayoutTests/fast/forms/suggested-value-after-setvalue-expected.txt
[modify] https://crrev.com/edfdc47e9111d6413bdf67fe571275ff2266bce9/third_party/WebKit/LayoutTests/fast/forms/suggested-value-expected.txt
[modify] https://crrev.com/edfdc47e9111d6413bdf67fe571275ff2266bce9/third_party/WebKit/LayoutTests/fast/forms/text/input-appearance-autocomplete-with-initial-value-expected.html
[modify] https://crrev.com/edfdc47e9111d6413bdf67fe571275ff2266bce9/third_party/WebKit/LayoutTests/fast/forms/text/input-appearance-autocomplete-with-initial-value.html
[modify] https://crrev.com/edfdc47e9111d6413bdf67fe571275ff2266bce9/third_party/WebKit/Source/core/html/forms/TextControlElement.cpp
[modify] https://crrev.com/edfdc47e9111d6413bdf67fe571275ff2266bce9/third_party/WebKit/Source/core/html/forms/TextControlInnerElements.cpp
[modify] https://crrev.com/edfdc47e9111d6413bdf67fe571275ff2266bce9/third_party/WebKit/Source/core/html/forms/TextControlInnerElements.h

Comment 3 by se...@chromium.org, Dec 22 2017

Labels: Merge-Request-64
Project Member

Comment 4 by sheriffbot@chromium.org, Dec 22 2017

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by abdulsyed@google.com, Dec 27 2017

Labels: -Merge-Review-64 Merge-Approved-64
Approving merge, in Canary for over a week. Branch:3282
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 3 2018

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9860087be7ca081d97d6756f8cecb7e2e3a98aeb

commit 9860087be7ca081d97d6756f8cecb7e2e3a98aeb
Author: sebsg <sebsg@chromium.org>
Date: Wed Jan 03 17:30:12 2018

Merge-64 [Autofill] Fix user editing autofill preview bug.

TBR=sebsg@chromium.org

(cherry picked from commit edfdc47e9111d6413bdf67fe571275ff2266bce9)

Bug: 780758
Change-Id: Ifac58b422731e07dc4eb18c01cb1957c28aaf327
Reviewed-on: https://chromium-review.googlesource.com/789531
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Keishi Hattori <keishi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#525069}
Reviewed-on: https://chromium-review.googlesource.com/849073
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#399}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/9860087be7ca081d97d6756f8cecb7e2e3a98aeb/chrome/renderer/autofill/form_autofill_browsertest.cc
[modify] https://crrev.com/9860087be7ca081d97d6756f8cecb7e2e3a98aeb/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/9860087be7ca081d97d6756f8cecb7e2e3a98aeb/third_party/WebKit/LayoutTests/fast/forms/javascript-cannot-access-suggested-value.html
[modify] https://crrev.com/9860087be7ca081d97d6756f8cecb7e2e3a98aeb/third_party/WebKit/LayoutTests/fast/forms/suggested-value-after-empty-suggested-value-expected.txt
[modify] https://crrev.com/9860087be7ca081d97d6756f8cecb7e2e3a98aeb/third_party/WebKit/LayoutTests/fast/forms/suggested-value-after-setvalue-expected.txt
[modify] https://crrev.com/9860087be7ca081d97d6756f8cecb7e2e3a98aeb/third_party/WebKit/LayoutTests/fast/forms/suggested-value-expected.txt
[modify] https://crrev.com/9860087be7ca081d97d6756f8cecb7e2e3a98aeb/third_party/WebKit/LayoutTests/fast/forms/text/input-appearance-autocomplete-with-initial-value-expected.html
[modify] https://crrev.com/9860087be7ca081d97d6756f8cecb7e2e3a98aeb/third_party/WebKit/LayoutTests/fast/forms/text/input-appearance-autocomplete-with-initial-value.html
[modify] https://crrev.com/9860087be7ca081d97d6756f8cecb7e2e3a98aeb/third_party/WebKit/Source/core/html/forms/TextControlElement.cpp
[modify] https://crrev.com/9860087be7ca081d97d6756f8cecb7e2e3a98aeb/third_party/WebKit/Source/core/html/forms/TextControlInnerElements.cpp
[modify] https://crrev.com/9860087be7ca081d97d6756f8cecb7e2e3a98aeb/third_party/WebKit/Source/core/html/forms/TextControlInnerElements.h

Comment 7 by ma...@chromium.org, May 1 2018

Components: UI>Browser>Autofill
►

Sign in to add a comment