New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 780749 link

Starred by 2 users
Status: Fixed
Owner:
mlippautz@chromium.org
Closed: Feb 2018
Cc:
yukishiino@chromium.org
█ hpayer@chromium.org
keishi@chromium.org
haraken@chromium.org
u...@chromium.org
lfg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Feature

Blocked on:
issue 781728
issue 787446


Sign in to add a comment

Remove independent lifetime handling from V8 and Blink

Project Member Reported by mlippautz@chromium.org, Nov 2 2017 
This involves removing
- [DependentLifetime] from IDL and Blink bindings
- Remove the corresponding flags (Independent) from v8::Persistent
- Remove Scavenger handling for Independent global handles
- Use Active/Not Active as indicator whether the Scavenger can drop wrappers

Document (chromium account required): 
  https://docs.google.com/a/chromium.org/document/d/1rDLChT4sj5Q4lgsbkmogDoWN2JIM3sjqsMuu-REUJ6U/

Comment 1 by haraken@chromium.org, Nov 2 2017

Cc: yukishiino@chromium.org

Comment 2 by mlippautz@chromium.org, Nov 6 2017

Blockedon: 781728
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/667555c6b8dadcfe4e592fe06bb6846468b8141e

commit 667555c6b8dadcfe4e592fe06bb6846468b8141e
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Thu Nov 09 17:29:11 2017

[heap] Remove independent handles

Removes the handling of the flag independent. The flag will be removed in a followup.

The patch changes handling of V8::PersistentBase that are set to Weak:
- The Scavenger ignores the flag independent.
- The Scavenger keeps alive anything that is marked as Active.
- The Scavenger is free to drop weak handles of non-Active object if they 
  are otherwise dead.

Active:
- Any JSObject will always be marked Active.
- Any JSApiObject will be marked Active if it has been modified (=has elements, properties, etc.)

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Bug:  chromium:780749 
Change-Id: If1f547f2419930ad9400bd3b11bdbf609cb57649
Reviewed-on: https://chromium-review.googlesource.com/741801
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49277}
[modify] https://crrev.com/667555c6b8dadcfe4e592fe06bb6846468b8141e/src/global-handles.cc
[modify] https://crrev.com/667555c6b8dadcfe4e592fe06bb6846468b8141e/src/global-handles.h
[modify] https://crrev.com/667555c6b8dadcfe4e592fe06bb6846468b8141e/src/profiler/sampling-heap-profiler.cc
[modify] https://crrev.com/667555c6b8dadcfe4e592fe06bb6846468b8141e/test/cctest/test-api.cc
[modify] https://crrev.com/667555c6b8dadcfe4e592fe06bb6846468b8141e/test/cctest/test-global-handles.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c44da6c271f5ff686bd4e2e45410763456ce528d

commit c44da6c271f5ff686bd4e2e45410763456ce528d
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Mon Nov 13 13:19:42 2017

[api] Refine description for PersistentBase::MarkActive

Bug:  chromium:780749 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: Ifd7da70dd9adffe5de7f126539c4780799d55673
Reviewed-on: https://chromium-review.googlesource.com/763528
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49323}
[modify] https://crrev.com/c44da6c271f5ff686bd4e2e45410763456ce528d/include/v8.h
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e7a83579b094f335c78bb05b19cd5c2901ae945

commit 7e7a83579b094f335c78bb05b19cd5c2901ae945
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Nov 15 10:06:50 2017

Media Engagement: Measure unique audible players

Measure the number of unique audible players. Also includes logic
to record which of these are significant, but not the refactor
to measure significance.

Refactor the contents observer to have a timer for each individual
player. This is so we can track the number of audible players on a page
that are significant.

BUG= 780749 

Change-Id: Icec7bc05d1f40e4ee14a1ca6f2f52f32e4bdbf8b
Reviewed-on: https://chromium-review.googlesource.com/751243
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516653}
[modify] https://crrev.com/7e7a83579b094f335c78bb05b19cd5c2901ae945/chrome/browser/media/media_engagement_browsertest.cc
[modify] https://crrev.com/7e7a83579b094f335c78bb05b19cd5c2901ae945/chrome/browser/media/media_engagement_contents_observer.cc
[modify] https://crrev.com/7e7a83579b094f335c78bb05b19cd5c2901ae945/chrome/browser/media/media_engagement_contents_observer.h
[modify] https://crrev.com/7e7a83579b094f335c78bb05b19cd5c2901ae945/chrome/browser/media/media_engagement_contents_observer_unittest.cc
[modify] https://crrev.com/7e7a83579b094f335c78bb05b19cd5c2901ae945/chrome/browser/media/media_engagement_score.h
[modify] https://crrev.com/7e7a83579b094f335c78bb05b19cd5c2901ae945/chrome/browser/media/media_engagement_score_unittest.cc
[modify] https://crrev.com/7e7a83579b094f335c78bb05b19cd5c2901ae945/chrome/test/data/media/engagement/engagement_test.js
[add] https://crrev.com/7e7a83579b094f335c78bb05b19cd5c2901ae945/chrome/test/data/media/engagement/engagement_test_multiple.html
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/71ad48fb8f214e80518ba0419796e4c571351255

commit 71ad48fb8f214e80518ba0419796e4c571351255
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Fri Nov 17 18:14:29 2017

[api] Mark MarkIndependent as soon deprecated

Persistent handles are always independent these days. Users should mark
weak handles as active using MarkActive if they want to keep weak
handles that are otherwise unreachable alive across scavenges.

Bug:  chromium:780749 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: I116e984ce14a035d1cef491d49f11a388fa8169d
Reviewed-on: https://chromium-review.googlesource.com/759794
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49456}
[modify] https://crrev.com/71ad48fb8f214e80518ba0419796e4c571351255/include/v8.h
[modify] https://crrev.com/71ad48fb8f214e80518ba0419796e4c571351255/src/d8.cc
[modify] https://crrev.com/71ad48fb8f214e80518ba0419796e4c571351255/test/cctest/test-api.cc
[modify] https://crrev.com/71ad48fb8f214e80518ba0419796e4c571351255/test/cctest/test-global-handles.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98ef6a7cd44e86c68e824020a0629cd57ffad725

commit 98ef6a7cd44e86c68e824020a0629cd57ffad725
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue Nov 21 12:56:58 2017

[bindings] Remove DependentLifetime from IDL

DependentLifetime is obsolete as
- A full V8 GC will use wrapper tracing and have correct lifetime
  information
- A minor V8 GC will rely on MarkActive to keep alive otherwise
  unreachable wrappers.

Bug:  chromium:780749 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I56b37da6b6b63934ad506149c680630d3dee5465
Reviewed-on: https://chromium-review.googlesource.com/778545
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518229}
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/IDLExtendedAttributes.md
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/scripts/compute_interfaces_info_overall.py
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/scripts/v8_interface.py
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/templates/legacy_callback_interface.cpp.tmpl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/idls/core/SVGTestInterface.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/idls/core/TestInterface.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/idls/core/TestInterface2.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/idls/core/TestInterfaceNamedConstructor.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/idls/modules/TestInterface5.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBuffer.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8DataView.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestAttributeGetters.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackFunctions.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEmpty.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventTarget.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceOriginTrialEnabled.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceSecureContext.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestLegacyCallbackInterface.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8TestVariadicConstructorArguments.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/core/V8Uint8ClampedArray.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInheritedLegacyUnenumerableNamedProperties.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/modules/V8TestNotEnumerableNamedGetter.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/bindings/tests/results/modules/V8TestSubObject.cpp
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/animation/Animation.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/css/CSSRule.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/css/CSSRuleList.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/css/CSSStyleRule.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/css/CSSStyleSheet.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/css/FontFace.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/css/FontFaceSet.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/css/MediaQueryList.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/css/StyleSheet.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/css/StyleSheetList.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/dom/DOMImplementation.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/dom/DOMStringMap.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/dom/DOMTokenList.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/dom/MessagePort.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/dom/MutationObserver.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/dom/NamedNodeMap.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/dom/Node.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/dom/NodeFilter.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/dom/NodeIterator.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/dom/NodeList.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/dom/TreeWalker.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/dom/events/CustomEvent.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/events/PromiseRejectionEvent.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/fileapi/FileReader.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/frame/Location.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/html/HTMLAllCollection.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/html/HTMLCollection.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/html/forms/HTMLFormControlsCollection.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/html/forms/HTMLOptionsCollection.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/html/media/HTMLMediaElement.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/html/track/AudioTrack.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/html/track/AudioTrackList.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/html/track/TextTrack.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/html/track/TextTrackCue.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/html/track/TextTrackList.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/html/track/VideoTrack.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/html/track/VideoTrackList.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/html/track/vtt/VTTCue.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/intersection_observer/IntersectionObserver.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/mojo/MojoWatcher.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/mojo/test/MojoInterfaceInterceptor.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/streams/UnderlyingSourceBase.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGAngle.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGAnimatedAngle.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGAnimatedBoolean.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGAnimatedEnumeration.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGAnimatedInteger.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGAnimatedLength.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGAnimatedLengthList.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGAnimatedNumber.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGAnimatedNumberList.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGAnimatedPreserveAspectRatio.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGAnimatedRect.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGAnimatedString.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGAnimatedTransformList.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGLength.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGLengthList.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGMatrix.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGNumber.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGNumberList.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGPoint.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGPointList.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGPreserveAspectRatio.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGRect.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGStringList.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGTransform.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGTransformList.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/svg/SVGUnitTypes.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/timing/PerformanceObserver.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/workers/SharedWorker.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/workers/Worker.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/workers/WorkerGlobalScope.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/workers/Worklet.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/workers/WorkletGlobalScope.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/battery/BatteryManager.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2D.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/canvas/imagebitmap/ImageBitmapRenderingContext.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/eventsource/EventSource.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/fetch/Body.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/fetch/Request.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/fetch/Response.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/filesystem/FileWriter.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/imagecapture/ImageCapture.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/indexeddb/IDBRequest.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/mediasession/MediaSession.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/mediasource/MediaSource.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/mediasource/SourceBuffer.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/mediastream/MediaDevices.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/netinfo/NetworkInformation.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/notifications/Notification.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/payments/PaymentManager.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/payments/PaymentRequest.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/permissions/PermissionStatus.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/presentation/PresentationAvailability.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/presentation/PresentationRequest.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/sensor/Sensor.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/speech/SpeechRecognition.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/vr/VRDisplay.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/webaudio/AudioContext.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.idl
[modify] https://crrev.com/98ef6a7cd44e86c68e824020a0629cd57ffad725/third_party/WebKit/Source/modules/webaudio/AudioWorkletNode.idl
[modify] https://crrev.com/98ef6a7
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/041d914dd09952e317cfb9e03c9f4dd080faaa62

commit 041d914dd09952e317cfb9e03c9f4dd080faaa62
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Wed Nov 22 09:21:32 2017

Remove left-over IsIndependent check

Bug:  chromium:780749 
Change-Id: Ia9f7c7fb5f011e5f2af93421eb11787778a84ff9
Reviewed-on: https://chromium-review.googlesource.com/783211
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518582}
[modify] https://crrev.com/041d914dd09952e317cfb9e03c9f4dd080faaa62/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0944553ee8498bda5b9897871e29c70e9c5ae00e

commit 0944553ee8498bda5b9897871e29c70e9c5ae00e
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Wed Nov 22 11:40:32 2017

Global handles: Remove independent handle infrastructure

Bug:  chromium:780749 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
Change-Id: I4c993e2147494795402f141049eed30801dfb913
Reviewed-on: https://chromium-review.googlesource.com/782519
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49568}
[modify] https://crrev.com/0944553ee8498bda5b9897871e29c70e9c5ae00e/include/v8.h
[modify] https://crrev.com/0944553ee8498bda5b9897871e29c70e9c5ae00e/src/global-handles.cc
[modify] https://crrev.com/0944553ee8498bda5b9897871e29c70e9c5ae00e/src/global-handles.h

Comment 10 by mlippautz@chromium.org, Nov 28 2017

Blockedon: 787446

Comment 11 by mlippautz@chromium.org, Feb 21 2018

Status: Fixed (was: Assigned)
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0c5096130bd991e6144c084b85a20927bb47010e

commit 0c5096130bd991e6144c084b85a20927bb47010e
Author: Ulan Degenbaev <ulan@chromium.org>
Date: Mon Jun 04 18:33:33 2018

Revert "Global handles: Remove independent handle infrastructure"

This reverts 0944553ee8498bda5b9897871e29c70e9c5ae00e.

This is a short-term fix for NodeJS regression caused by Scavenger
not collecting weak handles that are marked as independent.

Bug: chromium:847863,  chromium:780749 
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: Ibd5224893c64baef1aaaecd18af94f29e2e74487
Reviewed-on: https://chromium-review.googlesource.com/1082439
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53498}
[modify] https://crrev.com/0c5096130bd991e6144c084b85a20927bb47010e/include/v8.h
[modify] https://crrev.com/0c5096130bd991e6144c084b85a20927bb47010e/src/global-handles.cc
[modify] https://crrev.com/0c5096130bd991e6144c084b85a20927bb47010e/src/global-handles.h
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/aaa700bda4077d0f01db778052db598c097d5273

commit aaa700bda4077d0f01db778052db598c097d5273
Author: Ulan Degenbaev <ulan@chromium.org>
Date: Mon Jun 04 19:13:20 2018

Revert "[heap] Remove independent handles"

This reverts 667555c6b8dadcfe4e592fe06bb6846468b8141e.

This is a short-term fix for NodeJS regression caused by Scavenger
not collecting weak handles that are marked as independent.

Bug: chromium:847863,  chromium:780749 
Change-Id: Ia1c02e042d0e593c6f5badb82c4ef20b923d3806
Reviewed-on: https://chromium-review.googlesource.com/1082442
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53502}
[modify] https://crrev.com/aaa700bda4077d0f01db778052db598c097d5273/src/global-handles.cc
[modify] https://crrev.com/aaa700bda4077d0f01db778052db598c097d5273/src/profiler/sampling-heap-profiler.cc
[modify] https://crrev.com/aaa700bda4077d0f01db778052db598c097d5273/test/cctest/test-api.cc
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 7 2018

Labels: merge-merged-6.8
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ee8854c8cb0717b7cb63987e6ae9c554c829ebd0

commit ee8854c8cb0717b7cb63987e6ae9c554c829ebd0
Author: Ulan Degenbaev <ulan@chromium.org>
Date: Thu Jun 07 13:23:05 2018

Merged: Squashed multiple commits.

Merged: Revert "Global handles: Remove independent handle infrastructure"
Revision: 0c5096130bd991e6144c084b85a20927bb47010e

Merged: Revert "[heap] Remove independent handles"
Revision: aaa700bda4077d0f01db778052db598c097d5273

BUG= chromium:780749 ,chromium:847863
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=hablich@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: Ib0204cffc37c7a93dcbb2d1cf7b19e31346b5a15
Reviewed-on: https://chromium-review.googlesource.com/1090833
Reviewed-by: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.8@{#19}
Cr-Branched-From: 44d7d7d6b1041b57644400a00cb3fee35f6c51b2-refs/heads/6.8.275@{#1}
Cr-Branched-From: 5754f66f75136dc17b4c63fec84f31dfdb89186e-refs/heads/master@{#53286}
[modify] https://crrev.com/ee8854c8cb0717b7cb63987e6ae9c554c829ebd0/include/v8.h
[modify] https://crrev.com/ee8854c8cb0717b7cb63987e6ae9c554c829ebd0/src/global-handles.cc
[modify] https://crrev.com/ee8854c8cb0717b7cb63987e6ae9c554c829ebd0/src/global-handles.h
[modify] https://crrev.com/ee8854c8cb0717b7cb63987e6ae9c554c829ebd0/src/profiler/sampling-heap-profiler.cc
[modify] https://crrev.com/ee8854c8cb0717b7cb63987e6ae9c554c829ebd0/test/cctest/test-api.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 7 2018

Labels: merge-merged-6.7
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d89f1638856564ca66701ce64ffaf474522cd206

commit d89f1638856564ca66701ce64ffaf474522cd206
Author: Ulan Degenbaev <ulan@chromium.org>
Date: Thu Jun 07 13:30:57 2018

Merged: Squashed multiple commits.

Merged: Revert "Global handles: Remove independent handle infrastructure"
Revision: 0c5096130bd991e6144c084b85a20927bb47010e

Merged: Revert "[heap] Remove independent handles"
Revision: aaa700bda4077d0f01db778052db598c097d5273

BUG= chromium:780749 ,chromium:847863
LOG=N
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
R=hablich@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I0af773f9c130b85a58dd22204a2933a48a4a7b35
Reviewed-on: https://chromium-review.googlesource.com/1090843
Reviewed-by: Michael Hablich <hablich@chromium.org>
Cr-Commit-Position: refs/branch-heads/6.7@{#86}
Cr-Branched-From: 8457e810efd34381448d51d93f50079cf1f6a812-refs/heads/6.7.288@{#2}
Cr-Branched-From: e921be5c4f2c6407936bde750992dedbf47c1016-refs/heads/master@{#52547}
[modify] https://crrev.com/d89f1638856564ca66701ce64ffaf474522cd206/include/v8.h
[modify] https://crrev.com/d89f1638856564ca66701ce64ffaf474522cd206/src/global-handles.cc
[modify] https://crrev.com/d89f1638856564ca66701ce64ffaf474522cd206/src/global-handles.h
[modify] https://crrev.com/d89f1638856564ca66701ce64ffaf474522cd206/src/profiler/sampling-heap-profiler.cc
[modify] https://crrev.com/d89f1638856564ca66701ce64ffaf474522cd206/test/cctest/test-api.cc

Comment 16 by ofrobots@google.com, Jul 17

Labels: NodeJS-Backport-Done
►

Sign in to add a comment