Issue metadata
Sign in to add a comment
|
Regression:Lengthy lines are seen for Proxy connection type and for Name servers in network settings page |
||||||||||||||||||||||
Issue descriptionChrome Version: 64.0.3255.0/10090.0.0 dev channel Daisy,Candy,Reks OS:Chrome OS What steps will reproduce the problem? (1)Recover Build ->Connect to a network (2)In Ubertray,go to Network section ->click on Network Settings and Observe the drop-down of Proxy connection type (please refer screenshots) Actual:Lengthy lines are seen for of Proxy connection type and for Name servers Expected: No need of such unnecessary lengthy lines This is a Regression issue as same is working fine in 64.0.3249.0/10070.0.0 dev channel Candy Note: 1.Issue is not seen in Linux,Windows OS 2.Able to reproduce the issue chrome://settings/networkDetail page @stevenjb: Please confirm the issue.
,
Nov 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/976cee9b0930c8ab8824ab174f127973f4277ed8 commit 976cee9b0930c8ab8824ab174f127973f4277ed8 Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Nov 07 21:02:40 2017 Network config dialogs: UX feedback Changes (from issue 380937 ): >>> For in-settings dialogs: - dialog style: -- Icon removed from titles. -- Title font in stand alone dialog fixed (embedded dialog should already match) -- Padding changed to 16px to match other dialogs. -- Adjusted control heights to 58px, same as 'Add search engine' - The controls in previous mocks did not stretch to fit, I changed them to be flex. >>> For in-OS dialog -- Dialog title removed -- Dialog width fixed Bug: 380937 , 780710 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2068a9eefed9410e398b08966e89916220e74890 Reviewed-on: https://chromium-review.googlesource.com/748708 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#514580} [modify] https://crrev.com/976cee9b0930c8ab8824ab174f127973f4277ed8/chrome/browser/resources/chromeos/compiled_resources2.gyp [modify] https://crrev.com/976cee9b0930c8ab8824ab174f127973f4277ed8/chrome/browser/resources/chromeos/internet_config_dialog.html [modify] https://crrev.com/976cee9b0930c8ab8824ab174f127973f4277ed8/chrome/browser/resources/chromeos/internet_config_dialog.js [modify] https://crrev.com/976cee9b0930c8ab8824ab174f127973f4277ed8/chrome/browser/resources/settings/internet_page/internet_config.html [modify] https://crrev.com/976cee9b0930c8ab8824ab174f127973f4277ed8/chrome/browser/ui/webui/chromeos/internet_config_dialog.cc [modify] https://crrev.com/976cee9b0930c8ab8824ab174f127973f4277ed8/ui/webui/resources/cr_components/chromeos/network/network_config.html [modify] https://crrev.com/976cee9b0930c8ab8824ab174f127973f4277ed8/ui/webui/resources/cr_components/chromeos/network/network_config_input.html [modify] https://crrev.com/976cee9b0930c8ab8824ab174f127973f4277ed8/ui/webui/resources/cr_components/chromeos/network/network_config_select.html [modify] https://crrev.com/976cee9b0930c8ab8824ab174f127973f4277ed8/ui/webui/resources/cr_components/chromeos/network/network_shared_css.html
,
Nov 8 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Nov 2 2017