New issue
Advanced search Search tips

Issue 780692 link

Starred by 1 user
Status: Fixed
Owner:
h...@chromium.org
Closed: Nov 2017
Cc:
p...@chromium.org
inglorion@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 775171



Sign in to add a comment

ClangToT bots failing with -Wdeprecated-register

Project Member Reported by h...@chromium.org, Nov 2 2017 
For example:
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.clang%2FToTLinux%2F600%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

../../third_party/breakpad/breakpad/src/common/dwarf/dwarf2reader.cc:1273:43: error: 'register' storage class specifier is deprecated and incompatible with C++17 [-Werror,-Wdeprecated-register]
                      uint64 address, int register) const = 0;
                                          ^~~~~~~~

https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.clang%2FToTWin%2F293%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout


In file included from ../../third_party/pdfium/core/fpdfapi/page/cpdf_iccprofile.cpp:11:
In file included from ../../third_party/pdfium\core/fxcodec/codec/ccodec_iccmodule.h:20:
../../third_party/pdfium\third_party/lcms/include/lcms2.h(1242,44):  error: 'register' storage class specifier is deprecated and incompatible with C++17 [-Werror,-Wdeprecated-register]
typedef cmsInt32Number (* cmsSAMPLER16)   (register const cmsUInt16Number In[],
                                           ^~~~~~~~~
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/breakpad/breakpad/+/2d85d492aeb9eeb889885e84b3666d64407f2920

commit 2d85d492aeb9eeb889885e84b3666d64407f2920
Author: Peter Collingbourne <pcc@google.com>
Date: Thu Nov 02 02:40:39 2017

Rename an argument named "register" to "reg".

This silences a warning in newer versions of clang that complains
about "register" being a deprecated keyword.

Bug:  chromium:780692 
Change-Id: If354b9b18421e3e910849b385c44207e0ce02590
Reviewed-on: https://chromium-review.googlesource.com/750362
Reviewed-by: Mark Mentovai <mark@chromium.org>

[modify] https://crrev.com/2d85d492aeb9eeb889885e84b3666d64407f2920/src/common/dwarf/dwarf2reader.cc

Comment 3 by h...@chromium.org, Nov 2 2017

Status: Started (was: Available)
This is due to Clang r317140: "Fix missing -Wregister warning when 'register' is applied to a function parameter"

Comment 4 by h...@chromium.org, Nov 2 2017

Owner: h...@chromium.org
A few more in Blink: https://chromium-review.googlesource.com/c/chromium/src/+/750334

With this, pcc's breakpad change and the pdfium change, I've completed a full debug build on Linux.

Comment 6 by h...@chromium.org, Nov 2 2017 

pdfium was rolled here: https://chromium-review.googlesource.com/750113
pcc is rolling breakpad here: https://chromium-review.googlesource.com/c/chromium/src/+/750591
The Blink change is in the cq.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/045adde9132e491c78ec7a1b13686f6ef8dd44c0

commit 045adde9132e491c78ec7a1b13686f6ef8dd44c0
Author: Hans Wennborg <hans@chromium.org>
Date: Thu Nov 02 14:34:13 2017

Remove uses of the deprecated 'register' keyword

Bug:  780692 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I846975cec64e6bffe756b594b107c9cba315ac80
Reviewed-on: https://chromium-review.googlesource.com/750334
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513485}
[modify] https://crrev.com/045adde9132e491c78ec7a1b13686f6ef8dd44c0/third_party/WebKit/Source/core/css/HashTools.h
[modify] https://crrev.com/045adde9132e491c78ec7a1b13686f6ef8dd44c0/third_party/WebKit/Source/platform/graphics/Color.h
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/431b7020462e52bd819171cc7b4c6cf3928f32d7

commit 431b7020462e52bd819171cc7b4c6cf3928f32d7
Author: Hans Wennborg <hans@chromium.org>
Date: Thu Nov 02 17:30:27 2017

Roll src/third_party/breakpad/breakpad/ 072f86ca8..2d85d492a (5 commits)

https://chromium.googlesource.com/breakpad/breakpad.git/+log/072f86ca83bb..2d85d492aeb9

$ git log 072f86ca8..2d85d492a --date=short --no-merges --format='%ad %ae %s'
2017-11-01 pcc Rename an argument named "register" to "reg".
2017-10-27 baldwinn Fix double declaration of tgkill when using Android NDK Headers.
2017-10-27 jswang Create LongStringDictionary and replace SimpleStringDictionary usages in client/ios/Breakpad.mm.
2017-10-26 brucedawson Avoid skipping an initializer with a goto
2017-10-19 torne Roll src/src/third_party/lss/ a91633d17..e6527b0cd (1 commit)

Created with:
  roll-dep src/third_party/breakpad/breakpad

Bug:  780692 
Change-Id: Ib84e5c2f6e62dca1cff94cb4f9fb9c48b3d36247
Reviewed-on: https://chromium-review.googlesource.com/750591
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513537}
[modify] https://crrev.com/431b7020462e52bd819171cc7b4c6cf3928f32d7/DEPS
[modify] https://crrev.com/431b7020462e52bd819171cc7b4c6cf3928f32d7/third_party/breakpad/BUILD.gn
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e2b01bbc0f3800eb7ac9b3454721ee89dae20e1

commit 6e2b01bbc0f3800eb7ac9b3454721ee89dae20e1
Author: Sky Malice <skym@chromium.org>
Date: Thu Nov 02 17:43:12 2017

Revert "Roll src/third_party/breakpad/breakpad/ 072f86ca8..2d85d492a (5 commits)"

This reverts commit 431b7020462e52bd819171cc7b4c6cf3928f32d7.

Reason for revert: Causing ios-device to fail to compile.

Original change's description:
> Roll src/third_party/breakpad/breakpad/ 072f86ca8..2d85d492a (5 commits)
> 
> https://chromium.googlesource.com/breakpad/breakpad.git/+log/072f86ca83bb..2d85d492aeb9
> 
> $ git log 072f86ca8..2d85d492a --date=short --no-merges --format='%ad %ae %s'
> 2017-11-01 pcc Rename an argument named "register" to "reg".
> 2017-10-27 baldwinn Fix double declaration of tgkill when using Android NDK Headers.
> 2017-10-27 jswang Create LongStringDictionary and replace SimpleStringDictionary usages in client/ios/Breakpad.mm.
> 2017-10-26 brucedawson Avoid skipping an initializer with a goto
> 2017-10-19 torne Roll src/src/third_party/lss/ a91633d17..e6527b0cd (1 commit)
> 
> Created with:
>   roll-dep src/third_party/breakpad/breakpad
> 
> Bug:  780692 
> Change-Id: Ib84e5c2f6e62dca1cff94cb4f9fb9c48b3d36247
> Reviewed-on: https://chromium-review.googlesource.com/750591
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Reviewed-by: Peter Collingbourne <pcc@chromium.org>
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#513537}

TBR=hans@chromium.org,pcc@chromium.org,mark@chromium.org

Change-Id: Id1bf99919293969a36021db25ebbefc1854ccb9f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  780692 
Reviewed-on: https://chromium-review.googlesource.com/751822
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513539}
[modify] https://crrev.com/6e2b01bbc0f3800eb7ac9b3454721ee89dae20e1/DEPS
[modify] https://crrev.com/6e2b01bbc0f3800eb7ac9b3454721ee89dae20e1/third_party/breakpad/BUILD.gn
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af9880c57ae006a812629ad2b099491260c21185

commit af9880c57ae006a812629ad2b099491260c21185
Author: Hans Wennborg <hans@chromium.org>
Date: Thu Nov 02 19:55:51 2017

Roll src/third_party/breakpad/breakpad/ 072f86ca8..5dad29423 (6 commits)

https://chromium.googlesource.com/breakpad/breakpad.git/+log/072f86ca83bb..5dad29423e62

$ git log 072f86ca8..5dad29423 --date=short --no-merges --format='%ad %ae %s'
2017-11-02 mark Revert "Create LongStringDictionary and replace SimpleStringDictionary usages in client/ios/Breakpad.mm."
2017-11-01 pcc Rename an argument named "register" to "reg".
2017-10-27 baldwinn Fix double declaration of tgkill when using Android NDK Headers.
2017-10-27 jswang Create LongStringDictionary and replace SimpleStringDictionary usages in client/ios/Breakpad.mm.
2017-10-26 brucedawson Avoid skipping an initializer with a goto
2017-10-19 torne Roll src/src/third_party/lss/ a91633d17..e6527b0cd (1 commit)

Created with:
  roll-dep src/third_party/breakpad/breakpad

Bug:  780692 
Change-Id: Ifd8822f7a45d647696f695fac6f47cb44fd5c30f
Reviewed-on: https://chromium-review.googlesource.com/751902
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513587}
[modify] https://crrev.com/af9880c57ae006a812629ad2b099491260c21185/DEPS

Comment 12 by h...@chromium.org, Nov 3 2017

Status: Fixed (was: Started)
►

Sign in to add a comment