Get rid of CreateFromNormalizedTupleWithSuborigin use in reporting_persister.cc |
|||
Issue descriptionreporting_persister.cc serializes the origin by getting the tuple parts and saving them out. It reconstitutes it by calling https://cs.chromium.org/chromium/src/net/reporting/reporting_persister.cc?rcl=487b6616f10eff5f5d0d8805668bb80870342e0b&l=58 to reconstitute the origin. However, I'd like to keep non-url/origin code from using this helper method; it's unclear what the persistence requirements are, but it might be better if we could change this to use url::Origin::Serialize() + url::Origin::Create(GURL(serialized_form)). Would it be the end of the world to make a non-backwards compatible change here and drop old reports? The rationale is I'd like to add some DCHECKs that certain things don't happen (i.e. CreateFromNormalizedTupleWithSuborigin should never create an opaque origin), but external consumers such as the reporting pipeline can easily break that.
,
Nov 2 2017
Absolutely fine -- the persister isn't actually wired up to anything yet. Let me know if you want me to do it or if you'd prefer to.
,
Nov 2 2017
Thanks for the info, I'm happy to make the change.
,
Feb 28 2018
The code in question was removed by https://chromium-review.googlesource.com/c/chromium/src/+/797852/4/net/reporting/reporting_persister.cc. |
|||
►
Sign in to add a comment |
|||
Comment 1 by dcheng@chromium.org
, Nov 2 2017