New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780671 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Organize file related methods in tests into file_test_utils

Project Member Reported by romax@chromium.org, Nov 2 2017

Issue description

Currently, offline_pages/core/model/*_unittest.cc are duplicating file-related test utility functions:
GetFileCountInDir(),
FileExists(),
etc...

Investigate and see if there're benefits to reorganize them into a test_file_utils namespace(?) in offline_pages::.
 

Comment 1 by romax@chromium.org, Apr 12 2018

Status: WontFix (was: Assigned)
the GetFileCountInDir has been moved to test_utils.
FileExists are replaced by direct call to base::PathExists.
And now we have task_test_base, so closing as won't fix

Sign in to add a comment