New issue
Advanced search Search tips

Issue 780644 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Make Aura's pull-to-refresh activation threshold more prominent

Project Member Reported by moh...@chromium.org, Nov 1 2017

Issue description

Currently, when user tries to perform pull-to-refresh gesture on a page, it's not very clear when we pass the activation threshold. There are a few things that might help:

1) The PTR arrow is fully opaque during the interaction. Similar to overscroll-nav arrow, we can fade in the arrow slowly and bump the opacity close to the activation threshold so the threshold is more prominent.

2) The arrow rotates 90 degrees to reach the threshold. Probably, if we increase it (e.g. to 180 degrees or so), the rotation would be faster and more noticeable to the user.
 
Cc: -sgabr...@chromium.org
Owner: sgabr...@chromium.org
Status: Assigned (was: Available)
sgabriel@: What do you think about the suggestions in the bug description? Any other idea to make the transition past the threshold more visible?
These suggestions sounds good to me let's try that out :)
Cc: sgabr...@chromium.org
Owner: moh...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/80e8d72218832d15492897816c5b5cc2303ba965

commit 80e8d72218832d15492897816c5b5cc2303ba965
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Sat Nov 04 02:07:55 2017

Add fade-in and more rotation to pull-to-refresh arrow

This is to make the arrow more noticeable, especially when passes the
activation threshold.

BUG= 780644 
TEST=manual

Change-Id: Ifa6ebcbd1564bfcebb184bd22dce03b9e321baf7
Reviewed-on: https://chromium-review.googlesource.com/751405
Reviewed-by: Mikhail Fomitchev <mfomitchev@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514013}
[modify] https://crrev.com/80e8d72218832d15492897816c5b5cc2303ba965/content/browser/web_contents/aura/gesture_nav_simple.cc

sgabriel@, hwi@: This change has landed in Canary. Please give it a try and let me know what you think about the new arrow rotation and fade-in.

PS: Now that arrow fades in, we can probably continue arrow rotation after activation threshold to make it look more similar to Clank and Android in general. WDYT?

Comment 6 by hwi@chromium.org, Nov 9 2017

mohsen@ and sgabriel@ - could you help me understand why the fav continues to move after passing the activation point? It makes me feel unclear when to stop moving and release the fingers and how far to go back to cancel the action. 

Thanks!
re:#5. Yes it's weird that it stop now, let's mimick Android there and continue the rotation

re:#6. There's a "Stretch zone" build-in to have the icon respond better and more naturally to touch, just like on handheld

Comment 8 by hwi@chromium.org, Nov 9 2017

re:#5-7, the proposed refinements sgtm.
Cc: -mfomitchev@chromium.org
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3189913a90cfcb72f5c9b35719d91082b8a2138d

commit 3189913a90cfcb72f5c9b35719d91082b8a2138d
Author: Mohsen Izadi <mohsen@chromium.org>
Date: Thu Nov 23 19:52:58 2017

Continue pull-to-refresh arrow rotation after activation threshold

This will mimic Clank and Android's pull-to-refresh behavior in this
regard.

BUG= 780644 
TEST=manual

Change-Id: I9cd38dc620bc3819feb6e600b47cb06c28c03036
Reviewed-on: https://chromium-review.googlesource.com/779885
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519008}
[modify] https://crrev.com/3189913a90cfcb72f5c9b35719d91082b8a2138d/content/browser/web_contents/aura/gesture_nav_simple.cc

Cc: -moh...@chromium.org
Status: Fixed (was: Started)

Sign in to add a comment