Mash: Implent CursorManagerTestApi |
||||
Issue descriptionThe following ash unittests rely on CursorManagerTestApi: ash/display/mirror_window_controller_unittest.cc ash/display/mouse_cursor_event_filter_unittest.cc ash/display/window_tree_host_manager_unittest.cc ash/wm/drag_window_resizer_unittest.cc ash/wm/resize_shadow_and_cursor_unittest It seems like disabling these tests is incorrect, we should probably modify CursorManagerTestApi to not rely on a global ::wm::CursorManager* in its constructor but instead construct and implement it for mash.
,
Jan 24 2018
,
Feb 21 2018
Some of the disabled tests (for searchability): -WindowManagerTest.ActivateOnMouse -WindowManagerTest.ActivateOnPointerWindowProperty -WindowManagerTest.ActivateOnTouch -WindowManagerTest.AdditionalFilters -WindowManagerTest.Focus -WindowManagerTest.MouseEventCursors -WindowManagerTest.PanelActivation -WindowManagerTest.TestCursorClientObserver -WindowManagerTest.TransformActivate -WindowManagerTest.UpdateCursorVisibility -WindowManagerTest.UpdateCursorVisibilityAccelerator -WindowManagerTest.UpdateCursorVisibilityOnKeyEvent -WindowTreeHostManagerTest.DontUpdateInvisibleCursorLocationAfterDisplayChange -WindowTreeHostManagerTest.UpdateMouseLocationAfterDisplayChange -WindowTreeHostManagerTest.UpdateMouseLocationAfterDisplayChange_2ndOnLeft -WindowTreeHostManagerTest.UpdateMouseLocationAfterDisplayChange_PrimaryDisconnected -WindowTreeHostManagerTest.UpdateMouseLocationAfterDisplayChange_SwapPrimary -WorkspaceWindowResizerTest.MouseMoveWithTouchDrag
,
Mar 9 2018
Un-cc-ing me from all bugs on my final day.
,
Apr 19 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dpranke@chromium.org
, Jan 24 2018