Issue metadata
Sign in to add a comment
|
SecureShell [New tab] option does not open a new tab from Launcher |
||||||||||||||||||||||
Issue descriptionChrome Version: 64.0.3255.0 Steps To Reproduce: (1) Install and pin SecureShell app (2) Run it to create at least one tab (3) Try to to select [New tab] in its pop-up menu from the shelf (4) Try to to select [New tab] in its pop-up menu from the launcher Expected Result: Both (3) and (4) should open a new tab. Actual Result: (4) select existing tab instead of opening a new one like (3) How frequently does this problem reproduce? (Always, sometimes, hard to reproduce?) 100%
,
Nov 7 2017
I recommend using QTCreator as a debugger, and run "CrOS" on your Linux Machine, not on the device.
You'll face an interesting choice of a quick-and-dirty solution and unifying the code between Launcher and Shelf. At this stage, the second seems to be more beneficial, but might depend on Launcher UI migration into Ash process, aka mus+ash. You'll see :)
Opening from Shelf:
1 chrome::Navigate browser_navigator.cc 409 0x1070f555f
2 (anonymous namespace)::OpenApplicationTab application_launch.cc 303 0x1075c011f
3 (anonymous namespace)::OpenEnabledApplication application_launch.cc 360 0x1075bed91
4 OpenApplication application_launch.cc 392 0x1075bea75
5 LauncherControllerHelper::LaunchApp launcher_controller_helper.cc 215 0x1072db003
6 ChromeLauncherController::LaunchApp chrome_launcher_controller.cc 405 0x1072c0783
7 LauncherContextMenu::ExecuteCommand launcher_context_menu.cc 73 0x10776586c
8 LauncherContextMenu::ExecuteCommonCommand launcher_context_menu.cc 131 0x107765d1d
9 ExtensionLauncherContextMenu::ExecuteCommand extension_launcher_context_menu.cc 153 0x10797d663
10 ui::SimpleMenuModel::ActivatedAt simple_menu_model.cc 388 0x7ffff7440ffd
11 ash::ShelfItemDelegate::ExecuteContextMenuCommand shelf_item_delegate.cc 73 0x7fffe8404dba
12 AppShortcutLauncherItemController::ExecuteCommand app_shortcut_launcher_item_controller.cc 142 0x107758738
Open from Launcher (for the first tab. For the second one, AppShortcutLauncherItemController::ItemSelected() will go to std::move(callback).Run(
ash::SHELF_ACTION_NONE,
GetAppMenuItems(event ? event->flags() : ui::EF_NONE)); branch and NOT open the tab).
1 chrome::Navigate browser_navigator.cc 409 0x1070f555f
2 (anonymous namespace)::OpenApplicationTab application_launch.cc 303 0x1075c011f
3 (anonymous namespace)::OpenEnabledApplication application_launch.cc 360 0x1075bed91
4 OpenApplication application_launch.cc 392 0x1075bea75
5 LauncherControllerHelper::LaunchApp launcher_controller_helper.cc 215 0x1072db003
6 ChromeLauncherController::LaunchApp chrome_launcher_controller.cc 405 0x1072c0783
7 AppShortcutLauncherItemController::ItemSelected(std::unique_ptr<ui::Event, std::default_delete<ui::Event>>, long, ash::ShelfLaunchSource, base::OnceCallback<void (ash::ShelfAction, base::Optional<std::vector<mojo::StructPtr<ash::mojom::MenuItem>>>)>) app_shortcut_launcher_item_controller.cc 105 0x1077566c5
8 (anonymous namespace)::SelectItemWithSource chrome_launcher_controller.cc 103 0x1072c0b9c
9 ChromeLauncherController::ActivateApp chrome_launcher_controller.cc 415 0x1072c08e8
10 AppListControllerDelegateAsh::ActivateApp app_list_controller_ash.cc 103 0x10773b60e
11 app_list::ExtensionAppResult::Open extension_app_result.cc 73 0x1078f7b3f
12 app_list::ExtensionAppResult::ExecuteLaunchCommand extension_app_result.cc 134 0x1078f84df
13 app_list::ExtensionAppContextMenu::ExecuteCommand extension_app_context_menu.cc 204 0x1078d82c5
14 ui::SimpleMenuModel::ActivatedAt simple_menu_model.cc 388 0x7ffff7440ffd
15 views::MenuModelAdapter::ExecuteCommand menu_model_adapter.cc 154 0x7fffe9c647f4
16
,
Aug 1
,
Aug 28
Issue 781492 has been merged into this issue.
,
Oct 6
,
Oct 18
This does not repro on ToT M72, both steps 3 and 4 create a new tab. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vadimt@chromium.org
, Nov 2 2017