New issue
Advanced search Search tips

Issue 780622 link

Starred by 1 user
Status: Fixed
Owner:
nedngu...@google.com
Closed: Nov 2017
Cc:
perezju@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

network_controller_backend state is not cleaned up properly upon failure

Project Member Reported by nedngu...@google.com, Nov 1 2017 
In log https://chromium-swarm.appspot.com/task?id=398e4116e0d5bb10&refresh=10&show_raw=1,
there are tons of assertion error as follow:

File "e:\b\swarm_slave\w\ir\third_party\catapult\telemetry\telemetry\internal\platform\network_controller_backend.py", line 52, in InitializeIfNeeded
      assert bool(self._ts_proxy_server) == bool(self._forwarder)
  AssertionError



I think this is happening because the first network initialization failed & network_controller_backend wasn't cleaned up properly. Hence subsequent call to this always fail this assertion.

Comment 2 by nedngu...@google.com, Nov 3 2017

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/50f7e11a3e9fa43ea02c0204b9e5ded33afaf511

commit 50f7e11a3e9fa43ea02c0204b9e5ded33afaf511
Author: Annie Sullivan <sullivan@chromium.org>
Date: Fri Nov 03 21:05:45 2017

Revert "Fix reinit after failure"

This reverts commit 312f525336d2232b21bb60956fa29f2abe0ed87a.

Reason for revert: Suspect this CL of causing autoroll failures. The autoroll with just this CL in it failed multiple times (https://chromium-review.googlesource.com/c/chromium/src/+/753421, https://chromium-review.googlesource.com/c/chromium/src/+/753528) and the failures are about "ImportError: cannot import name fakes": https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2Fmac_chromium_rel_ng%2F581101%2F%2B%2Frecipes%2Fsteps%2Ftelemetry_gpu_unittests__with_patch_%2F0%2Fstdout

Original change's description:
> Fix reinit after failure
> 
> Bug:  chromium:780622 
> Change-Id: I3fab7cf609bb73dee4330663c3bb98ff945482bf
> Reviewed-on: https://chromium-review.googlesource.com/749628
> Commit-Queue: Ned Nguyen <nednguyen@google.com>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>

TBR=perezju@chromium.org,nednguyen@google.com

Change-Id: I6e09b561a22039bf9c8747cc2d07a94bfbddf7d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:780622 
Reviewed-on: https://chromium-review.googlesource.com/754046
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>

[modify] https://crrev.com/50f7e11a3e9fa43ea02c0204b9e5ded33afaf511/telemetry/telemetry/testing/fakes/__init__.py
[modify] https://crrev.com/50f7e11a3e9fa43ea02c0204b9e5ded33afaf511/telemetry/telemetry/internal/platform/network_controller_backend.py
[delete] https://crrev.com/8e036faef710ffec58adb1046cd8825205d57f57/telemetry/telemetry/internal/platform/network_controller_backend_unittest.py

Comment 4 by nedngu...@google.com, Nov 3 2017

Status: Started (was: Fixed)

Comment 5 by nedngu...@google.com, Nov 9 2017

Status: Fixed (was: Started)
This is relanded in https://chromium-review.googlesource.com/c/catapult/+/759021

Comment 6 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 7 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry
►

Sign in to add a comment