High number of VIEW/.Main intents not dispatched by CTA.onNewIntents |
||||||||||
Issue descriptionAndroid.MainActivity.ExplicitMainViewIntentDispatched.OnNewIntent shows that 30% of VIEW intents with explicit com.google.android.apps.chrome.Main class are not dispatched as CCT intents. We found that Chrome sends com.google.android.apps.chrome.Main intents in IntentHandler.startChromeLauncherActivityForTrustedIntent(). We need to change TAB_ACTIVITY_COMPONENT_CLASS_NAME to com.google.android.apps.chrome.IntentDispatcher in order to get correct picture of external VIEW/.Main intents.
,
Nov 2 2017
Hey dskiba@, is this critical enough to be merged into M63 release branch? If it is just about getting a better understanding of explicit VIEW intents in beta, do you plan to disable it before M63 goes to stable?
,
Nov 2 2017
Yes, we need to merge this. This serves two critical functions: 1) It ensures Chrome code path that dispatches the VIEW intents functions correctly. 2) This is the only way we can check that this issue accounts for all of the histogram hits and there aren't any other issues in the wild we're hitting. This change is small and quite safe. It will not need to be disabled -- this is a permanent change.
,
Nov 2 2017
,
Nov 2 2017
The bug is marked as P3 or Feature. It should not be merged as M63 is in beta. Please contact the approriate milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 2 2017
,
Nov 2 2017
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 3 2017
Merge approved. Please make sure to verify the change branch 3239 after merging it.
,
Nov 3 2017
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 6 2017
My bad!
,
Nov 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d4c7bd46771face53a4413cfc064a4cb9fb8c2b commit 1d4c7bd46771face53a4413cfc064a4cb9fb8c2b Author: Dmitry Skiba <dskiba@chromium.org> Date: Mon Nov 06 17:48:45 2017 [Merge to M63] Don't send internal VIEW intents to .Main alias. .Main activity alias points to ChromeTabbedActivity, but its VIEW intent dispatching code is temporary and only handles CCT intents. This CL changes IntentHandler to send intents to .IntentDispatcher alias, which does proper dispatching. Bug: 780619 Change-Id: I12253656171f867df3478b1984ab8fc27ca66e3f Reviewed-on: https://chromium-review.googlesource.com/750254 Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#513551}(cherry picked from commit af78fa9e4ea9f41ee0bf2b079de71cc82c006649) Reviewed-on: https://chromium-review.googlesource.com/755073 Reviewed-by: Dmitry Skiba <dskiba@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#388} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/1d4c7bd46771face53a4413cfc064a4cb9fb8c2b/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java
,
Nov 6 2017
,
Nov 15 2017
The number of VIEW intents not dispatched by onNewIntent() dropped to 17% in 63.0.3239.41. We might need to dig more on this (in a separate issue).
,
Nov 29 2017
Follow up: issue 789732. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, Nov 2 2017