Issue metadata
Sign in to add a comment
|
net_perftests failing on multiple builders |
||||||||||||||||||||||
Issue descriptionnet_perftests failing on multiple builders Builders failed on: - Linux Perf: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf - Mac 10.12 Perf: https://build.chromium.org/p/chromium.perf/builders/Mac%2010.12%20Perf Example output: https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2FLinux_Perf%2F1940%2F%2B%2Frecipes%2Fsteps%2Fnet_perftests_on_NVIDIA_GPU_on_Linux%2F0%2Fstdout [ RUN ] DiskCachePerfTest.BlockfileHashes Hash disk cache keys 1003.83 ms Received signal 11 SEGV_MAPERR 000000000068 #0 0x000000bd9857 (/b/s/w/ir/out/Release/net_perftests+0x9d9856) r8: 00007f8a0de08840 r9: 0000000000000007 r10: 00007f8a0c19d6a0 r11: 0000000000000000 r12: 00001a3c5329be10 r13: 00001a3c53288200 r14: 00001a3c532817e0 r15: 0000000000056fe6 di: 00001a3c532a5440 si: 00007f8a0c1a09e0 bp: 0000000059f33b5a bx: 00001a3c532a5440 dx: 0000000000000000 ax: 0000000000000000 cx: 00007f8a0becb3ad sp: 00007fff03e301f8 ip: 0000000000bce637 efl: 0000000000010206 cgf: 0000000000000033 erf: 0000000000000004 trp: 000000000000000e msk: 0000000000000000 cr2: 0000000000000068 [end of stack trace] Calling _exit(1). Core file will not be generated. I'll kick off a bisect.
,
Nov 1 2017
😿 Pinpoint job stopped with an error. https://pinpoint-dot-chromeperf.appspot.com/job/14f47252f80000
,
Nov 2 2017
Thanks! I will take a look at this tomorrow.
,
Nov 2 2017
DiskCachePerfTest.BlockfileHashes is failing on both linux and mac. +morlovich@: any recent changes? Could you take a look?
,
Nov 2 2017
Will take a look. Not much to this test, though, so it has like 50% chance of being some base:: thing:
TEST_F(DiskCachePerfTest, BlockfileHashes) {
base::PerfTimeLogger timer("Hash disk cache keys");
for (int i = 0; i < 300000; i++) {
std::string key = GenerateKey(true);
base::Hash(key);
}
timer.Done();
}
,
Nov 2 2017
Hah: [14397:14397:1102/094734.480743:606068793460:FATAL:net_test_suite.cc(51)] Check failed: g_current_net_test_suite. Make it "90% chance of being my change to the test fixture".
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/369c8f14d70b1772b1d5e9b50cf012eb09d54016 commit 369c8f14d70b1772b1d5e9b50cf012eb09d54016 Author: Maks Orlovich <morlovich@chromium.org> Date: Thu Nov 02 16:22:10 2017 disk_cache_test_base: permit injecting ScopedTaskEnvironment ... rather than assuming that NetTestSuite exists, which it doesn't in net_perftests, which use PerfTestSuite instead. Bug: 780616 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I858c7257f75411efcea39d9e03d72b0159ac679b Reviewed-on: https://chromium-review.googlesource.com/750389 Reviewed-by: Helen Li <xunjieli@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#513507} [modify] https://crrev.com/369c8f14d70b1772b1d5e9b50cf012eb09d54016/net/disk_cache/disk_cache_perftest.cc [modify] https://crrev.com/369c8f14d70b1772b1d5e9b50cf012eb09d54016/net/disk_cache/disk_cache_test_base.cc [modify] https://crrev.com/369c8f14d70b1772b1d5e9b50cf012eb09d54016/net/disk_cache/disk_cache_test_base.h
,
Nov 3 2017
Last 3 builds on both bot have net_perftests green. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Nov 1 2017