New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 780615 link

Starred by 1 user
Status: Fixed
Owner:
█ thanhdle@chromium.org
Last visit > 30 days ago
Closed: Nov 2017
Cc:
ryansturm@chromium.org
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Log to chrome://interventions-internals page which type of previews is served

Project Member Reported by thanhdle@chromium.org, Nov 1 2017 
Right now the type of previews is served only logged when the user opt out by dismissing the info bar, or the navigation is finished.

It would be nice to log which type of previews is served on the page. An easy way is to log the message whenever the infobar is created, and use the infobar's previews type to see which type of previews is it.

Comment 1 by thanhdle@chromium.org, Nov 1 2017

Labels: -Type-Bug Type-Feature
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e92ed7022d5c96a608f686c72e57a9c6577a048

commit 7e92ed7022d5c96a608f686c72e57a9c6577a048
Author: Thanh Le <thanhdle@chromium.org>
Date: Fri Nov 03 16:38:58 2017

Added InfoBar event to chrome://interventions-internals.

A new event log is added to the page, showing which type of previews
info bar is displayed on the page. This is an indication of which type
of preview is served on the page.

Bug:  780615 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib1399f9a1979e6124a6f099f351dd63f9db740ac
Reviewed-on: https://chromium-review.googlesource.com/749671
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513800}
[modify] https://crrev.com/7e92ed7022d5c96a608f686c72e57a9c6577a048/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
[modify] https://crrev.com/7e92ed7022d5c96a608f686c72e57a9c6577a048/chrome/browser/previews/previews_infobar_delegate.cc
[modify] https://crrev.com/7e92ed7022d5c96a608f686c72e57a9c6577a048/chrome/browser/previews/previews_infobar_delegate.h
[modify] https://crrev.com/7e92ed7022d5c96a608f686c72e57a9c6577a048/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/7e92ed7022d5c96a608f686c72e57a9c6577a048/chrome/browser/previews/previews_infobar_tab_helper.cc
[modify] https://crrev.com/7e92ed7022d5c96a608f686c72e57a9c6577a048/chrome/browser/resources/interventions_internals/index.js
[modify] https://crrev.com/7e92ed7022d5c96a608f686c72e57a9c6577a048/components/previews/core/previews_logger.cc
[modify] https://crrev.com/7e92ed7022d5c96a608f686c72e57a9c6577a048/components/previews/core/previews_logger.h

Comment 3 by thanhdle@chromium.org, Nov 3 2017

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cb24dcd23fcdf4f7104b9a10ba95ee6f492074f

commit 3cb24dcd23fcdf4f7104b9a10ba95ee6f492074f
Author: meade_UTC10 <meade@chromium.org>
Date: Mon Nov 06 02:04:03 2017

Revert "Added InfoBar event to chrome://interventions-internals."

This reverts commit 7e92ed7022d5c96a608f686c72e57a9c6577a048.

Reason for revert: Breaks PreviewsInfoBarDelegateUnitTest on win7 builder. First breakage on https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64447

Original change's description:
> Added InfoBar event to chrome://interventions-internals.
> 
> A new event log is added to the page, showing which type of previews
> info bar is displayed on the page. This is an indication of which type
> of preview is served on the page.
> 
> Bug:  780615 
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: Ib1399f9a1979e6124a6f099f351dd63f9db740ac
> Reviewed-on: https://chromium-review.googlesource.com/749671
> Commit-Queue: Thanh Le <thanhdle@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#513800}

TBR=tbansal@chromium.org,ryansturm@chromium.org,thanhdle@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  780615 
Change-Id: I2703cae91df6e86290e1a6d25ac3212e7e0c8777
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/754641
Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514078}
[modify] https://crrev.com/3cb24dcd23fcdf4f7104b9a10ba95ee6f492074f/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
[modify] https://crrev.com/3cb24dcd23fcdf4f7104b9a10ba95ee6f492074f/chrome/browser/previews/previews_infobar_delegate.cc
[modify] https://crrev.com/3cb24dcd23fcdf4f7104b9a10ba95ee6f492074f/chrome/browser/previews/previews_infobar_delegate.h
[modify] https://crrev.com/3cb24dcd23fcdf4f7104b9a10ba95ee6f492074f/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/3cb24dcd23fcdf4f7104b9a10ba95ee6f492074f/chrome/browser/previews/previews_infobar_tab_helper.cc
[modify] https://crrev.com/3cb24dcd23fcdf4f7104b9a10ba95ee6f492074f/chrome/browser/resources/interventions_internals/index.js
[modify] https://crrev.com/3cb24dcd23fcdf4f7104b9a10ba95ee6f492074f/components/previews/core/previews_logger.cc
[modify] https://crrev.com/3cb24dcd23fcdf4f7104b9a10ba95ee6f492074f/components/previews/core/previews_logger.h
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec22d7ca95cfab76cf4e3615375397e8f07d9d20

commit ec22d7ca95cfab76cf4e3615375397e8f07d9d20
Author: Thanh Le <thanhdle@chromium.org>
Date: Tue Nov 07 19:56:20 2017

Reland "Added InfoBar event to chrome://interventions-internals."

A new event log is added to the page, showing which type of previews
info bar is displayed on the page. This is an indication of which type
of preview is served on the page.

Fixed previews_infobar_delegate_unittest PreviewsIOData mocking.

Bug:  780615 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic5a32e3fec73d5ad930973e35ac0fe82afc61d24
Reviewed-on: https://chromium-review.googlesource.com/755545
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514553}
[modify] https://crrev.com/ec22d7ca95cfab76cf4e3615375397e8f07d9d20/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
[modify] https://crrev.com/ec22d7ca95cfab76cf4e3615375397e8f07d9d20/chrome/browser/previews/previews_infobar_delegate.cc
[modify] https://crrev.com/ec22d7ca95cfab76cf4e3615375397e8f07d9d20/chrome/browser/previews/previews_infobar_delegate.h
[modify] https://crrev.com/ec22d7ca95cfab76cf4e3615375397e8f07d9d20/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/ec22d7ca95cfab76cf4e3615375397e8f07d9d20/chrome/browser/previews/previews_infobar_tab_helper.cc
[modify] https://crrev.com/ec22d7ca95cfab76cf4e3615375397e8f07d9d20/chrome/browser/resources/interventions_internals/index.js
[modify] https://crrev.com/ec22d7ca95cfab76cf4e3615375397e8f07d9d20/components/previews/core/previews_logger.cc
[modify] https://crrev.com/ec22d7ca95cfab76cf4e3615375397e8f07d9d20/components/previews/core/previews_logger.h
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bdd37a185caa40bbfc7c1f1008d850808551e48

commit 1bdd37a185caa40bbfc7c1f1008d850808551e48
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Tue Nov 07 23:41:58 2017

Revert "Reland "Added InfoBar event to chrome://interventions-internals.""

This reverts commit ec22d7ca95cfab76cf4e3615375397e8f07d9d20.

Reason for revert: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/64512

Original change's description:
> Reland "Added InfoBar event to chrome://interventions-internals."
> 
> A new event log is added to the page, showing which type of previews
> info bar is displayed on the page. This is an indication of which type
> of preview is served on the page.
> 
> Fixed previews_infobar_delegate_unittest PreviewsIOData mocking.
> 
> Bug:  780615 
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: Ic5a32e3fec73d5ad930973e35ac0fe82afc61d24
> Reviewed-on: https://chromium-review.googlesource.com/755545
> Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
> Reviewed-by: Tarun Bansal <tbansal@chromium.org>
> Commit-Queue: Thanh Le <thanhdle@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#514553}

TBR=tbansal@chromium.org,ryansturm@chromium.org,thanhdle@chromium.org

Change-Id: Iae4469954dbb8e979e21b6fc1410a9249c466c51
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  780615 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/757700
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514649}
[modify] https://crrev.com/1bdd37a185caa40bbfc7c1f1008d850808551e48/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
[modify] https://crrev.com/1bdd37a185caa40bbfc7c1f1008d850808551e48/chrome/browser/previews/previews_infobar_delegate.cc
[modify] https://crrev.com/1bdd37a185caa40bbfc7c1f1008d850808551e48/chrome/browser/previews/previews_infobar_delegate.h
[modify] https://crrev.com/1bdd37a185caa40bbfc7c1f1008d850808551e48/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/1bdd37a185caa40bbfc7c1f1008d850808551e48/chrome/browser/previews/previews_infobar_tab_helper.cc
[modify] https://crrev.com/1bdd37a185caa40bbfc7c1f1008d850808551e48/chrome/browser/resources/interventions_internals/index.js
[modify] https://crrev.com/1bdd37a185caa40bbfc7c1f1008d850808551e48/components/previews/core/previews_logger.cc
[modify] https://crrev.com/1bdd37a185caa40bbfc7c1f1008d850808551e48/components/previews/core/previews_logger.h
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d607300cb5a7973afd97b90538b1b321565f52d

commit 2d607300cb5a7973afd97b90538b1b321565f52d
Author: Thanh Le <thanhdle@chromium.org>
Date: Wed Nov 08 22:31:45 2017

Reland "Added InfoBar event to chrome://interventions-internals."

A new event log is added to the page, showing which type of previews
info bar is displayed on the page. This is an indication of which type
of preview is served on the page.

Disabled previews_infobar_delegate_unittest on Windows. Added TODO for
fixing timeout issue tests on Win tests (dbg).  crbug.com/782740 .

Bug:  780615 
Change-Id: I704823d43246d8a504b1f1da1872d6fb1b5d4c22
Reviewed-on: https://chromium-review.googlesource.com/758808
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Thanh Le <thanhdle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514974}
[modify] https://crrev.com/2d607300cb5a7973afd97b90538b1b321565f52d/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc
[modify] https://crrev.com/2d607300cb5a7973afd97b90538b1b321565f52d/chrome/browser/previews/previews_infobar_delegate.cc
[modify] https://crrev.com/2d607300cb5a7973afd97b90538b1b321565f52d/chrome/browser/previews/previews_infobar_delegate.h
[modify] https://crrev.com/2d607300cb5a7973afd97b90538b1b321565f52d/chrome/browser/previews/previews_infobar_delegate_unittest.cc
[modify] https://crrev.com/2d607300cb5a7973afd97b90538b1b321565f52d/chrome/browser/previews/previews_infobar_tab_helper.cc
[modify] https://crrev.com/2d607300cb5a7973afd97b90538b1b321565f52d/components/previews/core/previews_logger.cc
[modify] https://crrev.com/2d607300cb5a7973afd97b90538b1b321565f52d/components/previews/core/previews_logger.h

Comment 8 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 9 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews
►

Sign in to add a comment