CertVerifier should be per-profile |
|||
Issue descriptionCurrently CertVerifier is a "global" object owned by the system request context and shared by multiple profile URLRequestContexts (except on chromeos). Making it per-profile is cleaner and is necessary for some further features and cleanups (see blocking bugs).
,
Nov 2 2017
CC'ing mmenke as FYI, as this was something that came up with s13n over the fact that it was a shared global object. I totally agree this is the right thing to do.
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/61f802f7aae3afac789effd8fe8721ffadb285b7 commit 61f802f7aae3afac789effd8fe8721ffadb285b7 Author: Matt Mueller <mattm@chromium.org> Date: Fri Nov 03 00:40:29 2017 Clean up ChromeOS CertVerifier creation and ownership Bug: 780611 Change-Id: I1222d6898ee02083942102e3d31ea49fec0b4af2 Reviewed-on: https://chromium-review.googlesource.com/749673 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#513637} [modify] https://crrev.com/61f802f7aae3afac789effd8fe8721ffadb285b7/chrome/browser/profiles/profile_io_data.cc [modify] https://crrev.com/61f802f7aae3afac789effd8fe8721ffadb285b7/chrome/browser/profiles/profile_io_data.h
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d8e16ca0ca8c9b5f4f7efd797fa58fd958b819d commit 3d8e16ca0ca8c9b5f4f7efd797fa58fd958b819d Author: Matt Mueller <mattm@chromium.org> Date: Fri Nov 03 03:58:26 2017 Make CertVerifier per-profile objects. Also explicitly create the CertVerifier rather than using CertVerifier::CreateDefault. Bug: 780611 Change-Id: Idbcd9d8b193684fff66739171e210bb965eed646 Reviewed-on: https://chromium-review.googlesource.com/750102 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#513673} [modify] https://crrev.com/3d8e16ca0ca8c9b5f4f7efd797fa58fd958b819d/chrome/browser/io_thread.cc [modify] https://crrev.com/3d8e16ca0ca8c9b5f4f7efd797fa58fd958b819d/chrome/browser/profiles/profile_io_data.cc
,
Nov 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/38c82b03492d6fd1b64aefeb58c9c4211537d1c5 commit 38c82b03492d6fd1b64aefeb58c9c4211537d1c5 Author: Matt Mueller <mattm@chromium.org> Date: Thu Nov 09 02:37:00 2017 Remove URLRequestBuilder::set_shared_cert_verifier. When using ProfileIOData::SetCertVerifierForTesting, the test verifier is wrapped in a per-profile object that queries the shared verifier. The lifetime requirements are unchanged (the test cert verifier must outlive any profiles using it). Bug: 780611 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9be3d8e7591cf55a03d08382a82ef2f8124152a2 Reviewed-on: https://chromium-review.googlesource.com/756016 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#515065} [modify] https://crrev.com/38c82b03492d6fd1b64aefeb58c9c4211537d1c5/chrome/browser/profiles/profile_io_data.cc [modify] https://crrev.com/38c82b03492d6fd1b64aefeb58c9c4211537d1c5/net/url_request/url_request_context_builder.cc [modify] https://crrev.com/38c82b03492d6fd1b64aefeb58c9c4211537d1c5/net/url_request/url_request_context_builder.h
,
Nov 9 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by eroman@chromium.org
, Nov 2 2017