New issue
Advanced search Search tips

Issue 780609 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

PDF Fuzzers not included in tryjobs

Project Member Reported by rharrison@chromium.org, Nov 1 2017

Issue description

It appears at least some of the PDF fuzzer targets are not included in the trybot builds. During a code review it was pointed out that there was a typo in the code I had written for a platform different from my dev env. This hadn't caused the corresponding tryjob to fail, but it would have caused build issues if it had landed.
 
Cc: mmoroz@chromium.org
Specifically, pdf/pdfium/fuzzers/pdfium_fuzzer_helper.cc had an error in a CL and the try jobs for that CL came back all green. The file is in the pdfium_fuzzer target.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d9d06109e7853a10b8a4a3c05812638d97f2c5b

commit 5d9d06109e7853a10b8a4a3c05812638d97f2c5b
Author: Ryan Harrison <rharrison@chromium.org>
Date: Wed Nov 08 15:54:57 2017

Add PDF fuzzers as additional compile targets

This is done to make sure that commits for the fuzzer implementation
code are built before submitting, since build failures in the fuzzer
code currently are not detected and would be a pain to debug from
ClusterFuzz starting to fail.

The additional compile targets only need to be added to Win and Mac,
because the Linux & CrOS builds already build the All target.

BUG= chromium:780609 

Change-Id: I048665a6e71dae6ad25ccf690bb67d40a9fa4cc1
Reviewed-on: https://chromium-review.googlesource.com/757221
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514845}
[modify] https://crrev.com/5d9d06109e7853a10b8a4a3c05812638d97f2c5b/pdf/pdfium/fuzzers/BUILD.gn
[modify] https://crrev.com/5d9d06109e7853a10b8a4a3c05812638d97f2c5b/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/5d9d06109e7853a10b8a4a3c05812638d97f2c5b/testing/buildbot/chromium.win.json
[modify] https://crrev.com/5d9d06109e7853a10b8a4a3c05812638d97f2c5b/testing/buildbot/gn_isolate_map.pyl

Status: Fixed (was: Assigned)

Sign in to add a comment