Progress request handler doesn't handle request with gerrit details and no run ID |
|||
Issue description$ curl 'https://tricium-prod.appspot.com/prpc/tricium.Tricium/Progress' -H 'content-type: application/json' -H 'accept: application/json' --data-binary '{"consumer": "GERRIT", "gerrit_details": {"project": "playground/gerrit-tricium/demo", "change": "playground/gerrit-tricum/demo~master~Ie226266e04b2d0ff2b08ad16577795a4297ce01a", "revision": "refs/changes/78/701778/1"}}' Actual Response: invalid run ID Expected response: Progress response, or some other error. The fix will likely be a minor change in https://cs.chromium.org/chromium/infra/go/src/infra/tricium/appengine/frontend/rpc_progress.go.
,
Nov 3 2017
https://crrev.com/c/750809
,
Nov 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/0656e799facfcba1e0827017c4de2a892f678959 commit 0656e799facfcba1e0827017c4de2a892f678959 Author: Emma <emso@chromium.org> Date: Mon Nov 06 10:03:59 2017 Allows for no run ID in progress request for Gerrit change Reorders the code to not process the run ID field prematurely. Tested with the local dev server to verify that processing of a progress request, with Gerrit details and no run ID, proceeds to look for Gerrit change details. Bug:780605 Change-Id: I55451e55f476e18d15640745f60eb0ad5996321c Reviewed-on: https://chromium-review.googlesource.com/750809 Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Emma Söderberg <emso@chromium.org> [modify] https://crrev.com/0656e799facfcba1e0827017c4de2a892f678959/go/src/infra/tricium/appengine/frontend/rpc_progress.go
,
Nov 6 2017
Released and tested on tricium-dev, then released to tricium-prod. |
|||
►
Sign in to add a comment |
|||
Comment 1 by emso@chromium.org
, Nov 2 2017Error on the server: failed to parse run ID: :: {"error":"strconv.ParseInt: parsing \"\": invalid syntax"}