New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780583 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Service manifest should have an option to specify a service is to be run with elevated privileges on Windows.

Project Member Reported by jcivelli@chromium.org, Nov 1 2017

Issue description

As part of the servicification effort, some Windows specific services (for example WIFI utility) need to run with elevated privileges.
The service manifest should provide a way to specify that and the service manager should enforce it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c7f3bfb62bad8bd546a4ed5843bcd04bd3e9781

commit 0c7f3bfb62bad8bd546a4ed5843bcd04bd3e9781
Author: Jay Civelli <jcivelli@chromium.org>
Date: Tue Nov 07 16:41:22 2017

Adding a new sandbox type for Windows' elevated privileges mode.

In order for Windows specific services that need to run with elevated
privileges, introducing a new sandbox type that can be used in the
service's manifest to make the service's process run without sandbox and
with elevated privileges. It's equivalent to no-sandbox on non Windows
platforms.
As part of that, removing the current API in UtilityprocessHost used to set
the extra privilege mode on top of the no sandbox setting.

Bug:  780583 
Change-Id: I7e122498d2cc6e6be368fbfc1850ec8cb776141e
Reviewed-on: https://chromium-review.googlesource.com/749692
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514490}
[modify] https://crrev.com/0c7f3bfb62bad8bd546a4ed5843bcd04bd3e9781/chrome/utility/DEPS
[modify] https://crrev.com/0c7f3bfb62bad8bd546a4ed5843bcd04bd3e9781/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/0c7f3bfb62bad8bd546a4ed5843bcd04bd3e9781/content/browser/utility_process_host_impl.cc
[modify] https://crrev.com/0c7f3bfb62bad8bd546a4ed5843bcd04bd3e9781/content/browser/utility_process_host_impl.h
[modify] https://crrev.com/0c7f3bfb62bad8bd546a4ed5843bcd04bd3e9781/content/browser/utility_process_host_impl_browsertest.cc
[modify] https://crrev.com/0c7f3bfb62bad8bd546a4ed5843bcd04bd3e9781/content/public/browser/utility_process_host.h
[modify] https://crrev.com/0c7f3bfb62bad8bd546a4ed5843bcd04bd3e9781/content/public/browser/utility_process_mojo_client.h
[modify] https://crrev.com/0c7f3bfb62bad8bd546a4ed5843bcd04bd3e9781/content/public/common/content_switches.cc
[modify] https://crrev.com/0c7f3bfb62bad8bd546a4ed5843bcd04bd3e9781/content/public/common/content_switches.h
[modify] https://crrev.com/0c7f3bfb62bad8bd546a4ed5843bcd04bd3e9781/services/service_manager/sandbox/sandbox_type.cc
[modify] https://crrev.com/0c7f3bfb62bad8bd546a4ed5843bcd04bd3e9781/services/service_manager/sandbox/sandbox_type.h
[modify] https://crrev.com/0c7f3bfb62bad8bd546a4ed5843bcd04bd3e9781/services/service_manager/sandbox/switches.cc
[modify] https://crrev.com/0c7f3bfb62bad8bd546a4ed5843bcd04bd3e9781/services/service_manager/sandbox/switches.h
[modify] https://crrev.com/0c7f3bfb62bad8bd546a4ed5843bcd04bd3e9781/services/service_manager/tests/sandbox/sandbox_type_unittest.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment