New issue
Advanced search Search tips

Issue 780581 link

Starred by 1 user
Status: Fixed
Owner:
steveanton@chromium.org
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Some WebRTC Web Platform Tests failing with pending error message change in WebRTC

Project Member Reported by steveanton@chromium.org, Nov 1 2017 
With this WebRTC change (https://webrtc-review.googlesource.com/c/src/+/9020), the following Web Platform Tests will start failing:

external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-pranswer.html
external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-offer.html
external/wpt/webrtc/RTCPeerConnection-setLocalDescription-pranswer.html
external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-answer.html

The failures are a result of the SetLocalDescription/SetRemoteDescription error messages changing in some cases.

For now, the tests are going to be marked as OK if passing or failing, then once the WebRTC change is rolled in the expectations will be updated and the tests re-enabled.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c400dafc0e0048bf90831cd75a02e126f659e78

commit 4c400dafc0e0048bf90831cd75a02e126f659e78
Author: Steve Anton <steveanton@chromium.org>
Date: Mon Nov 06 20:22:17 2017

Allow some PeerConnection WPTs to fail in anticipation of a WebRTC roll

A pending WebRTC change will cause some PeerConnection Web Platform
Tests to start failing due to changing error messages. This allows those
tests to fail so that the build stays green once the WebRTC roll
happens.

WebRTC change: https://webrtc-review.googlesource.com/c/src/+/9020

Bug:  780581 
Change-Id: I92d849fc047618589354ad331fe65bee4f789f3c
Reviewed-on: https://chromium-review.googlesource.com/749725
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514229}
[modify] https://crrev.com/4c400dafc0e0048bf90831cd75a02e126f659e78/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be5f6e67f8f31bdd424cae565af086884dd4844e

commit be5f6e67f8f31bdd424cae565af086884dd4844e
Author: Steve Anton <steveanton@chromium.org>
Date: Wed Nov 08 17:33:14 2017

Re-enable PeerConnection WPTs that were failing after the WebRTC roll

Bug:  780581 
Change-Id: I23b9f03a37c63397dcf098851d435ed6bbfd2aaa
Reviewed-on: https://chromium-review.googlesource.com/756946
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514870}
[modify] https://crrev.com/be5f6e67f8f31bdd424cae565af086884dd4844e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/be5f6e67f8f31bdd424cae565af086884dd4844e/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setLocalDescription-pranswer-expected.txt
[modify] https://crrev.com/be5f6e67f8f31bdd424cae565af086884dd4844e/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-answer-expected.txt
[modify] https://crrev.com/be5f6e67f8f31bdd424cae565af086884dd4844e/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-offer-expected.txt
[modify] https://crrev.com/be5f6e67f8f31bdd424cae565af086884dd4844e/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setRemoteDescription-pranswer-expected.txt

Comment 3 by steveanton@chromium.org, Nov 8 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment