New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 780569 link

Starred by 3 users
Status: Fixed
Owner:
steve...@chromium.org
Closed: Nov 2017
Cc:
omrilio@chromium.org
█ krajshree@chromium.org
ajha@chromium.org
tbarzic@chromium.org
█ brajkumar@chromium.org
tbuck...@chromium.org
steve...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Bluetooth WebUI dialog should use system_web_dialog_delegate.cc

Project Member Reported by steve...@chromium.org, Nov 1 2017 
The Bluetooth pair device dialog has a few problems:
1. No title bar so it can not be dragged.
2. It uses an extra host .html file which is confusing.
3. It requires two files, bluetooth_pairing_dialog.cc and bluetoot_pairing_ui.cc to support it.
4. It duplicates a lot of code now in system_web_dialog_delegate.cc.

This change will make the bluetooth dialog consistent with the internet config and detail dialogs.

Comment 1 by steve...@chromium.org, Nov 17 2017

Cc: tbuck...@chromium.org omrilio@chromium.org ajha@chromium.org krajshree@chromium.org steve...@chromium.org brajkumar@chromium.org
 Issue 782604  has been merged into this issue.

Comment 2 by steve...@chromium.org, Nov 17 2017

Labels: -M-65 M-64

Comment 3 by steve...@chromium.org, Nov 30 2017

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95cd21fddd5f675db0325dfb6f8872d96f086192

commit 95cd21fddd5f675db0325dfb6f8872d96f086192
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Nov 30 02:45:37 2017

Make SystemWebDialogDelegate non modal and convert bluetooth dialog

This CL:
* Makes SystemWebDialogDelegate non-modal, always-on-top
* Converts BluetoothPairingDialog to use SystemWebDialogDelegate to
  simplify the code and make it consistent with Internet dialogs.

Bug:  780569 ,  780994 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I98aa584b8cfb7a31647e952ab7d2a4939924ba08
Reviewed-on: https://chromium-review.googlesource.com/792636
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520397}
[modify] https://crrev.com/95cd21fddd5f675db0325dfb6f8872d96f086192/chrome/browser/browser_resources.grd
[modify] https://crrev.com/95cd21fddd5f675db0325dfb6f8872d96f086192/chrome/browser/chromeos/BUILD.gn
[delete] https://crrev.com/1a02e4a41a2491f91ef87f3c7752ea79a4d17e5c/chrome/browser/chromeos/bluetooth/bluetooth_pairing_dialog.cc
[delete] https://crrev.com/1a02e4a41a2491f91ef87f3c7752ea79a4d17e5c/chrome/browser/chromeos/bluetooth/bluetooth_pairing_dialog.h
[delete] https://crrev.com/1a02e4a41a2491f91ef87f3c7752ea79a4d17e5c/chrome/browser/resources/chromeos/bluetooth_dialog_host.html
[delete] https://crrev.com/1a02e4a41a2491f91ef87f3c7752ea79a4d17e5c/chrome/browser/resources/chromeos/bluetooth_pair_device.html
[add] https://crrev.com/95cd21fddd5f675db0325dfb6f8872d96f086192/chrome/browser/resources/chromeos/bluetooth_pairing_dialog.html
[rename] https://crrev.com/95cd21fddd5f675db0325dfb6f8872d96f086192/chrome/browser/resources/chromeos/bluetooth_pairing_dialog.js
[modify] https://crrev.com/95cd21fddd5f675db0325dfb6f8872d96f086192/chrome/browser/resources/chromeos/compiled_resources2.gyp
[modify] https://crrev.com/95cd21fddd5f675db0325dfb6f8872d96f086192/chrome/browser/resources/chromeos/internet_config_dialog.html
[modify] https://crrev.com/95cd21fddd5f675db0325dfb6f8872d96f086192/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/95cd21fddd5f675db0325dfb6f8872d96f086192/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/95cd21fddd5f675db0325dfb6f8872d96f086192/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[add] https://crrev.com/95cd21fddd5f675db0325dfb6f8872d96f086192/chrome/browser/ui/webui/chromeos/bluetooth_pairing_dialog.cc
[add] https://crrev.com/95cd21fddd5f675db0325dfb6f8872d96f086192/chrome/browser/ui/webui/chromeos/bluetooth_pairing_dialog.h
[rename] https://crrev.com/95cd21fddd5f675db0325dfb6f8872d96f086192/chrome/browser/ui/webui/chromeos/bluetooth_pairing_dialog_browsertest-inl.h
[rename] https://crrev.com/95cd21fddd5f675db0325dfb6f8872d96f086192/chrome/browser/ui/webui/chromeos/bluetooth_pairing_dialog_browsertest.js
[delete] https://crrev.com/1a02e4a41a2491f91ef87f3c7752ea79a4d17e5c/chrome/browser/ui/webui/chromeos/bluetooth_pairing_ui.cc
[delete] https://crrev.com/1a02e4a41a2491f91ef87f3c7752ea79a4d17e5c/chrome/browser/ui/webui/chromeos/bluetooth_pairing_ui.h
[modify] https://crrev.com/95cd21fddd5f675db0325dfb6f8872d96f086192/chrome/browser/ui/webui/chromeos/internet_config_dialog.cc
[modify] https://crrev.com/95cd21fddd5f675db0325dfb6f8872d96f086192/chrome/browser/ui/webui/chromeos/internet_config_dialog.h
[modify] https://crrev.com/95cd21fddd5f675db0325dfb6f8872d96f086192/chrome/browser/ui/webui/chromeos/internet_detail_dialog.cc
[modify] https://crrev.com/95cd21fddd5f675db0325dfb6f8872d96f086192/chrome/browser/ui/webui/chromeos/internet_detail_dialog.h
[modify] https://crrev.com/95cd21fddd5f675db0325dfb6f8872d96f086192/chrome/browser/ui/webui/chromeos/system_web_dialog_delegate.cc
[modify] https://crrev.com/95cd21fddd5f675db0325dfb6f8872d96f086192/chrome/browser/ui/webui/chromeos/system_web_dialog_delegate.h
[modify] https://crrev.com/95cd21fddd5f675db0325dfb6f8872d96f086192/chrome/test/BUILD.gn
[modify] https://crrev.com/95cd21fddd5f675db0325dfb6f8872d96f086192/chrome/test/data/webui/BUILD.gn
[modify] https://crrev.com/95cd21fddd5f675db0325dfb6f8872d96f086192/ui/webui/resources/cr_components/chromeos/bluetooth_dialog.html
[modify] https://crrev.com/95cd21fddd5f675db0325dfb6f8872d96f086192/ui/webui/resources/cr_components/chromeos/bluetooth_dialog.js

Comment 5 by steve...@chromium.org, Nov 30 2017

Status: Fixed (was: Started)
►

Sign in to add a comment