All Windows Debug GPU (and GPU FYI) bots are failing webgl_conformance |
||||||
Issue descriptionFirst failing build: https://build.chromium.org/p/chromium.gpu/builders/Win7%20Debug%20%28NVIDIA%29/builds/56238 WebglConformance_conformance_glsl_misc_shader_uniform_packing_restrictions also: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Debug%20%28NVIDIA%29/builds/2171 https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28AMD%29/builds/3386 https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28NVIDIA%29/builds/21915 https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20x64%20Debug%20%28NVIDIA%29/builds/8946 Error text: The log is pretty much illegible due to spamming the contents of massive shaders testing resource limitations. Regression range: https://chromium.googlesource.com/chromium/src/+log/003376aa937b99fc6d7e182093ef55f077860945..ce39a61170d77ae40fd73cce98501b5f One ANGLE roll with one CL (note this is not a GPU.FYI bot so rolls apply): https://chromium.googlesource.com/angle/angle.git/+/c1f14fbea92bcf267d39cbce937b993913dc6578 Does not see immediately suspicious. Maybe related to an infra change? Not sure.
,
Nov 2 2017
Delegating to ANGLE sheriff. But yeah I can handle this if you don't want Corentin.
,
Nov 2 2017
,
Nov 2 2017
Delegation is fine. :)
,
Nov 2 2017
Olli, the revert of your patch doesn't compile any more: https://chromium-review.googlesource.com/c/angle/angle/+/750410 Could you please own this bug? You should be able to reproduce locally with a debug build of Chrome (I know, painful, sorry) or perhaps just a debug build of ANGLE if you can figure out how to drop one into a Release build of Chrome.
,
Nov 2 2017
All the Win Debug bots are broken running this test now. It's P1.
,
Nov 2 2017
This fix should work: https://chromium-review.googlesource.com/c/angle/angle/+/750781 I didn't test it with Chromium but I'm pretty sure it takes care of the issue. On a related note, I'm not sure if the uniform limit tests are the best they could be - some of the shaders contain extremely complex expressions that will fail ANGLE's expression depth check. We could change them so that they are better targeted: they should only fail uniform limit checks, not other checks. Another stress test could be added to specifically test expression depth limits.
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/640d597d88906f10d187235447309ba38c6705b6 commit 640d597d88906f10d187235447309ba38c6705b6 Author: Olli Etuaho <oetuaho@nvidia.com> Date: Thu Nov 02 11:40:56 2017 Add missing check in Compiler Further AST traversals should not be run in case the expression complexity check failed and set success=false. Otherwise traversal can result in stack overflow. BUG= chromium:780545 TEST=WebGL conformance tests Change-Id: Icfde8c051038c691563e199a6d3a17b1e8e5ebf5 Reviewed-on: https://chromium-review.googlesource.com/750781 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/640d597d88906f10d187235447309ba38c6705b6/src/compiler/translator/Compiler.cpp
,
Nov 2 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/b693fbf0fac5978650b2677cae7647128ddb52ab commit b693fbf0fac5978650b2677cae7647128ddb52ab Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org> Date: Thu Nov 02 12:30:31 2017 Roll skia/third_party/externals/angle2/ 4ef250333..640d597d8 (1 commit) https://chromium.googlesource.com/angle/angle.git/+log/4ef250333c5c..640d597d8890 $ git log 4ef250333..640d597d8 --date=short --no-merges --format='%ad %ae %s' 2017-11-02 oetuaho Add missing check in Compiler Created with: roll-dep skia/third_party/externals/angle2 BUG= 780545 The AutoRoll server is located here: https://angle-skia-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=skia.primary:Perf-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Perf-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Perf-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE,Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE,Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE,Test-Win10-Clang-ShuttleC-GPU-GTX960-x86_64-Debug-All-ANGLE,Build-Debian9-GCC-x86_64-Release-ANGLE TBR=stani@google.com Change-Id: I52f7a6dcfb5105c8e4614a39284dd74f7068c755 Reviewed-on: https://skia-review.googlesource.com/66661 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> [modify] https://crrev.com/b693fbf0fac5978650b2677cae7647128ddb52ab/DEPS
,
Nov 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b0ddb4a6a51d97fc09acaee19f9ffbb1d0a421a9 commit b0ddb4a6a51d97fc09acaee19f9ffbb1d0a421a9 Author: skia-deps-roller@chromium.org <skia-deps-roller@chromium.org> Date: Thu Nov 02 17:24:52 2017 Roll src/third_party/skia/ 8186cbee6..8d05a2dc0 (8 commits) https://skia.googlesource.com/skia.git/+log/8186cbee6cff..8d05a2dc09b8 $ git log 8186cbee6..8d05a2dc0 --date=short --no-merges --format='%ad %ae %s' 2017-11-02 angle-deps-roller Roll skia/third_party/externals/angle2/ 640d597d8..e1f3ad4d8 (2 commits) 2017-11-02 jvanverth Add sample mouse support to Viewer 2017-11-01 mtklein add a GM to demo dither 2017-11-02 kjlubick Add Pixelbook to tree 2017-11-02 kjlubick Make CPU coverage bot a bit faster 2017-11-01 egdaniel Remove content area from GrTextureAdjuster. 2017-11-01 ethannicholas API to cache shader binaries between runs of Skia. 2017-11-02 angle-deps-roller Roll skia/third_party/externals/angle2/ 4ef250333..640d597d8 (1 commit) Created with: roll-dep src/third_party/skia BUG= 780545 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: I5f7b3217777f85b4164faab01851bc344ff065db Reviewed-on: https://chromium-review.googlesource.com/751162 Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513532} [modify] https://crrev.com/b0ddb4a6a51d97fc09acaee19f9ffbb1d0a421a9/DEPS
,
Nov 2 2017
Thanks Olli for the fix. The uniform tests can certainly be changed to better separate concerns. If you can propose a pull request we'd really appreciate it.
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09ce14c7d3c8ef1dd4e7e32fc1ed043b703d8da9 commit 09ce14c7d3c8ef1dd4e7e32fc1ed043b703d8da9 Author: angle-deps-roller@chromium.org <angle-deps-roller@chromium.org> Date: Fri Nov 03 05:32:24 2017 Roll src/third_party/angle/ 63458a3ed..7b62cf97d (24 commits) https://chromium.googlesource.com/angle/angle.git/+log/63458a3ed819..7b62cf97d12b $ git log 63458a3ed..7b62cf97d --date=short --no-merges --format='%ad %ae %s' 2017-11-02 jmadill Refactor TextureFormatMap to store an array. 2017-11-02 jmadill Add missing reset to GL multi-view dirty bits. 2017-11-02 jmadill Use active textures mask with robust init. 2017-11-02 jmadill Vulkan: Refactor format table. 2017-11-02 oetuaho Remove repeated "success" check from compileTreeImpl 2017-10-27 jie.a.chen ES31 program query: support AtomicCounterBuffer and UniformBlock 2017-11-02 jmadill Add a meta-script to run code generators. 2017-10-27 geofflang Pass offsets to base validation for CompressedSubTexImage3D. 2017-10-28 jmadill Vulkan: Add vk::GetImpl helper. 2017-10-28 jmadill Vulkan: Allow in-flight Framebuffer changes. 2017-11-02 oetuaho Add missing check in Compiler 2017-11-01 jie.a.chen Refactor StaticallyUsed 2017-09-27 geofflang Make GL_OES_get_program_binary enableable. 2017-10-27 ynovikov Run angle_perftests on GLES backend 2017-10-28 jmadill Vulkan: Fix deleting in-use Framebuffer. 2017-10-30 geofflang Make compressed texture format extensions enableable. 2017-11-01 jmadill Vulkan: Support Texture redefinition. 2017-10-30 geofflang Make ANGLE_texture_usage enableable. 2017-10-28 jmadill Vulkan: Fix re-creating buffer storage. 2017-10-28 jmadill Introduce SimpleStateChangeTests. 2017-10-28 jmadill Remove WrappedObject::retain. 2017-10-30 geofflang Fix minor issues with ANGLE_texture_rectangle. 2017-10-30 cwallez preprocessor: Fix lineno overflow on line continuations 2017-11-01 geofflang Revert BGRA renderability change for ES drivers. Created with: roll-dep src/third_party/angle BUG= 780545 ,675997, 774807 , 779346 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ic633a311ad465c126e473a2c38704b034c7e799d Reviewed-on: https://chromium-review.googlesource.com/752511 Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#513699} [modify] https://crrev.com/09ce14c7d3c8ef1dd4e7e32fc1ed043b703d8da9/DEPS
,
Nov 9 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kbr@chromium.org
, Nov 2 2017Status: Assigned (was: Untriaged)
Summary: All Windows Debug GPU (and GPU FYI) bots are failing webgl_conformance (was: All Windows Debug GPU (and GPU FYI) bots are failing webgl_conformance on )