Issue metadata
Sign in to add a comment
|
Client LoFi savings should count towards Effecitve OCL |
||||||||||||||||||||||||
Issue descriptionCurrently, DRP utils expose EstimateOriginalReceivedBytes and CalculateEffectiveOCL. These are both used by production code. Client LoFi has a special code path within EstimateOriginalReceivedBytes that does not have an analogous code path in EstimateOriginalReceivedBytes (EstimateOriginalReceivedBytes calls CalculateEffectiveOCL). The only code path this affects negatively right now is PageLoad.Clients.DataReductionProxy.Experimental.Bytes.Network.Savings and similar histograms. I believe it would make more sense if we had a CalculateOriginalHeadersBytes(...) and a CalculateEffectiveOCL(...) which are both called from EstimateOriginalReceivedBytes and handle the Client LoFi conditions appropriately. It would be nice to see the savings from Client LoFi on the DRP page load histograms. https://cs.chromium.org/chromium/src/components/data_reduction_proxy/core/common/data_reduction_proxy_util.cc?type=cs&q=data_Redu+util&l=243
,
Nov 3 2017
,
Dec 5 2017
,
Dec 5 2017
,
Jan 24 2018
Refreshed during triage.
,
Mar 21 2018
I agree fixing this issue would be nice.
,
Sep 21
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bengr@chromium.org
, Nov 3 2017Status: Available (was: Untriaged)