New issue
Advanced search Search tips

Issue 780537 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 808728
Owner: ----
Closed: Sep 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Client LoFi savings should count towards Effecitve OCL

Project Member Reported by ryansturm@chromium.org, Nov 1 2017

Issue description

Currently, DRP utils expose EstimateOriginalReceivedBytes and CalculateEffectiveOCL. These are both used by production code. Client LoFi has a special code path within EstimateOriginalReceivedBytes that does not have an analogous code path in EstimateOriginalReceivedBytes (EstimateOriginalReceivedBytes calls CalculateEffectiveOCL). The only code path this affects negatively right now is PageLoad.Clients.DataReductionProxy.Experimental.Bytes.Network.Savings and similar histograms. I believe it would make more sense if we had a CalculateOriginalHeadersBytes(...) and a CalculateEffectiveOCL(...) which are both called from EstimateOriginalReceivedBytes and handle the Client LoFi conditions appropriately.

It would be nice to see the savings from Client LoFi on the DRP page load histograms.

https://cs.chromium.org/chromium/src/components/data_reduction_proxy/core/common/data_reduction_proxy_util.cc?type=cs&q=data_Redu+util&l=243
 

Comment 1 by bengr@chromium.org, Nov 3 2017

Labels: CleanUp
Status: Available (was: Untriaged)

Comment 2 by bengr@chromium.org, Nov 3 2017

Owner: ----

Comment 3 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 4 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews
Refreshed during triage.

Comment 6 by bengr@chromium.org, Mar 21 2018

I agree fixing this issue would be nice.
Labels: -CleanUp cleanup
Mergedinto: 808728
Status: Duplicate (was: Available)

Sign in to add a comment