This will allow us to see at a glance what metrics are collected right now and in future as more are added.
I created this spreadsheet with all the notification UMA I could find: https://docs.google.com/a/google.com/spreadsheets/d/1qtp80LJai5xVljJsKhFn6W2W-I2swa1ci9wCSzZRd0E/edit?usp=sharing
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8eeafee58078f957d40ad1c8b2a89a5ff71573a8 commit 8eeafee58078f957d40ad1c8b2a89a5ff71573a8 Author: Anita Woodruff <awdf@chromium.org> Date: Wed Nov 08 15:43:41 2017 [Notification Tests] Test UMA sent in interactive ui tests - Previously we did not test the UMA sent from PlatformNotificationServiceImpl. - Now all but one stat is tested (It's hard to test Notification.Persistent.ClickedWithoutPermission from a UI test). - This paves the way for refactoring the UMA-logging into a separate class. Bug: 780534 Change-Id: I975679688f57608e22c107ab6f7944e7fc09ed3e Reviewed-on: https://chromium-review.googlesource.com/758643 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#514841} [modify] https://crrev.com/8eeafee58078f957d40ad1c8b2a89a5ff71573a8/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29eb39f8cb79ea6bd8dad55feddc42b39ac4c641 commit 29eb39f8cb79ea6bd8dad55feddc42b39ac4c641 Author: Anita Woodruff <awdf@chromium.org> Date: Thu Nov 16 21:00:05 2017 [Notifications] Extract metric logging from PlatformNotificationService - Created a KeyedService, NotificationMetricsLogger, now called by PlatformNotificationService to record the user actions it was previously recording inline. Bug: 780534 Change-Id: Icde7dbf2d141359098043c6b8745d709178e4498 Reviewed-on: https://chromium-review.googlesource.com/766792 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#517183} [modify] https://crrev.com/29eb39f8cb79ea6bd8dad55feddc42b39ac4c641/chrome/browser/BUILD.gn [add] https://crrev.com/29eb39f8cb79ea6bd8dad55feddc42b39ac4c641/chrome/browser/notifications/metrics/mock_notification_metrics_logger.cc [add] https://crrev.com/29eb39f8cb79ea6bd8dad55feddc42b39ac4c641/chrome/browser/notifications/metrics/mock_notification_metrics_logger.h [add] https://crrev.com/29eb39f8cb79ea6bd8dad55feddc42b39ac4c641/chrome/browser/notifications/metrics/notification_metrics_logger.cc [add] https://crrev.com/29eb39f8cb79ea6bd8dad55feddc42b39ac4c641/chrome/browser/notifications/metrics/notification_metrics_logger.h [add] https://crrev.com/29eb39f8cb79ea6bd8dad55feddc42b39ac4c641/chrome/browser/notifications/metrics/notification_metrics_logger_factory.cc [add] https://crrev.com/29eb39f8cb79ea6bd8dad55feddc42b39ac4c641/chrome/browser/notifications/metrics/notification_metrics_logger_factory.h [add] https://crrev.com/29eb39f8cb79ea6bd8dad55feddc42b39ac4c641/chrome/browser/notifications/metrics/notification_metrics_logger_unittest.cc [modify] https://crrev.com/29eb39f8cb79ea6bd8dad55feddc42b39ac4c641/chrome/browser/notifications/platform_notification_service_impl.cc [modify] https://crrev.com/29eb39f8cb79ea6bd8dad55feddc42b39ac4c641/chrome/browser/notifications/platform_notification_service_unittest.cc [modify] https://crrev.com/29eb39f8cb79ea6bd8dad55feddc42b39ac4c641/chrome/test/BUILD.gn
Comment 1 by awdf@chromium.org
, Nov 6 2017