For correctness, change the type of callbacks which are invoked one time only from base::Callback to base::OnceCallback. Same for closures. This is a mechanical change. A further change will do a similar refactoring for the component installers.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8ef73d866ea6f294622257df34e2c7215e2fca1 commit a8ef73d866ea6f294622257df34e2c7215e2fca1 Author: Sorin Jianu <sorin@chromium.org> Date: Thu Nov 02 16:55:17 2017 Refactor update_client to use base::OnceCallback. For correctness, change the type of callbacks which are invoked one time only from base::Callback to base::OnceCallback. Same for closures. This is a mechanical change. BUG= 780524 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I29c9b2bab9e83695f0ac041a95a23545ef852a81 Reviewed-on: https://chromium-review.googlesource.com/741037 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#513520} [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/chrome/browser/component_updater/component_patcher_operation_out_of_process.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/chrome/browser/component_updater/component_patcher_operation_out_of_process.h [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/chrome/browser/component_updater/component_patcher_operation_out_of_process_browsertest.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/chrome/browser/component_updater/recovery_component_installer.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/chrome/browser/policy/policy_browsertest.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/component_updater/component_installer.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/component_updater/component_installer.h [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/component_updater/component_installer_unittest.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/component_updater/component_updater_service.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/component_updater/component_updater_service.h [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/component_updater/component_updater_service_internal.h [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/component_updater/component_updater_service_unittest.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/component_updater/mock_component_updater_service.h [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/component_updater/timer_unittest.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/action_runner.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/action_runner.h [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/action_runner_win.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/component.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/component.h [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/component_patcher.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/component_patcher.h [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/component_patcher_operation.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/component_patcher_operation.h [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/component_patcher_unittest.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/component_unpacker.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/component_unpacker.h [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/component_unpacker_unittest.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/crx_downloader.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/crx_downloader.h [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/crx_downloader_unittest.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/out_of_process_patcher.h [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/ping_manager.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/request_sender.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/request_sender.h [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/request_sender_unittest.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/task_send_uninstall_ping.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/task_update.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/task_update.h [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/test_installer.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/test_installer.h [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/update_checker.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/update_checker.h [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/update_checker_unittest.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/update_client.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/update_client.h [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/update_client_internal.h [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/update_client_unittest.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/update_engine.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/update_engine.h [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/url_request_post_interceptor.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/utils.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/components/update_client/utils.h [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/extensions/browser/updater/update_install_shim.cc [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/extensions/browser/updater/update_install_shim.h [modify] https://crrev.com/a8ef73d866ea6f294622257df34e2c7215e2fca1/extensions/browser/updater/update_service_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d88968f537126b68ec268b7b367f983fdbe58856 commit d88968f537126b68ec268b7b367f983fdbe58856 Author: Sorin Jianu <sorin@chromium.org> Date: Fri Nov 03 14:52:19 2017 Mechanical refactoring of component installers to use OnceCallback. Also, opportunistic changes to use make_unique and the task scheduler api Bug: 780524 Change-Id: Ibfcaaccc3fa27d8905324c5d484e07cb71de289a Reviewed-on: https://chromium-review.googlesource.com/752681 Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#513769} [modify] https://crrev.com/d88968f537126b68ec268b7b367f983fdbe58856/chrome/browser/component_updater/component_patcher_operation_out_of_process_browsertest.cc [modify] https://crrev.com/d88968f537126b68ec268b7b367f983fdbe58856/chrome/browser/component_updater/component_updater_resource_throttle.cc [modify] https://crrev.com/d88968f537126b68ec268b7b367f983fdbe58856/chrome/browser/component_updater/crl_set_component_installer.cc [modify] https://crrev.com/d88968f537126b68ec268b7b367f983fdbe58856/chrome/browser/component_updater/cros_component_installer.cc [modify] https://crrev.com/d88968f537126b68ec268b7b367f983fdbe58856/chrome/browser/component_updater/cros_component_installer.h [modify] https://crrev.com/d88968f537126b68ec268b7b367f983fdbe58856/chrome/browser/component_updater/file_type_policies_component_installer.cc [modify] https://crrev.com/d88968f537126b68ec268b7b367f983fdbe58856/chrome/browser/component_updater/origin_trials_component_installer.cc [modify] https://crrev.com/d88968f537126b68ec268b7b367f983fdbe58856/chrome/browser/component_updater/pepper_flash_component_installer.cc [modify] https://crrev.com/d88968f537126b68ec268b7b367f983fdbe58856/chrome/browser/component_updater/pnacl_component_installer.cc [modify] https://crrev.com/d88968f537126b68ec268b7b367f983fdbe58856/chrome/browser/component_updater/recovery_improved_component_installer.cc [modify] https://crrev.com/d88968f537126b68ec268b7b367f983fdbe58856/chrome/browser/component_updater/ssl_error_assistant_component_installer.cc [modify] https://crrev.com/d88968f537126b68ec268b7b367f983fdbe58856/chrome/browser/component_updater/sth_set_component_installer.cc [modify] https://crrev.com/d88968f537126b68ec268b7b367f983fdbe58856/chrome/browser/component_updater/subresource_filter_component_installer.cc [modify] https://crrev.com/d88968f537126b68ec268b7b367f983fdbe58856/chrome/browser/component_updater/supervised_user_whitelist_installer.cc [modify] https://crrev.com/d88968f537126b68ec268b7b367f983fdbe58856/chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc [modify] https://crrev.com/d88968f537126b68ec268b7b367f983fdbe58856/chrome/browser/component_updater/sw_reporter_installer_win.cc [modify] https://crrev.com/d88968f537126b68ec268b7b367f983fdbe58856/chrome/browser/component_updater/third_party_module_list_component_installer_win.cc [modify] https://crrev.com/d88968f537126b68ec268b7b367f983fdbe58856/chrome/browser/component_updater/widevine_cdm_component_installer.cc [modify] https://crrev.com/d88968f537126b68ec268b7b367f983fdbe58856/components/component_updater/timer_unittest.cc [modify] https://crrev.com/d88968f537126b68ec268b7b367f983fdbe58856/components/update_client/update_checker_unittest.cc
Comment 1 by bugdroid1@chromium.org
, Nov 2 2017