Clean up Mac status bubble code |
||||
Issue descriptionSee comment in status_bubble_mac.mm; there's a bunch of code to support older, unsupported versions of macOS and to support making the status bubble invisible instead of using orderOut: to remove it from the screen. It should be removed.
,
Jan 6 2018
,
Feb 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a80e723e5c134d659730491586c4cdf05cbb7bb8 commit a80e723e5c134d659730491586c4cdf05cbb7bb8 Author: Sidney San Martín <sdy@chromium.org> Date: Mon Feb 12 22:05:58 2018 Cherry pick space switching fixes to M64. > Work around a High Sierra bug that makes a window in an inactive space activate if it shows its status bubble. > > Starting in 10.13, adding a child window to a window in an inactive space > brings it to the front if the user is interacting with its application in the > active space. I can't find a nice workaround, and hidden windows showing a > status bubble have triggered similar issues in the past, so this workaround > waits to add the status bubble to a window until it's visible. > > Bug: 798792 , 783521 > Change-Id: I35cd7df87d74b6e1237cd91fc91acf455c443f82 > Reviewed-on: https://chromium-review.googlesource.com/849559 > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#530431} > > Delete Mac status bubble code for old OSs. > > Bug: 780521 > Change-Id: I18931966904196185e9693a80e62ae5db101c5ee > Reviewed-on: https://chromium-review.googlesource.com/853035 > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#527481} Change-Id: I45d9d384913da3d2ff9c20dde25ccd51d4edeb40 Reviewed-on: https://chromium-review.googlesource.com/914694 Reviewed-by: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/branch-heads/3282@{#670} Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840} [modify] https://crrev.com/a80e723e5c134d659730491586c4cdf05cbb7bb8/chrome/browser/ui/cocoa/status_bubble_mac.h [modify] https://crrev.com/a80e723e5c134d659730491586c4cdf05cbb7bb8/chrome/browser/ui/cocoa/status_bubble_mac.mm [modify] https://crrev.com/a80e723e5c134d659730491586c4cdf05cbb7bb8/chrome/browser/ui/cocoa/status_bubble_mac_unittest.mm [modify] https://crrev.com/a80e723e5c134d659730491586c4cdf05cbb7bb8/ui/gfx/test/ui_cocoa_test_helper.h [modify] https://crrev.com/a80e723e5c134d659730491586c4cdf05cbb7bb8/ui/gfx/test/ui_cocoa_test_helper.mm
,
Feb 13 2018
> Verified this issue on Mac OS 10.12.6 using chrome latest stable #64.0.3282.167 as per the steps mentioned in issue 783521 , observed the chrome stays hidden as expected. Note: Able to reproduce this issue on reported version of chrome #64.0.3263.0 on Mac OS 10.12.6 > verified this issue on Mac OS 10.13.3 using chrome latest stable #64.0.3282.167 as per the steps mentioned in issue 798792 , observed no desktop switch back to previous window as expected. Note: Able to reproduce this issue on reported version of chrome #65.0.3309.0 on Mac OS 10.13.3 Adding TE-Verified label based on the above verifications Thanks! |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Jan 6 2018