New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780514 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 732805



Sign in to add a comment

VideoDetectorObservers should recover after Viz restarts

Project Member Reported by samans@chromium.org, Nov 1 2017

Issue description

If Viz crashes, the connections from viz::VideoDetector to VideoDetectorObservers are lost. Either VideoDetectorObservers should be careful and re-establish the connection after Viz restarts, or VideoDetectorObservers should talk to the host instead of Viz, and behind the scenes the host should reestablish its connection to viz::VideoDetector after restarting Viz.
 
I think ash::VideoDetector observing errors on the mojo connection and re-requesting it on failure is better. The alternative would add more complexity and also requires an extra IPC message. I guess the only thing that needs to change is that ash::VideoDetector needs to know how to request the mojo interface, as opposed to now that is just given one on construction.
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 2

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Blocking: 732805
Status: Available (was: Untriaged)
Owner: samans@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1d88aae15e62250c7991ece363b184b27c22ec8

commit a1d88aae15e62250c7991ece363b184b27c22ec8
Author: Saman Sami <samans@chromium.org>
Date: Fri Nov 16 22:55:42 2018

Make ash::VideoDetector recover from viz crashes

Observe mojo connection errors and re-establish the connection once
it's lost.

Bug:  780514 
Change-Id: Ic393f737bee97b97ed588ea47040327a4b639a4b
Reviewed-on: https://chromium-review.googlesource.com/c/1340945
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609009}
[modify] https://crrev.com/a1d88aae15e62250c7991ece363b184b27c22ec8/ash/shell.cc
[modify] https://crrev.com/a1d88aae15e62250c7991ece363b184b27c22ec8/ash/system/power/video_activity_notifier_unittest.cc
[modify] https://crrev.com/a1d88aae15e62250c7991ece363b184b27c22ec8/ash/wm/video_detector.cc
[modify] https://crrev.com/a1d88aae15e62250c7991ece363b184b27c22ec8/ash/wm/video_detector.h

Status: Fixed (was: Assigned)

Sign in to add a comment