New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 780487 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Missing argument in update_use_counter.py

Project Member Reported by drott@chromium.org, Nov 1 2017

Issue description

update_histogram_enum.UpdateHistogramFromDict complains about a missing 4th argument.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00ef55bd7d397313708ce98d636c3034957843dc

commit 00ef55bd7d397313708ce98d636c3034957843dc
Author: Dominik Röttsches <drott@chromium.org>
Date: Wed Nov 01 18:23:24 2017

Fix update_use_counter.py

And execute it for the set of previous UseCounter.cpp changes.

Bug:  780487 
Change-Id: I3fbf840d5693f18d55306efc440d3f9a2120fbd2
Reviewed-on: https://chromium-review.googlesource.com/749382
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513183}
[modify] https://crrev.com/00ef55bd7d397313708ce98d636c3034957843dc/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/00ef55bd7d397313708ce98d636c3034957843dc/tools/metrics/histograms/update_use_counter_css.py

Comment 2 by drott@chromium.org, Nov 2 2017

Status: Fixed (was: Started)

Sign in to add a comment